From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f49.google.com (mail-wm1-f49.google.com [209.85.128.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 88FC520E709 for ; Fri, 10 Jan 2025 14:39:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.49 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736519974; cv=none; b=MbQep+lRN00gyqpKnYwEpZ5tfgilD+pxKHLyzaeNLmSpCIc1NKlf0etu/CxeJ28txrF4+pTEgj8+sdlXd5flUFv7mSnwuoOtINuExH4ZbX4QpQ7qNf7/wkynLSgvqoDrR3H32MyegA3qlhkuDKKG53ABzsR854KbK3A2HafElvw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736519974; c=relaxed/simple; bh=dNcVzZTesBokg/jzESekrq3gcdde//x7yKqO6CtNHGM=; h=Mime-Version:Content-Type:Date:Message-Id:Cc:Subject:From:To: References:In-Reply-To; b=jDg9sOAOPytgsPig3aqOzLoFxu+gUXXAtsv9Y8ziOGnKoF5Ojsn6/vSa7urIyfXZJN0DB7/cjEuhHRVcHQJI+kfnxWWNtA1J7c7IOIXoa+xbPDekpGc0jwODW+y6pHUWYP80PWbfig40J8IFriqeMI2i7+mi1ReORVmrxrNO8lk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=HjYkbY5B; arc=none smtp.client-ip=209.85.128.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="HjYkbY5B" Received: by mail-wm1-f49.google.com with SMTP id 5b1f17b1804b1-4362f61757fso21239475e9.2 for ; Fri, 10 Jan 2025 06:39:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1736519971; x=1737124771; darn=vger.kernel.org; h=in-reply-to:references:to:from:subject:cc:message-id:date :content-transfer-encoding:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=yvV3AHUuYO6Tr9wrbauX5wDzxdO09agrWxXF+HRfAWU=; b=HjYkbY5BRbbMZ0l9kgNjutWDNTtw3NLD825Z+YvjmMW6HodK/yZSECY1R95IoQ4B3v upvLo5uJybvtN+tXKso7M+ilEPLQ30XZmoM60B8DXC7rOufKjKHFOEP7eamqgrzPTqzF b8jBb0Q+xB2jt2ZnXbZf7i/Mp7S3LpKGGrpPQ6oiplkjDU5RDYXxjeI7m6oFSDzy9qMu ti7ZZMgR8Nn05/b62oZOp5pOUAZI0ZEcKAm2dHNULe1ddVYK5hKiOqB+LY1u2XJS7+NR qjS8WrEUPPZXcS9FFGXnR2YBr/eIhQaH6NgXYA3TsQfXOPJoxkKc5YzhDVEuYXq5eXzu uvjA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736519971; x=1737124771; h=in-reply-to:references:to:from:subject:cc:message-id:date :content-transfer-encoding:mime-version:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=yvV3AHUuYO6Tr9wrbauX5wDzxdO09agrWxXF+HRfAWU=; b=fc5nL6yXx12LZxekeXimdZmWJRoIgplc6YsLmW6qUBbrayS7VNPLxmyqma9k7LkNTi Ltk/gYUB0CtDG7ZG+aXJeOWPVMXwrtTkLmGq9S78FGukp3t/qFhIdmS8bZYytKBpTAZ3 +jUV+7dR7Ng+p4djHFJcPV7KCUzGF5NoFBkjvRU4z7IX577bIlVh69fQQva/7U4vOtAg O6UrEijU7nmUSThOTECvfhmc4glw7NV2ftEnpiM9Hfjjdil2w6CPcyqNbJQ/BAW4kfmY T2nezH5QKZtuShMKIzDlEgbjVdUkmEEfeiPBbXasVZDzm9G81a+hmHGxaFjpMSwY4iu3 EPWw== X-Forwarded-Encrypted: i=1; AJvYcCWHt5uY5ZOjyMLF/54Z5FTJlRdgHVaNOE2uUk9RDca9weyUKcv/DFbOoKcJaZkt7C6fZjkUM138/IKqe3k=@vger.kernel.org X-Gm-Message-State: AOJu0YxxCW5OupJtTpYIKERvwciORpPmraAzDFazty5TjLKzcGGYaFNx uMUSpnYrnC+gZTBQw0b9+egGEtqMkx/HO/S06sZDYPdsl5jE/xKOJtOiAE9s4F4= X-Gm-Gg: ASbGnctEWp9g0zFazfHdwi3JJa20xphRXpuDfFQy3oIYDPivwTYgTsnYPjIGXu1cTyO WzVvb6EFgN/UhbBunX/hCnYgns/lbgByok58xKauRRJwDl1uvrFn8xiqMF9dBBDeUmSudq0dqj9 USjIZk7j5ilF7rh9/MMm5xkvzy6M0uCQazBzVjRhsBFEXEvMKM+xIEgcCDGO5tDs8oGTd1tOgo9 MQ7a1szCtk4lborPXHoRnW66sQnlfZfuuof+8RHL/UJG0w3w+RETw0= X-Google-Smtp-Source: AGHT+IFsvuIAj4E6ymt7QQeU2pHWrvkUqe+Ac8WeW/VVn+1zRvvfjuYtDvvzhEKp8rrWDBKxsvfdDA== X-Received: by 2002:a05:6000:1563:b0:385:f44a:a53 with SMTP id ffacd0b85a97d-38a872cfe40mr8748169f8f.4.1736519970862; Fri, 10 Jan 2025 06:39:30 -0800 (PST) Received: from localhost ([2a01:e0a:448:76e0:cfad:dcf2:8a42:1d83]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-38a8e37d447sm4625706f8f.4.2025.01.10.06.39.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 10 Jan 2025 06:39:30 -0800 (PST) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Fri, 10 Jan 2025 15:39:29 +0100 Message-Id: Cc: "Lars-Peter Clausen" , "Michael Hennerich" , =?utf-8?q?Nuno_S=C3=A1?= , "Rob Herring" , "Krzysztof Kozlowski" , "Conor Dooley" , "Jonathan Corbet" , , , , Subject: Re: [PATCH v2 2/6] iio: adc: ad4030: add driver for ad4030-24 From: "Esteban Blanc" To: "Jonathan Cameron" , "Marcelo Schmitt" X-Mailer: aerc 0.18.2 References: <20241219-eblanc-ad4630_v1-v2-0-f36e55907bf5@baylibre.com> <20241219-eblanc-ad4630_v1-v2-2-f36e55907bf5@baylibre.com> <20241223120419.757eadfb@jic23-huawei> In-Reply-To: <20241223120419.757eadfb@jic23-huawei> On Mon Dec 23, 2024 at 1:04 PM CET, Jonathan Cameron wrote: > > Just commenting on one particular bit feedback. Makes sure to address the > rest! > > > > + > > > +static int ad4030_get_chan_calibscale(struct iio_dev *indio_dev, > > > + struct iio_chan_spec const *chan, > > > + int *val, > > > + int *val2) > > > +{ > > > + struct ad4030_state *st =3D iio_priv(indio_dev); > > > + u16 gain; > > > + int ret; > > > + > > > + ret =3D regmap_bulk_read(st->regmap, AD4030_REG_GAIN_CHAN(chan->add= ress), > > > + st->rx_data.raw, AD4030_REG_GAIN_BYTES_NB); > > > + if (ret) > > > + return ret; > > > + > > > + gain =3D get_unaligned_be16(st->rx_data.raw); =20 > > My impression is that it is a bit odd to handle endianness after/before > > calling regmap_read/write(). Can you try set > > .val_format_endian_default =3D REGMAP_ENDIAN_BIG, in ad4030_regmap_bus? > > If that doesn't help, what about doing the get/set_unaligned stuff with= in > > the bus read/write calls? > > Unless these are all 16 bit registers (in which case push it into the > regmap side of things), then a bulk read is not implying the registers > read are one value. They could just be a load of registers next to each o= ther. > As such the regmap core won't touch them and endian conversion here, at t= he > layer where we know they are related is the right thing to do. > > It's not worth dual regmap stuff just because we have a few pairs of > registers.=20 In fact I've already set `.val_format_endian_default =3D REGMAP_ENDIAN_BIG` but it has any effect as registers are 8bits long. Most of the time registers are not related to each other. It's only for offset and scale that multiple registers form one number --=20 Esteban Blanc BayLibre