From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f54.google.com (mail-wr1-f54.google.com [209.85.221.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0348B3EA957 for ; Sat, 17 Oct 2026 19:01:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1792263722; cv=none; b=EeBydTSuPoZt1GOXbISOo3mIQIeswOHU/IJK6KqNp2kATRUqg7/MngqJr9FI1JxbLPZWO1HcIdyuO1KnD9f3ojsmeLDx2dGjhe86E5k1DPsbKPtwNpwVxj9sIs2IlxgnGYtvDlPM8uRCh6+gdENlFbuIhLY9yG9oz+MVx7P/o74= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1792263722; c=relaxed/simple; bh=OLRW7s+yNC5tjl37gTdFreL7HOCnw4vNpy7AfT7FaTw=; h=From:Content-Type:Mime-Version:Subject:In-Reply-To:Date:Cc: Message-Id:References:To; b=cCduhrP9GbrX71kV3bcAB0lqguWc02hTIc+AMR805J2XruIZebFfyjtmMj/cOwyO0gakXLFQvBVxcTuzHYZ4no9YOfgaznJ+79InQnvGCbN4qFhmhDxIVXX7qWlsnAMqQ9rEQ3F/2VAXvtAyql/X2nyjIebBZauvvtHNPlxfAT8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=FFgc+8+z; arc=none smtp.client-ip=209.85.221.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="FFgc+8+z" Received: by mail-wr1-f54.google.com with SMTP id ffacd0b85a97d-48dfc0421d9so525859f8f.1 for ; Sat, 17 Oct 2026 12:01:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1792263718; x=1792868518; darn=vger.kernel.org; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:subject:mime-version:content-type:from:from:to:cc :subject:date:message-id:reply-to:content-type; bh=vJ3S+zrJ53PJeoB13lI44vseeQL6ZkTaT4zeMMelbtg=; b=FFgc+8+z64PqZZkaSVGU367jYwpOweJeg4qYh+D/KYJIk9fq+4utO6uW5+zHJJ4Wnp 1884cDf3lzG7fzIAVymVQwmTj5ENqEa22itVXL+rNjDGnpcArWsXeiUDwxsmVgBbQp9z aVzjTdoGQnNwh3UHsubIzWIf5zdxIXETVckw7YIKCrj7wSHOYz1FCv3xHgyj0DhGIXdF 0nsGhSQe6NxpjH0aHBHxozQNyz/KJSFR4vjKSpu9II9CkkjwuvtGtiFdJiAc5Q4RGipX MRJInq7jbsrqxzfyhL+exp2Qqezh1YO7PBQgoupkgLG/AWl3rrqZ1m00Mk29uzflLjlW dZTw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1792263718; x=1792868518; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:subject:mime-version:content-type:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=vJ3S+zrJ53PJeoB13lI44vseeQL6ZkTaT4zeMMelbtg=; b=G1TCE34tZ/o7IK0honsds0p63QF65VZvW0Q3OMnERlt+ITZr7/EW2rtd1Hn6v140te DtTA4GplcOzTR84PjLL73Nf39mShZYCfv/+8loGB3nkwhZRCOp279clz2+7Gb79Vp2Qv PlvACAH0jdMQ/g+bJN1UxS6DNKJ9ZiDbYYcGMRiYB7Rp1SQN6wJAYdVBb4tUhpS+IiTV HU8CRN+y24ob9YA/8Jh1ou+aOjV8BVMe6rh0dcsw+y9du6f1DQuGCBS/BUa/9Y/3KNiN VHgfRv6SarXPYUj511CFhOBfp31+fa1fwhYGlqBXZEqvAGfcleh8pBASNphv4hGAfuDF Ff9A== X-Forwarded-Encrypted: i=1; AKwUvByw5HcN3FQTpWNJJGKOIode5wblI0Xkt6JhCLAPBvqNtm/Q4F4kNnnFKnlvVOYJ5gQfe/ut9E32AwZluLQ=@vger.kernel.org X-Gm-Message-State: AFq9FYLgmLdJjF7JW7N+JZm4FgbtAL8Dp2h5QxG+TBAk2Dt2LKh9xsen hEjo/9q5Rztqg3sd0aBGVuWLRQVjsXtJjSWaqouIqYI74PpBoZtOqrQ5 X-Gm-Gg: AYBFou2BwjH4ZqwkAj8dpdiG2yPYmpv/Qy/Ti5jzG2SYREhwpyFqBYsbIpuB8tnR257 mATmC3LyPpW4HDaqPq7CCYQ8sutx2K7XTk1cEXyZstqJNVx7I1RKrYZX3C/OJg1ovoqP9B9hkJK Bi84Z4LFJG6wqlhUlSoQAXiDEXZ6gGep8WrYx2ypQ2TcRZn5+foJIpch9fNJSTiT79Thpyj50vV 1/lDjPnalStVaAX3/jaBGuIFvPDMw+Zu/aHthyKFur7Q3SW1+0mUiGCKq1TPZVXEcEdQrtlIieF y6tySN7c9OOnucin0flKxf13hugrlyak9+13tZiB7MtwLhSQt0ByrgaPNxLXl1oTWs+lkU2fgEa Vc3BXDklDd2JJbf0nWOau/mAgSNB7UCeNL4Dtz1Va6jlADul/dKzZU7hi8cr5x6EgvRj+tYgWDZ H9RsZscNc8sFxj+SNhv0VyzmJUoI2Ui4t7Jt2oacQL0QGTEGu6AEfYyfhQnUlOdIsOeagW7vBs5 UC2F8eRlGfKRR7u5QPJ6gZs82r4INyvE5nNJLiMTDXwhSXoCgLuHtD34QYbUr0b+al2I5Qe1sFc 1hIWuy6muoKeQHDhaT30vrTg0iJnTg8K/w3GBuRXR0u3lsYrKmflYffoiH4dFtpMTGAFxKJzv9Z EwCFvhF07VbHszYo8 X-Received: by 2002:a05:6000:24c7:b0:48e:e98:8b6a with SMTP id ffacd0b85a97d-48e0e988e86mr1971222f8f.4.1792263717875; Sat, 17 Oct 2026 12:01:57 -0700 (PDT) Received: from smtpclient.apple (dynamic-2a00-1028-8388-a84e-4dec-301f-bf3e-93cd.ipv6.o2.cz. [2a00:1028:8388:a84e:4dec:301f:bf3e:93cd]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-48dfd4f8bd9sm13074929f8f.35.2026.10.17.12.01.54 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sat, 17 Oct 2026 12:01:57 -0700 (PDT) From: Josef Schlehofer X-Google-Original-From: Josef Schlehofer Content-Type: text/plain; charset=utf-8 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3901.100.1.1.12\)) Subject: Re: [PATCH v3 2/2] leds: Add support for Turris 1.x LEDs In-Reply-To: Date: Sat, 17 Oct 2026 21:01:44 +0200 Cc: Lee Jones , Pavel Machek , Rob Herring , Krzysztof Kozlowski , Conor Dooley , =?utf-8?Q?Pali_Roh=C3=A1r?= , Andy Shevchenko , Rong Zhang , linux-leds@vger.kernel.org, devicetree@vger.kernel.org, linux-api@vger.kernel.org, linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Message-Id: References: <20260928111907.72592-1-pepe.schlehofer@gmail.com> <20260928111907.72592-3-pepe.schlehofer@gmail.com> To: =?utf-8?Q?Marek_Beh=C3=BAn?= X-Mailer: Apple Mail (2.3901.100.1.1.12) Hi Marek, > On 29. 9. 2026, at 16:45, Marek Beh=C3=BAn wrote: >=20 > My proposal is to register the first LAN LED as a true multicolor LED, > and the rest of LAN LEDs as simple LEDs, and then create sysfs > symlinks for the multi_intensity and multi_index attribute files: >=20 > rgb:lan-1 > multi_intensity (true attribute file) > multi_index (true attribute file) > rgb:lan-2 > multi_intensity (symlink to ../rgb:lan-1/multi_intensity) > multi_index (symlink to ../rgb:lan-1/multi_index) > ... >=20 > This way the sysfs will somehow reflect this topology. >=20 > Also, the max_brigthness will need to be set to 1 instead of 255, > since we can set each LAN LED on/off state individually, but color > globally. I tried to reach you privately about this. I am ready to do it, but before I do, I would like to clarify one thing. v4 will have rgb:lan-1 as the multicolor LED, the other four LAN LEDs as plain LEDs, and max_brightness 1 on all five. I am not sure about the symlinks, though. sysfs_create_link() can only link a whole kobject. A single attribute can be linked with compat_only_sysfs_link_entry_to_kobj(), but its callers in the tree (tpm, fadump, img-ascii-lcd) use it to keep old sysfs paths working. Would you and Lee be fine with it here, or do you prefer a link to the whole rgb:lan-1 directory, or only the ABI documentation saying that rgb:lan-1 sets the colour of all five? Josef=