From: Divyesh Shah <dpshah@google.com>
To: "Fernando Luis Vázquez Cao" <fernando@oss.ntt.co.jp>
Cc: Jens Axboe <jens.axboe@oracle.com>,
rusty@rustcorp.com.au, linux-kernel@vger.kernel.org
Subject: Re: request->ioprio
Date: Wed, 6 Aug 2008 10:22:30 -0700 [thread overview]
Message-ID: <D7ABD5F1-A0D8-4F80-AE0B-568A1E272CE0@google.com> (raw)
In-Reply-To: <1218015158.4419.58.camel@sebastian.kern.oss.ntt.co.jp>
On Aug 6, 2008, at 2:32 AM, Fernando Luis Vázquez Cao wrote:
> (CCing LKML)
>
> Hi Jens, Rusty,
>
> Trying to implement i/o tracking all the way up to the page cache (so
> that cfq and the future cgroup-based I/O controllers can schedule
> buffered I/O properly) I noticed that struct request's ioprio is
> initialized but never used for I/O scheduling purposes. Indeed there
> seems to be one single user of this member: virtio_blk. Virtio uses
> struct request's ioprio in the request() function of the virtio block
> driver, which just copies the ioprio value to the output header of
> virtblk_req.
>
> Is this the intended use of struct request's ioprio? Is it OK for
> device
> drivers to use it? If the answer two the previous to questions is no I
> would like to send some clean-up patches.
Naveen Gupta sent a priority-based anticipatory IO scheduler patchset
earlier which uses request->ioprio and the struct request seems to be
the logical place to keep the ioprio. So, please don't cleanup the
ioprio from there.
Thanks,
Divyesh
>
> - Fernando
>
next prev parent reply other threads:[~2008-08-06 17:24 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-06 9:32 request->ioprio Fernando Luis Vázquez Cao
2008-08-06 17:22 ` Divyesh Shah [this message]
[not found] <1218014196.4419.44.camel@sebastian.kern.oss.ntt.co.jp>
2008-08-06 20:33 ` request->ioprio Rusty Russell
2008-08-13 7:06 ` request->ioprio Fernando Luis Vázquez Cao
2008-08-14 2:16 ` request->ioprio Rusty Russell
2008-08-14 4:26 ` request->ioprio Fernando Luis Vázquez Cao
2008-08-15 5:51 ` request->ioprio Fernando Luis Vázquez Cao
2008-08-16 7:13 ` request->ioprio Rusty Russell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=D7ABD5F1-A0D8-4F80-AE0B-568A1E272CE0@google.com \
--to=dpshah@google.com \
--cc=fernando@oss.ntt.co.jp \
--cc=jens.axboe@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rusty@rustcorp.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®