From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755962AbbEBVi5 (ORCPT ); Sat, 2 May 2015 17:38:57 -0400 Received: from mga09.intel.com ([134.134.136.24]:49512 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753952AbbEBVi4 convert rfc822-to-8bit (ORCPT ); Sat, 2 May 2015 17:38:56 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.13,356,1427785200"; d="scan'208";a="722618775" From: "Drokin, Oleg" To: Julia Lawall CC: "" , "Dilger, Andreas" , Greg Kroah-Hartman , "" , "" , "" Subject: Re: [PATCH] staging: lustre: obd_support: Add obd_cpt_alloc function Thread-Topic: [PATCH] staging: lustre: obd_support: Add obd_cpt_alloc function Thread-Index: AQHQhR6Csy2fZNSzs0Omjdfvycz9WZ1pq98A Date: Sat, 2 May 2015 21:38:53 +0000 Message-ID: References: <1430601408-12847-1-git-send-email-Julia.Lawall@lip6.fr> In-Reply-To: <1430601408-12847-1-git-send-email-Julia.Lawall@lip6.fr> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.252.196.182] Content-Type: text/plain; charset="us-ascii" Content-ID: <932D9E761ABD984C8EFAC584380A291F@intel.com> Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On May 2, 2015, at 5:16 PM, Julia Lawall wrote: > Summarize OBD_CPT_ALLOC_GFP, OBD_CPT_ALLOC, and OBD_CPT_ALLOC_PTR as a > function, obd_cpt_alloc. > > Signed-off-by: Julia Lawall > > --- > > Some questions: Is the name OK? Is the NULL test needed? If not, should > the call to kzalloc_node with the call to cfs_cpt_spread_node just be > inlined into the call sites? I think we don't need this function at all, we can use kzalloc/kzalloc_node directly with cfs_cpt_spread_node call in. What we do need is obd_cpt_alloc_large similar to how we need obd_alloc_large (I know I still owe you a proper patch with that). The only differences between the two would then be passing down of the cpt (and it's use) or not. Bye, Oleg