From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f53.google.com (mail-ed1-f53.google.com [209.85.208.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D4BD91B0405 for ; Wed, 29 Jan 2025 12:18:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738153115; cv=none; b=c3Z11KdK/r0DfMSIIUfpWGl5cg3nj/iKbvD+GVkJHGtTqZh3gV6g4h4mUL7K/WOqIUjidc4lB+Mbsw42hlIrCNIhvL8A6Kq5pExLYH6uPSRdSz51aLLifgh3YYL4z4mGk+4HnKbqUBGTIoy6iSSh1MBIDF+/7ZWIlUsbOfCES8o= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738153115; c=relaxed/simple; bh=jcNFTng4JpTktWw7YXtZvIo27Dg28rJvqH6VwF4e/HU=; h=Mime-Version:Content-Type:Date:Message-Id:Cc:Subject:From:To: References:In-Reply-To; b=B/GBOSJXoV5TjJgBOcN72tsMOjQqbaT4JDnksX3tfjr+oadlTlbcFuRPr0URT/Q5qaZgNp9fH6ZKcb0ncmH6gCeKxJ1SKU9ityiZzW+HZp7Fpmj5nb7w5M4hIFWWqWkxwe5bK3psQ3czBYGGbMTq041UxYyCSyAfD46rfbfLB4k= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=fairphone.com; spf=pass smtp.mailfrom=fairphone.com; dkim=pass (2048-bit key) header.d=fairphone.com header.i=@fairphone.com header.b=I7p+zRP6; arc=none smtp.client-ip=209.85.208.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=fairphone.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=fairphone.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=fairphone.com header.i=@fairphone.com header.b="I7p+zRP6" Received: by mail-ed1-f53.google.com with SMTP id 4fb4d7f45d1cf-5da12292b67so11006485a12.3 for ; Wed, 29 Jan 2025 04:18:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fairphone.com; s=fair; t=1738153112; x=1738757912; darn=vger.kernel.org; h=in-reply-to:references:to:from:subject:cc:message-id:date :content-transfer-encoding:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=a99qlDNqWURU1I23MuHjH0bNbiC9ObSxp1hJlpltb4I=; b=I7p+zRP6TbfJOsKHGmVbFoBI9P7j2pFcpMPJNqYtUeYAloGZiFDEhvGCeR/BgU6pkR sLYgpmh+6EbWEmRqlOz3QJNlrT0vp1kI2C97+V2VmtT/MDHe5GICnBvRwbi9bo+E3HFJ k+zfMGH8Py6GXZkenyz5taq25fXQgqerh//OuPh0X+QoJx7iYjpYEBKj0QpIMihCoqeu pjZtEWoVSx2UWjFlBgqjcpnhNc0EF1FDxoMH2olUDtodDKcJiEuBAq3p42g5UUpIeyVa O+5wwbHWzrrG6G0Frnjf1IQcK2+ot9UXf2uXfpoqHlNL6waXnnl8E3cKorDUIX0KGl61 u/bA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738153112; x=1738757912; h=in-reply-to:references:to:from:subject:cc:message-id:date :content-transfer-encoding:mime-version:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=a99qlDNqWURU1I23MuHjH0bNbiC9ObSxp1hJlpltb4I=; b=UwzB22tgW3IfmjqoNHbV3XwyGTxHJD6QugvSNPfmvWrDRpa2npLj6+UZ5yN/aAWlEE fMntVxQ54d/uMkiXJcFqasU+5W5y9RC4oi3i0dI7prARMPXoXUPTvAqf3S+GHKFqyxQ1 WQLrxLxl1dfSOHXILA/YnnrtaEL+iKVUaFZTjOmdW8ywHSaqOJtfG7f//31dc+uxBxac 2IdZFoD2YBZ9+lAnXqiSYryr0WH8h8YmfkrijYdxiN8jDzJzaY4lLQRoi0iUvPZWdlVm /knXAK9wmTZZ50cDId/7hP6MRn4A+ug5Zd1+pKRM/YEKrUZ9ymU1bx13flwRc7+0g6+F YVUg== X-Forwarded-Encrypted: i=1; AJvYcCVjMU2lL6gysng96nM8HA3OdO6nPRqaiV4PPAJhzszSf+b8oXzgapa3E+ltiQ/NEExcZKvQheHZHu9FWuc=@vger.kernel.org X-Gm-Message-State: AOJu0YyZCB8OoQ3mACaO7SuHZ4yIPkx04TbkGJCnakPdvFsk9z2M7Iex ipujeTMgUikhl/pAgQ02qQh8xjutt/7xjo0QkJeRPoCHDYDh9rrjrlxUsM9PkyY= X-Gm-Gg: ASbGncvRiNJnerHIHIRRabMhcK6hVVt1bD1TPueU346a1fRHdHNcx7vZKyMQ8ypjZ3o +5aCIj8V3LSxMs4+HhOPRUfe6jShVcE3L1i9eZiROf9oxbXZPlnMqfWGFt7Ou+M4/ATi9zRC+aK fWgcxMNFw4nhCrs9SPugWyOfNwEnXIJr+lK2LdQ67dR/Y998fV7evbsvKClp0VlSRn2rB0apizg zyY/sHV8qpqWgtNZo9YflYk50GUeb5wPKGiPSnCIEYPN5IdoeInzw4jXMV38n2OTUrMB0sa0e67 5LJ/exvwfhNnkib9uhE4uIoleRoj74e7YXVB/KMSl6blsBYNTFmELo8O2GQH X-Google-Smtp-Source: AGHT+IE9RV8AZf9n5LiaC3XoEM/GOC9XhjHjo71lzPz78MtaJuaZQ+Wp2nT+KhqzBf5BZq1p/ceY0Q== X-Received: by 2002:a05:6402:1ed5:b0:5d0:ed92:cdf6 with SMTP id 4fb4d7f45d1cf-5dc5efc5e30mr6844761a12.19.1738153111906; Wed, 29 Jan 2025 04:18:31 -0800 (PST) Received: from localhost (144-178-202-138.static.ef-service.nl. [144.178.202.138]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ab6760ab363sm965675166b.114.2025.01.29.04.18.31 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 29 Jan 2025 04:18:31 -0800 (PST) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Wed, 29 Jan 2025 13:18:30 +0100 Message-Id: Cc: , , Subject: Re: [PATCH] arm64: dts: qcom: add all 7 coresight ETE nodes From: "Luca Weiss" To: "Neil Armstrong" , "Bjorn Andersson" , "Konrad Dybcio" , "Rob Herring" , "Krzysztof Kozlowski" , "Conor Dooley" , "Yuanfang Zhang" X-Mailer: aerc 0.19.0-0-gadd9e15e475d References: <20250129-topic-sm8650-upstream-add-all-coresight-cpus-v1-1-96996d37df8e@linaro.org> In-Reply-To: <20250129-topic-sm8650-upstream-add-all-coresight-cpus-v1-1-96996d37df8e@linaro.org> Hi Neil, On Wed Jan 29, 2025 at 10:54 AM CET, Neil Armstrong wrote: > Only CPU0 Embedded Trace Extension (ETE) was added, but there's one > for all 7 CPUs, so add the missing ones. > > Fixes: 256e6937e48a ("arm64: dts: qcom: sm8650: Add coresight nodes") > Signed-off-by: Neil Armstrong The subject line is missing "sm8650" Regards Luca > --- > arch/arm64/boot/dts/qcom/sm8650.dtsi | 163 +++++++++++++++++++++++++++++= +++++- > 1 file changed, 161 insertions(+), 2 deletions(-) > > diff --git a/arch/arm64/boot/dts/qcom/sm8650.dtsi b/arch/arm64/boot/dts/q= com/sm8650.dtsi > index 86684cb9a9325618ddb74458621cf4bbdc1cc0d1..d925d5e2c8182d522dd5b8e1f= a0e253f5de2f7a7 100644 > --- a/arch/arm64/boot/dts/qcom/sm8650.dtsi > +++ b/arch/arm64/boot/dts/qcom/sm8650.dtsi > @@ -365,7 +365,7 @@ cluster_sleep_1: cluster-sleep-1 { > }; > }; > =20 > - ete0 { > + ete-0 { > compatible =3D "arm,embedded-trace-extension"; > =20 > cpu =3D <&cpu0>; > @@ -379,15 +379,174 @@ ete0_out_funnel_ete: endpoint { > }; > }; > =20 > + ete-1 { > + compatible =3D "arm,embedded-trace-extension"; > + > + cpu =3D <&cpu1>; > + > + out-ports { > + port { > + ete1_out_funnel_ete: endpoint { > + remote-endpoint =3D <&funnel_ete_in_ete1>; > + }; > + }; > + }; > + }; > + > + ete-2 { > + compatible =3D "arm,embedded-trace-extension"; > + > + cpu =3D <&cpu2>; > + > + out-ports { > + port { > + ete2_out_funnel_ete: endpoint { > + remote-endpoint =3D <&funnel_ete_in_ete2>; > + }; > + }; > + }; > + }; > + > + ete-3 { > + compatible =3D "arm,embedded-trace-extension"; > + > + cpu =3D <&cpu3>; > + > + out-ports { > + port { > + ete3_out_funnel_ete: endpoint { > + remote-endpoint =3D <&funnel_ete_in_ete3>; > + }; > + }; > + }; > + }; > + > + ete-4 { > + compatible =3D "arm,embedded-trace-extension"; > + > + cpu =3D <&cpu4>; > + > + out-ports { > + port { > + ete4_out_funnel_ete: endpoint { > + remote-endpoint =3D <&funnel_ete_in_ete4>; > + }; > + }; > + }; > + }; > + > + ete-5 { > + compatible =3D "arm,embedded-trace-extension"; > + > + cpu =3D <&cpu5>; > + > + out-ports { > + port { > + ete5_out_funnel_ete: endpoint { > + remote-endpoint =3D <&funnel_ete_in_ete5>; > + }; > + }; > + }; > + }; > + > + ete-6 { > + compatible =3D "arm,embedded-trace-extension"; > + > + cpu =3D <&cpu6>; > + > + out-ports { > + port { > + ete6_out_funnel_ete: endpoint { > + remote-endpoint =3D <&funnel_ete_in_ete6>; > + }; > + }; > + }; > + }; > + > + ete-7 { > + compatible =3D "arm,embedded-trace-extension"; > + > + cpu =3D <&cpu7>; > + > + out-ports { > + port { > + ete7_out_funnel_ete: endpoint { > + remote-endpoint =3D <&funnel_ete_in_ete7>; > + }; > + }; > + }; > + }; > + > funnel-ete { > compatible =3D "arm,coresight-static-funnel"; > =20 > in-ports { > - port { > + #address-cells =3D <1>; > + #size-cells =3D <0>; > + > + port@0 { > + reg =3D <0>; > + > funnel_ete_in_ete0: endpoint { > remote-endpoint =3D <&ete0_out_funnel_ete>; > }; > }; > + > + port@1 { > + reg =3D <1>; > + > + funnel_ete_in_ete1: endpoint { > + remote-endpoint =3D <&ete1_out_funnel_ete>; > + }; > + }; > + > + port@2 { > + reg =3D <2>; > + > + funnel_ete_in_ete2: endpoint { > + remote-endpoint =3D <&ete2_out_funnel_ete>; > + }; > + }; > + > + port@3 { > + reg =3D <3>; > + > + funnel_ete_in_ete3: endpoint { > + remote-endpoint =3D <&ete3_out_funnel_ete>; > + }; > + }; > + > + port@4 { > + reg =3D <4>; > + > + funnel_ete_in_ete4: endpoint { > + remote-endpoint =3D <&ete4_out_funnel_ete>; > + }; > + }; > + > + port@5 { > + reg =3D <5>; > + > + funnel_ete_in_ete5: endpoint { > + remote-endpoint =3D <&ete5_out_funnel_ete>; > + }; > + }; > + > + port@6 { > + reg =3D <6>; > + > + funnel_ete_in_ete6: endpoint { > + remote-endpoint =3D <&ete6_out_funnel_ete>; > + }; > + }; > + > + port@7 { > + reg =3D <7>; > + > + funnel_ete_in_ete7: endpoint { > + remote-endpoint =3D <&ete7_out_funnel_ete>; > + }; > + }; > }; > =20 > out-ports { > > --- > base-commit: da7e6047a6264af16d2cb82bed9b6caa33eaf56a > change-id: 20250129-topic-sm8650-upstream-add-all-coresight-cpus-a3418606= b354 > > Best regards,