Re: [patch 2.6.29-rc] regulator: minor cleanup of virtual consumer

[Mark Brown <broonie@opensource.wolfsonmicro.com>]

On 14 Jan 2009, at 21:16, David Brownell <david-b@pacbell.net> wrote:

> From: David Brownell <dbrownell@users.sourceforge.net>
>
> Minor cleanup to the regulator set_mode sysfs support:
> switch to sysfs_streq() in set_mode(), which is also
> a code shrink.  Use the same strings that get_mode()
> uses, shrinking data too.
>
> Signed-off-by: David Brownell <dbrownell@users.sourceforge.net>

Excellent, thanks!

Acked-by: Mark Brown <broonie@opensource.wolfsonmicro.com>

>
> ---
> drivers/regulator/virtual.c |    8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> --- a/drivers/regulator/virtual.c
> +++ b/drivers/regulator/virtual.c
> @@ -226,13 +226,13 @@ static ssize_t set_mode(struct device *d
>    unsigned int mode;
>    int ret;
>
> -    if (strncmp(buf, "fast", strlen("fast")) == 0)
> +    if (sysfs_streq(buf, "fast\n") == 0)
>        mode = REGULATOR_MODE_FAST;
> -    else if (strncmp(buf, "normal", strlen("normal")) == 0)
> +    else if (sysfs_streq(buf, "normal\n") == 0)
>        mode = REGULATOR_MODE_NORMAL;
> -    else if (strncmp(buf, "idle", strlen("idle")) == 0)
> +    else if (sysfs_streq(buf, "idle\n") == 0)
>        mode = REGULATOR_MODE_IDLE;
> -    else if (strncmp(buf, "standby", strlen("standby")) == 0)
> +    else if (sysfs_streq(buf, "standby\n") == 0)
>        mode = REGULATOR_MODE_STANDBY;
>    else {
>        dev_err(dev, "Configuring invalid mode\n");