From: Luke Howard <lukeh@padl.com>
To: cedric.jehasse@luminex.be
Cc: Andrew Lunn <andrew@lunn.ch>, Vladimir Oltean <olteanv@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Simon Horman <horms@kernel.org>,
Russell King <linux@armlinux.org.uk>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Cedric Jehasse <cedric.jehasse@gmail.com>
Subject: Re: [PATCH net-next 0/2] net: dsa: mv88e6xxx: add support for dcb pcp app
Date: Fri, 5 Jun 2026 11:14:44 +1000 [thread overview]
Message-ID: <D81590F2-DB4A-41CF-9884-1B6AFC752CED@padl.com> (raw)
In-Reply-To: <20260604-net-next-mv88e6xxx-pcp-prio-v1-0-f9d10fe6cdc8@luminex.be>
> On 4 Jun 2026, at 6:30 pm, Cedric Jehasse via B4 Relay <devnull+cedric.jehasse.luminex.be@kernel.org> wrote:
>
> This patch series adds support for dcb pcp app to the mv88e6xxx
> driver. The pcp app is there to configure pcp based queue
> classification.
Somehow these patches didn’t arrive in my inbox, but (looking on lore) they all LGTM.
The only comments I had:
- whether you might use IEEE_8021Q_MAX_PRIORITIES instead of 8 (this requires importing dcbnl.h though)
- the user might infer the ‘prio’ parameter name means we are remapping frame priorities rather than assigning to a queue. Perhaps it could have a different name?
Luke
next prev parent reply other threads:[~2026-06-05 1:14 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-04 8:30 Cedric Jehasse via B4 Relay
2026-06-04 8:30 ` [PATCH net-next 1/2] net: dsa: " Cedric Jehasse via B4 Relay
2026-06-04 8:30 ` [PATCH net-next 2/2] net: dsa: mv88e6xxx: " Cedric Jehasse via B4 Relay
2026-06-04 10:37 ` [PATCH net-next 0/2] " Luke Howard
2026-06-04 12:01 ` Cedric Jehasse
2026-06-04 22:51 ` Luke Howard
2026-06-04 23:21 ` Andrew Lunn
2026-06-05 1:13 ` Luke Howard
2026-06-05 12:05 ` Luke Howard
2026-06-05 1:14 ` Luke Howard [this message]
2026-06-07 3:12 ` Luke Howard
2026-06-08 21:22 ` Luke Howard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=D81590F2-DB4A-41CF-9884-1B6AFC752CED@padl.com \
--to=lukeh@padl.com \
--cc=andrew@lunn.ch \
--cc=cedric.jehasse@gmail.com \
--cc=cedric.jehasse@luminex.be \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox