From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751242AbdAMVQ1 (ORCPT <rfc822;w@1wt.eu>);
        Fri, 13 Jan 2017 16:16:27 -0500
Received: from mail-pf0-f196.google.com ([209.85.192.196]:32787 "EHLO
        mail-pf0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751086AbdAMVPe (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 13 Jan 2017 16:15:34 -0500
Date: Fri, 13 Jan 2017 13:15:13 -0800
User-Agent: K-9 Mail for Android
In-Reply-To: <3051252.9A92ba0o10@wuerfel>
References: <20170110121718.2992211-1-arnd@arndb.de> <20170113062203.GD22630@dtor-ws> <3051252.9A92ba0o10@wuerfel>
MIME-Version: 1.0
Content-Type: text/plain;
 charset=utf-8
Subject: Re: [PATCH] Input: synaptics-rmi4 - make F03 a tristate symbol
To: Arnd Bergmann <arnd@arndb.de>
CC: Andrew Duggan <aduggan@synaptics.com>,
        Christopher Heiny <cheiny@synaptics.com>,
        Nick Dyer <nick@shmanahar.org>, linux-input@vger.kernel.org,
        linux-kernel@vger.kernel.org
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Message-ID: <D8CE35BE-2576-4F01-955A-BA118114BF2F@gmail.com>
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Transfer-Encoding: 8bit
X-MIME-Autoconverted: from quoted-printable to 8bit by mail.home.local id v0DLIEqr026026

On January 13, 2017 1:06:12 PM PST, Arnd Bergmann <arnd@arndb.de> wrote:
>On Thursday, January 12, 2017 10:22:03 PM CET Dmitry Torokhov wrote:
>> As it was explained townthread we can't [currently] make functions
>> modules, in the meantime I have
>d7ddad0acc4add42567f7879b116a0b9eea31860
>> that should fix this issue (and I just sent pull request for it).
>
>On today's linux-next (which includes d7ddad0acc4ad), I was still
>getting this warning :
>
>warning: (HID_RMI) selects RMI4_F03 which has unmet direct dependencies
>(!UML && INPUT && RMI4_CORE && (SERIO=y || RMI4_CORE=SERIO))

Ah, yes, that's new hid RMI code..


>
>This is my fixup, though I'm not too happy with that version.
>    
>Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>
>diff --git a/drivers/hid/Kconfig b/drivers/hid/Kconfig
>index 1aeb80e52424..3927259a5d5d 100644
>--- a/drivers/hid/Kconfig
>+++ b/drivers/hid/Kconfig
>@@ -785,7 +785,8 @@ config HID_SUNPLUS
> config HID_RMI
> 	tristate "Synaptics RMI4 device support"
> 	depends on HID
>-	select RMI4_CORE
>+	depends on SERIO && RMI4_CORE
>+	depends on SERIO=y || RMI4_CORE=SERIO

Shouldn't this be simply

select SERIO # needed for F03

?

> 	select RMI4_F03
> 	select RMI4_F11
> 	select RMI4_F12


Thanks.

-- 
Dmitry