From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-171.mta0.migadu.com (out-171.mta0.migadu.com [91.218.175.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 640013AE1A8 for ; Fri, 22 May 2026 09:05:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.218.175.171 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779440748; cv=none; b=hu827G40R5ZOed4AWjLVYFptqX4YM1wYzfnIqPr77VW7vJKK/qAttTz82M/6P1rx8/2gPQomghtzUJ6Pt9erWDkkeFpP6tnj6czXiYhx8yPcw6VwN1FkyFuvxd05VlL5vGybwaaCwY+jMFFEi/5L7VbV0sFJA3aUOWSPQ1s9aiI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779440748; c=relaxed/simple; bh=1NVGJAwjRYdYLDsgDMYCGdkDCjTx9lBBzpo10EYl6JA=; h=Content-Type:Mime-Version:Subject:From:In-Reply-To:Date:Cc: Message-Id:References:To; b=tnXc2eTo+lj0krgBG6cmtxvxBdL91JHkcJHtuDK/+x94iIXOMp3FaEeKk8Nmvo/HKCCEICSqXvcWzBj1V9KwzHzPistZuhMNWTRaPzqh5w9aB06SYYPpy3aMOOGuXNc4u8xbCJpp2fmnX1BPWAC0vwRA6k/VJ1hvok6J/r9B6hg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=B49aNU7k; arc=none smtp.client-ip=91.218.175.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="B49aNU7k" Content-Type: text/plain; charset=us-ascii DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1779440744; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=1NVGJAwjRYdYLDsgDMYCGdkDCjTx9lBBzpo10EYl6JA=; b=B49aNU7k6CX1dZenwrn+rErfz6tvzbRfrKIkl8CoNbbMplacayg0mtXqthPft0rU8/bFpZ PZ3rd7X3CeHi5njAUJSgw90RlK8XzisAA7J9jS/U3TYejrLiUFpEQVX0Oz2l9XLPIihRrd S95uIFSihKgrGC5Zwx0FLO/KNTCWnJk= Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3864.600.51.1.1\)) Subject: Re: [PATCH v2 13/69] mm/hugetlb: Refactor early boot gigantic hugepage allocation X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Muchun Song In-Reply-To: <177944019668.3663073.6529634450029926963.b4-review@b4> Date: Fri, 22 May 2026 17:05:05 +0800 Cc: Muchun Song , Andrew Morton , David Hildenbrand , Oscar Salvador , Michael Ellerman , Madhavan Srinivasan , Lorenzo Stoakes , "Liam R . Howlett" , Vlastimil Babka , Suren Baghdasaryan , Michal Hocko , Nicholas Piggin , Christophe Leroy , Ackerley Tng , Frank van der Linden , aneesh.kumar@linux.ibm.com, joao.m.martins@oracle.com, linux-mm@kvack.org, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Message-Id: References: <20260513130542.35604-1-songmuchun@bytedance.com> <20260513130542.35604-14-songmuchun@bytedance.com> <177944019668.3663073.6529634450029926963.b4-review@b4> To: Mike Rapoport X-Migadu-Flow: FLOW_OUT > On May 22, 2026, at 16:56, Mike Rapoport wrote: >=20 > On Wed, 13 May 2026 21:04:41 +0800, Muchun Song = wrote: >> diff --git a/arch/powerpc/mm/hugetlbpage.c = b/arch/powerpc/mm/hugetlbpage.c >> index 558fafb82b8a..ff8c5ec831bb 100644 >> --- a/arch/powerpc/mm/hugetlbpage.c >> +++ b/arch/powerpc/mm/hugetlbpage.c >> @@ -104,17 +104,14 @@ void __init pseries_add_gpage(u64 addr, u64 = page_size, unsigned long number_of_p >> } >> } >>=20 >> -static int __init pseries_alloc_bootmem_huge_page(struct hstate = *hstate) >> +static __init void *pseries_alloc_bootmem_huge_page(struct hstate = *hstate) >> { >> struct huge_bootmem_page *m; >=20 > This can be void *m and powerpc code does not need to know about = struct > huge_bootmem_page at all and its declaration can be moved out of > include/linux Make sense. >=20 > Other than that >=20 > Reviewed-by: Mike Rapoport (Microsoft) Thanks. Muchun. >=20 > --=20 > Sincerely yours, > Mike. >=20