mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Nicolas Schier" <n.schier@avm.de>
To: "Xin Li (Intel)" <xin@zytor.com>, <linux-kernel@vger.kernel.org>,
	<linux-kbuild@vger.kernel.org>
Cc: <masahiroy@kernel.org>, <nathan@kernel.org>, <nicolas@fjasle.eu>,
	<bp@alien8.de>, <hpa@zytor.com>, <sraithal@amd.com>
Subject: Re: [PATCH v2 1/1] kbuild: Add a help message for "headers"
Date: Tue, 11 Mar 2025 16:10:14 +0100	[thread overview]
Message-ID: <D8DJ6L3FYOBS.2LX1B9RRJVXA4@avm.de> (raw)
In-Reply-To: <20250311054932.1931853-1-xin@zytor.com>

On Tue Mar 11, 2025 at 06:49 CET, Xin Li (Intel) wrote:
> Meanwhile explicitly state that the headers are uapi headers.
>
> Suggested-by: Borislav Petkov <bp@alien8.de>
> Signed-off-by: Xin Li (Intel) <xin@zytor.com>
> ---
>
> Changes in v2:
> * Revise the help message for "headers" (Masahiro Yamada).
> * Revise the shortlog (Masahiro Yamada).
> ---
>  Makefile | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/Makefile b/Makefile
> index 70bdbf2218fc..62afeda58080 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -1659,7 +1659,8 @@ help:
>  	@echo  '  kernelrelease	  - Output the release version string (use with make -s)'
>  	@echo  '  kernelversion	  - Output the version stored in Makefile (use with make -s)'
>  	@echo  '  image_name	  - Output the image name (use with make -s)'
> -	@echo  '  headers_install - Install sanitised kernel headers to INSTALL_HDR_PATH'; \
> +	@echo  '  headers	  - Build read-to-install uapi headers in usr/include'

ready-to-install (a 'y' is missing)

> +	@echo  '  headers_install - Install sanitised kernel uapi headers to INSTALL_HDR_PATH'; \

In documentation and comments, UAPI is written in capital letters.  I 
think it would be good to keep it this way here, too.

Kind regards,
Nicolas

      reply	other threads:[~2025-03-11 15:10 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-11  5:49 Xin Li (Intel)
2025-03-11 15:10 ` Nicolas Schier [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=D8DJ6L3FYOBS.2LX1B9RRJVXA4@avm.de \
    --to=n.schier@avm.de \
    --cc=bp@alien8.de \
    --cc=hpa@zytor.com \
    --cc=linux-kbuild@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=masahiroy@kernel.org \
    --cc=nathan@kernel.org \
    --cc=nicolas@fjasle.eu \
    --cc=sraithal@amd.com \
    --cc=xin@zytor.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®