From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f170.google.com (mail-pl1-f170.google.com [209.85.214.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 904C427E07E for ; Thu, 30 Apr 2026 19:30:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.170 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777577441; cv=none; b=MhgP3WvIgZIeG5dd2kuaJokZhoA4rFueSKk7ekeP0+VEo+yzw2qvgTcTTqZt8pr8U3GkPw/AC80y7lMlUH0ZSvmyA3WN4ZbMoSmLtR77TMxYdVbzKNVvIWju+GSGmaHPQ5+Z6vmXys6j0XzoESlmtoMnisMx0f7ObHmqIU/ZkHE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777577441; c=relaxed/simple; bh=KJesWsbuDzQpkNp8k17t23YomF1fs6T42RqnGIbmT+M=; h=Date:From:To:CC:Subject:In-Reply-To:References:Message-ID: MIME-Version:Content-Type; b=ODqpCaN3g/KzChavr0496fkgczqJ8asNhELhfqbfDMdPbabUHXufpu6pblbWn9JG1BpmRtFmtsDDpkCCtoYwQpeCJRQWMZDZaB7vMzA+VMm3tQ7yQSRJ4EdkICqHkK66F0TICCsCep68YT078lejrcmptsTPcpRBMCDUlidiBwk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=TPaXadkG; arc=none smtp.client-ip=209.85.214.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="TPaXadkG" Received: by mail-pl1-f170.google.com with SMTP id d9443c01a7336-2ad21f437eeso8996415ad.0 for ; Thu, 30 Apr 2026 12:30:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1777577440; x=1778182240; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:references :in-reply-to:user-agent:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to; bh=GxuNSv+nlSzXKcfeo3FfuQD7X7e1NhixT6Zs+fqDCx0=; b=TPaXadkG4VIm+eIYczRiHpYs0UFySR5EuQIEyAZnJwKRkyGoCk0KIqfTinKFSzb1r1 TiNqfWMQxXNtEMEbrxs5EDjEN5nXBrgs1cb3vn/qLM4xYRfyXPU5TMXc6A8QfvHLY2Rz UgL7un2dYk7a2h0DvR0D2Kr//6WyZay8IyFwLiLX/P1UTB7tpwgFMCc/O+MR6VZzOe7v GBuEO54QJFNQV62aHFWox1cDtlKt0IKdaS9gWEWaHjBAZmro03A5x6NYhqGCmrhqB9wI bu51xhkpbyNRzwGOgPpjX8jdqR6L+KF23Arp7DfLfHGdMOM/ta39E0Y8zq4Pnryvkdcf li/A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777577440; x=1778182240; h=content-transfer-encoding:mime-version:message-id:references :in-reply-to:user-agent:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=GxuNSv+nlSzXKcfeo3FfuQD7X7e1NhixT6Zs+fqDCx0=; b=nwSUMl52x3CCByjGKoUCg1cam2UV2sGDxedJb6zQRLjhqMy3ZbXvifAGdar+ZS+UPL H9zYkHKbqiqnKekxRBhvcQ6VXNiz40hHW4+CeaW6j19aXZHpI++enmVF6yg8bSmsADWZ PTQiT3P3YXnk7Xm/54oZmNHzYOHZeV8e0rDeDc9qroQATeg/6offt3TvZNHU6CrqM1+F k0T2qv9KQVxxjMXn6Yqc/2Q1KGf8q6dTGhzarrNKzdUvqAYwDhL250tYDE5SCUSly9mC j59kBukhvzHQX5yuogSNgMFjP7cuYhXsr3bBnZdPUG3r3V7PrAooXlJ0bYjgPCs9MAnS 9ucg== X-Forwarded-Encrypted: i=1; AFNElJ/4fQXpwcA/uLYbstr3lp+lQkkz4aXgEAXmhW7pJPdN6aruwWyoWemV3bwKkT1AWKICqGZ7eMB3VdNKVm8=@vger.kernel.org X-Gm-Message-State: AOJu0YyasTP4BF1+ig0HLgxtueCrlTgEEx2KBRkjY3SVSX84Z1OMwlih bFoMFSjsc3jljCptPMgCvn2erDykLF08z5EhuHTMnl0WjLw6DvqXMy0G X-Gm-Gg: AeBDiesi2Xn1hhhE5J7GC/GDAVhcA3RTSrRfWeNVQ1QvOw9ElPohZ4jRs5bNu0Tdm/2 w/0+5/fRIryhaDq4Ej4Mv3qY4Xzujs9H5HN+fniBQ+aeI3YgQtTpVnjLssmhj8u9yUhRbTA7pUH mDN3jGyrrnwVVOQ711CNFzXY9OmwPnSdu9H5MVH6z3+9SGjnVdAssjaaiG/nzmGAj/JU3bm4Z7A 12SPyczOiUtf9w2+cBL04ySRzAEP1XKLdY5AV6d22ADds6udXGWiWafz1eJIHreC5lhPqT2aZA0 d26f/igShyx1KHX7PGvxXeS0vZ7RbZHjwxI1J+II8DOQ62mB67438FFylqD1vbAgrB98a49x8w4 fexYwOZyqyvMZXGTukoP0VMU//41P7eoOtZP67Jja45WhRPLFhNJPZrxsacWpoox9XZFTsYStuK 6JhxaPP/53HUPAp0fWfpNbW55zhYi0o5UjocT1Z18Ueklv X-Received: by 2002:a17:902:ef11:b0:2b2:5070:8b with SMTP id d9443c01a7336-2b9a428297cmr33927525ad.1.1777577439347; Thu, 30 Apr 2026 12:30:39 -0700 (PDT) Received: from ehlo.thunderbird.net ([2401:4900:53d0:4e4d::e3d:bc05]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2b9caaaec82sm3750855ad.24.2026.04.30.12.30.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 30 Apr 2026 12:30:38 -0700 (PDT) Date: Fri, 01 May 2026 01:00:31 +0530 From: Sanjay Chitroda To: Andy Shevchenko CC: jikos@kernel.org, jic23@kernel.org, srinivas.pandruvada@linux.intel.com, dlechner@baylibre.com, nuno.sa@analog.com, andy@kernel.org, sakari.ailus@linux.intel.com, linux-input@vger.kernel.org, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 2/4] iio: hid-sensors: introduce device managed API User-Agent: Thunderbird for Android In-Reply-To: References: <20260429175918.2541914-1-sanjayembedded@gmail.com> <20260429175918.2541914-3-sanjayembedded@gmail.com> Message-ID: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 30 April 2026 1:01:27=E2=80=AFam IST, Andy Shevchenko wrote: >On Wed, Apr 29, 2026 at 11:29:16PM +0530, Sanjay Chitroda wrote: > >> hid_sensor_setup_trigger() is common API used for the HID IIO drivers, >> prepare devm API devm_hid_sensor_setup_trigger() to acquire resource >> during setup and release using device managed framework during drivers >> fail, unbind or remove path=2E >>=20 >> Register action with devm_add_action_or_reset() to release resource wit= h >> devres framework=2E > >=2E=2E=2E > >> +static void hid_sensor_remove_trigger_action(void *ptr) >> +{ >> + struct hid_sensor_common *attrb =3D ptr; >> + >> + hid_sensor_remove_trigger(attrb); >> +} > >Casting is not needed here=2E > >static void hid_sensor_remove_trigger_action(void *attrb) >{ > hid_sensor_remove_trigger(attrb); >} > True, the cast isn=E2=80=99t required=2E I kept the typed variable for cla= rity and type checking on devm_add=2E=2E API which pass void * callback and= remove trigger API which has struct hid_sensor_common=2E Happy to simplify if preferred=2E >=2E=2E=2E > >> +int devm_hid_sensor_setup_trigger(struct device *dev, struct iio_dev *= indio_dev, >> + const char *name, struct hid_sensor_common *attrb) >> +{ >> + int ret; >> + >> + ret =3D hid_sensor_setup_trigger(indio_dev, name, attrb); >> + if (ret) >> + return ret; > >> + ret =3D devm_add_action_or_reset(dev, hid_sensor_remove_trigger_actio= n, attrb); >> + if (ret) >> + return ret; >> + >> + return 0; > > return devm_add_action_or_reset(dev, hid_sensor_remove_trigger_action, a= ttrb); > Agree, will update in next series=2E Thanks, Sanjay Chitroda >> +} >