From: Benno Lossin <benno.lossin@proton.me>
To: Andrew Ballance <andrewjballance@gmail.com>,
ojeda@kernel.org, boqun.feng@gmail.com, gary@garyguo.net,
bjorn3_gh@protonmail.com, a.hindborg@kernel.org,
aliceryhl@google.com, tmgross@umich.edu,
rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: alex.gaynor@gmail.com, jubalh@iodoru.org
Subject: Re: [PATCH] rust: print: add rustdoc link to std::format
Date: Sun, 23 Mar 2025 10:27:59 +0000 [thread overview]
Message-ID: <D8NKOYBU4B7C.2QEMXLVBOZK9U@proton.me> (raw)
In-Reply-To: <20250323055948.89865-1-andrewjballance@gmail.com>
On Sun Mar 23, 2025 at 6:59 AM CET, Andrew Ballance wrote:
> Adds a url link to the rust std's format! to the pr_* macro docs.
>
> Additionally replaces refrences to alloc::format[1] with std::format[2]
> because they are identical but less likely to cause confusion with the
> kernel's alloc crate.
>
> Link: https://doc.rust-lang.org/alloc/macro.format.html [1]
> Link: https://doc.rust-lang.org/std/macro.format.html [2]
> Signed-off-by: Andrew Ballance <andrewjballance@gmail.com>
> ---
> rust/kernel/print.rs | 27 ++++++++++++++++++---------
> 1 file changed, 18 insertions(+), 9 deletions(-)
There are also instances of `alloc::format!` in `rust/kernel/device.rs`.
Could you also add those? Thanks!
Reviewed-by: Benno Lossin <benno.lossin@proton.me>
---
Cheers,
Benno
prev parent reply other threads:[~2025-03-23 10:28 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-23 5:59 Andrew Ballance
2025-03-23 10:27 ` Benno Lossin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=D8NKOYBU4B7C.2QEMXLVBOZK9U@proton.me \
--to=benno.lossin@proton.me \
--cc=a.hindborg@kernel.org \
--cc=alex.gaynor@gmail.com \
--cc=aliceryhl@google.com \
--cc=andrewjballance@gmail.com \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun.feng@gmail.com \
--cc=gary@garyguo.net \
--cc=jubalh@iodoru.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ojeda@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=tmgross@umich.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®