From: Benno Lossin <benno.lossin@proton.me>
To: Igor Korotin <igor.korotin@yahoo.com>
Cc: linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org
Subject: Re: [PATCH v2 1/1] rust: macros: Fix macro referencing core and kernel crates v2
Date: Fri, 28 Mar 2025 21:50:21 +0000 [thread overview]
Message-ID: <D8S8C5W0FCVD.1LH1E86H6PXZD@proton.me> (raw)
In-Reply-To: <20250328180312.2025317-2-igor.korotin@yahoo.com>
On Fri Mar 28, 2025 at 7:03 PM CET, Igor Korotin wrote:
> Update macros to always use absolute paths for crates `core` and `kernel`.
> This guarantees that macros will not pick up user-defined crates `core`
> or `kernel` by accident.
The crates are not user-defineable. Your initial message was correct in
that the user can define *modules* that have precedence over the crates
`core` and `kernel`.
> Changes since v1:
> - Fixed paths in auto-generated code.
The changelog shouldn't be in the commit message. Instead place it below
the `---`, but before the change stats.
> Suggested-by: Benno Lossin <benno.lossin@proton.me>
> Closes: https://github.com/Rust-for-Linux/linux/issues/1150
> Signed-off-by: Igor Korotin <igor.korotin@yahoo.com>
> ---
(put the changelog here)
---
Cheers,
Benno
> rust/ffi.rs | 2 +-
> rust/kernel/device.rs | 2 +-
> rust/kernel/device_id.rs | 4 ++--
> rust/kernel/kunit.rs | 8 ++++----
> rust/kernel/static_assert.rs | 4 ++--
> rust/kernel/str.rs | 4 ++--
> rust/macros/kunit.rs | 22 +++++++++++-----------
> rust/macros/lib.rs | 6 +++---
> rust/macros/module.rs | 31 ++++++++++++++++---------------
> scripts/rustdoc_test_builder.rs | 6 +++---
> scripts/rustdoc_test_gen.rs | 16 ++++++++++------
> 11 files changed, 55 insertions(+), 50 deletions(-)
next prev parent reply other threads:[~2025-03-28 21:50 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-28 0:49 [PATCH] rust: macros: Fix macro referencing core and kernel crates Benno Lossin
2025-03-28 18:03 ` [PATCH v2 0/1] rust: macros: Fix macro referencing core and kernel crates v2 Igor Korotin
2025-03-28 18:03 ` [PATCH v2 1/1] " Igor Korotin
2025-03-28 21:50 ` Benno Lossin [this message]
2025-03-29 12:28 ` Miguel Ojeda
2025-03-28 21:48 ` [PATCH v2 0/1] " Benno Lossin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=D8S8C5W0FCVD.1LH1E86H6PXZD@proton.me \
--to=benno.lossin@proton.me \
--cc=igor.korotin@yahoo.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rust-for-linux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®