From: "Angelos Oikonomopoulos" <angelos@igalia.com>
To: "Anshuman Khandual" <anshuman.khandual@arm.com>,
<linux-arm-kernel@lists.infradead.org>
Cc: <catalin.marinas@arm.com>, <will@kernel.org>,
<linux-kernel@vger.kernel.org>, <kernel-dev@igalia.com>
Subject: Re: [PATCH] arm64: Don't call NULL in do_compat_alignment_fixup
Date: Tue, 01 Apr 2025 08:58:33 +0200 [thread overview]
Message-ID: <D8V3VKNJJI1Z.27C32MUQ1OLYF@igalia.com> (raw)
In-Reply-To: <17de4426-8263-4ccb-8420-f6913d478ae9@arm.com>
On Tue Apr 1, 2025 at 8:05 AM CEST, Anshuman Khandual wrote:
> On 3/31/25 14:24, Angelos Oikonomopoulos wrote:
>> do_alignment_t32_to_handler only fixes up alignment faults for specific
>> instructions; it returns NULL otherwise. When that's the case, signal to
>> the caller that it needs to proceed with the regular alignment fault
>> handling (i.e. SIGBUS).
>>
>> Signed-off-by: Angelos Oikonomopoulos <angelos@igalia.com>
>> ---
>> arch/arm64/kernel/compat_alignment.c | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> diff --git a/arch/arm64/kernel/compat_alignment.c b/arch/arm64/kernel/compat_alignment.c
>> index deff21bfa680..b68e1d328d4c 100644
>> --- a/arch/arm64/kernel/compat_alignment.c
>> +++ b/arch/arm64/kernel/compat_alignment.c
>> @@ -368,6 +368,8 @@ int do_compat_alignment_fixup(unsigned long addr, struct pt_regs *regs)
>> return 1;
>> }
>>
>> + if (!handler)
>> + return 1;
>
> do_alignment_t32_to_handler() could return NULL, returning 1 seems to be
> the right thing to do here and consistent. Otherwise does this cause a
> kernel crash during subsequent call into handler() ?
Yes. We call a NULL pointer so we Oops.
Angelos
next prev parent reply other threads:[~2025-04-01 6:58 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-31 8:54 Angelos Oikonomopoulos
2025-04-01 6:05 ` Anshuman Khandual
2025-04-01 6:58 ` Angelos Oikonomopoulos [this message]
2025-04-01 7:47 ` Anshuman Khandual
2025-04-01 8:09 ` Angelos Oikonomopoulos
2025-04-01 8:22 ` Anshuman Khandual
2025-04-01 8:58 ` Angelos Oikonomopoulos
2025-04-04 13:58 ` Will Deacon
-- strict thread matches above, loose matches on Subject: below --
2025-03-26 13:35 Angelos Oikonomopoulos
2025-03-28 19:06 ` Catalin Marinas
2025-03-31 7:57 ` Angelos Oikonomopoulos
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=D8V3VKNJJI1Z.27C32MUQ1OLYF@igalia.com \
--to=angelos@igalia.com \
--cc=anshuman.khandual@arm.com \
--cc=catalin.marinas@arm.com \
--cc=kernel-dev@igalia.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®