From: Kumar Gala <galak@kernel.crashing.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Mathieu Desnoyers <mathieu.desnoyers@polymtl.ca>,
linuxppc-dev@ozlabs.org, Paul Mackerras <paulus@samba.org>,
linux-kernel@vger.kernel.org
Subject: Re: Powerpc - Include pagemap.h in asm/powerpc/tlb.h
Date: Thu, 19 Jul 2007 14:55:23 -0500 [thread overview]
Message-ID: <D9805F9D-04B0-4422-81F1-958B15482A93@kernel.crashing.org> (raw)
In-Reply-To: <20070718223034.7388e59f.akpm@linux-foundation.org>
On Jul 19, 2007, at 12:30 AM, Andrew Morton wrote:
> On Fri, 13 Jul 2007 21:20:33 -0400 Mathieu Desnoyers
> <mathieu.desnoyers@polymtl.ca> wrote:
>
>> Powerpc - Include pagemap.h in asm/powerpc/tlb.h
>>
>> Fixes this powerpc build error in 2.6.22-rc6-mm1 for powerpc 64 :
>>
>> In file included from include2/asm/tlb.h:60,
>> from /home/compudj/git/linux-2.6-lttng/arch/
>> powerpc/mm/init_64.
>> c:56:
>> /home/compudj/git/linux-2.6-lttng/include/asm-generic/tlb.h: In
>> function 'tlb_fl
>> ush_mmu':
>> /home/compudj/git/linux-2.6-lttng/include/asm-generic/tlb.h:76:
>> error: implicit
>> declaration of function 'release_pages'
>> /home/compudj/git/linux-2.6-lttng/include/asm-generic/tlb.h: In
>> function 'tlb_re
>> move_page':
>> /home/compudj/git/linux-2.6-lttng/include/asm-generic/tlb.h:105:
>> error: implicit
>> declaration of function 'page_cache_release'
>
> You have some wordwrapping going on there.
>
>> make[2]: *** [arch/powerpc/mm/init_64.o] Error 1
>>
>> release_pages is declared in linux/pagemap.h, but cannot be
>> included in
>> linux/swap.h because of a sparc related comment:
>>
>> /* only sparc can not include linux/pagemap.h in this file
>> * so leave page_cache_release and release_pages undeclared... */
>> #define free_page_and_swap_cache(page) \
>> page_cache_release(page)
>> #define free_pages_and_swap_cache(pages, nr) \
>> release_pages((pages), (nr), 0);
>
> It's always a worry when this happens. What change made us need this
> inclusion? How come you're hitting it but I (and test.kernel.org,
> at least)
> did not? How come so few other architectures include pagemap.h from
> asm/tlb.h? Why do header files get into such a mess?
>
>
>> Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@polymtl.ca>
>> CC: linuxppc-dev@ozlabs.org
>> CC: Paul Mackerras <paulus@samba.org>
>> ---
>> include/asm-powerpc/tlb.h | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> Index: linux-2.6-lttng/include/asm-powerpc/tlb.h
>> ===================================================================
>> --- linux-2.6-lttng.orig/include/asm-powerpc/tlb.h 2007-07-13
>> 11:30:54.000000000 -0400
>> +++ linux-2.6-lttng/include/asm-powerpc/tlb.h 2007-07-13
>> 11:31:22.000000000 -0400
>> @@ -23,6 +23,8 @@
>> #include <asm/mmu.h>
>> #endif
>>
>> +#include <linux/pagemap.h>
>> +
>> struct mmu_gather;
>>
>
> Oh well. I queued it up for someone else to worry over ;)
Andrew,
Are you sending this to linus directly or should this go via paul and
me?
- k
next prev parent reply other threads:[~2007-07-19 19:55 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-14 1:20 Mathieu Desnoyers
2007-07-19 5:30 ` Andrew Morton
2007-07-19 19:55 ` Kumar Gala [this message]
2007-07-19 20:13 ` Andrew Morton
2007-07-19 21:04 ` Kumar Gala
2007-07-19 21:30 ` Andrew Morton
2007-07-19 22:32 ` Mathieu Desnoyers
2007-07-19 22:46 ` Kumar Gala
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=D9805F9D-04B0-4422-81F1-958B15482A93@kernel.crashing.org \
--to=galak@kernel.crashing.org \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=mathieu.desnoyers@polymtl.ca \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®