From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lj1-f175.google.com (mail-lj1-f175.google.com [209.85.208.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D37703AFD16 for ; Sat, 27 Jun 2026 14:21:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.175 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782570062; cv=none; b=YEjm8R0Ps+LXcGkEdmw4KiQ2RTVlS9weY7wZgXeNSOf+pFCLwaWGehxsRwBH1ibc3flbAQ+nRdYavlfOlY8YNTQaJyDy1xHfKI5tgesLYplA1F7ihBT2GBIdvvch+kGVpNL5l8y0gIwh27SvkMxei1EserLsxXg33F8x0Wuodm8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782570062; c=relaxed/simple; bh=UjaUcqumMacUQ9KI5r4tiOS1vn4x2pFxKB8z2st3wU0=; h=Content-Type:Mime-Version:Subject:From:In-Reply-To:Date:Cc: Message-Id:References:To; b=V02WFhhlJmGh4cV8fXFa1XuziTNSzRAoqopxQ75JC45euWVDE8BnSyQnH7//EtlQzRHpS9jQjkW0wJJ5M+CSsJUSGTVPU5q/JB9rTOzGhxQeR0+vGj+KrASTYKamZ6/d09lEGQnHc1Fnb2VKej4PqNtjSg3kUxBVirqFx9gtXps= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=drd9j8oA; arc=none smtp.client-ip=209.85.208.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="drd9j8oA" Received: by mail-lj1-f175.google.com with SMTP id 38308e7fff4ca-39ae13f8624so6863581fa.1 for ; Sat, 27 Jun 2026 07:21:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1782570059; x=1783174859; darn=vger.kernel.org; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=UjaUcqumMacUQ9KI5r4tiOS1vn4x2pFxKB8z2st3wU0=; b=drd9j8oAgovQZR3TgM4unhAakpdstwYs2mftRvmVeHBCYDWGVGXmtGt6LqMN5cmebU 64/bIUBnLM+VVFddNAt6Epu+JkLPusKHjXxeGCTbgU3iJx6r2KfNNE/xc6NKRsIe4uWa lIpgfMtcfuOa50P2EZuQzdajcF3MBkxbiDjfaG1Sk+FFOT1kyg9CIRHqn3BfjPJhz2E1 QBuHSXSu4j98drYUmQLszNsVQeobWAdkP3clmVIQ6KW8DxvLFCNVPll8+p+1EN/B50Px Oo9Ubkt8gjnKUxLcxhukRvegCwNFbPuREaOPmdHvJIrlVzYFW0iJ1rsxqcD51ziKy4EP x0wg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782570059; x=1783174859; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-gg:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=UjaUcqumMacUQ9KI5r4tiOS1vn4x2pFxKB8z2st3wU0=; b=G4ztBFAYz0qbahYwlEDk9A4TTSPr9BvlaEv8MOGKiKzICndqwMUzd95BbanNzr6BDY xJ5S7yid7aaMba0CRDKqDdNfB5rywGQA+IK9elgAcg0wT9Pz3sg3elYc0oFryhwhIwlq HXd4Ei0GCHBZFgeLHTb3MgfpsUZhXq3OHv4W9qTJNbmJ6/6Jeay3vY3J+AeWrjpreH1y NVF38nFD7FHpbO2f/h2hVk6AsuaC/2vQQrgmMxn3roAWlVkgS20/bIi5nM3DMo0fh/xg 391hU8WfCRW14ZTBLJqw2Ggr7M/15EKo5EdTiSzz2hWW8yWKgcIg8bus0qfSMG0KFfAQ Qn3A== X-Forwarded-Encrypted: i=1; AHgh+RrvxG5FvIzRhYoE+dbtm55X2ilecTOuNPo1PMZe1++boGmdHsxQthq7xSVOPphH00iVfi8lyoCWn5Ke540=@vger.kernel.org X-Gm-Message-State: AOJu0YzEi3dqMZf58GDg8SCIOivv61nisBUqZ82egmw/wRLcbxKrNhuj wuKBKFDo/zfFxtFqUZ2mfdMUxBp7kukvGwHIfwlQ9D50OmBBXYbMOdYv X-Gm-Gg: AfdE7clokMvu+FTVLQOM6Knz0ICKZu5/vOkbSM9CDwW+ekwFQFlasqzo6n4lCmSZsbT yZdEZUtZqHuuEz/tT35eBhG7rFonNtajdX5xmSi/UVD9FHU9KhFpYe12rR/cA8sm2aAoZeDP8xP XNjgPO833wNIiHzrN1q9TOh3ZThxMmkO5QH5YNjntSLk8U5wVoKfUA3q3Gzv+TGO7hNGG4X0pMt qaAeOKlBk5NWwFPZtsY71nnkZBHgkTak98dQNEJ3GInYehNbFAe9o0YqLAHIfpUcJRQCvlQ163M xRzqnlpveCRD9SFXgDkwBA4H+grs7WgenHHkkCG4Cpk3ChpvpuJr3gyhzrLLTK6W4FEmtutu8yF HqsSMWB1nt0TU29rJmTtc5wd3YrM5fVIowHSaKtt60AD+xA7GDmdR5hs8k5cIRsb5RX1Fk51Iyt 28RiD3nxoPf5iQlkBev6NQJ31OcPYnaIIhQEJPrdw90g== X-Received: by 2002:a05:651c:435a:20b0:399:99f9:3a17 with SMTP id 38308e7fff4ca-39ae15d1919mr7629901fa.21.1782570058841; Sat, 27 Jun 2026 07:20:58 -0700 (PDT) Received: from smtpclient.apple ([87.200.95.144]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-3999b1b1a7esm59752681fa.40.2026.06.27.07.20.55 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sat, 27 Jun 2026 07:20:58 -0700 (PDT) Content-Type: text/plain; charset=utf-8 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3864.600.51.1.1\)) Subject: Re: [PATCH v2] ASoC: meson: aiu: fifo-spdif: soft reset the S/PDIF datapath on start/stop From: Christian Hewitt In-Reply-To: Date: Sat, 27 Jun 2026 18:20:43 +0400 Cc: linux-amlogic@lists.infradead.org, Jerome Brunet , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Neil Armstrong , Kevin Hilman , Martin Blumenstingl , linux-sound@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Message-Id: References: <20260627125030.808058-1-christianshewitt@gmail.com> To: Ferass El Hafidi X-Mailer: Apple Mail (2.3864.600.51.1.1) > On 27 Jun 2026, at 5:08=E2=80=AFpm, Ferass El Hafidi = wrote: >=20 > Hi Christian, >=20 > On Sat, 27 Jun 2026 12:50, Christian Hewitt = wrote: >> The I2S FIFO soft-resets its fast domain on start (AIU_RST_SOFT bit 0 = + >> AIU_I2S_SYNC read in aiu_fifo_i2s_trigger), mirroring the downstream >> vendor driver's audio_out_i2s_enable(). The S/PDIF FIFO has no = equivalent: >> it only toggles the IEC958 DCU, so a stale datapath FIFO can be = replayed, >> producing the "machine gun noise" buffer underrun - on start when = switching >> outputs, and on stop when playback ends. The latter is audible on = devices >> with an always-on S/PDIF-fed DAC (e.g. the ES7144 on the WeTek = Play2). >>=20 >> The vendor driver resets the IEC958 fast domain (AIU_RST_SOFT bit 2) = on >> both enable and disable (audio_hw_958_enable), and when reconfiguring >> (audio_hw_958_reset clears AIU_958_DCU_FF_CTRL then resets). Do the = same: >> reset before enabling the DCU on start, and after disabling it on = stop. >>=20 >> Fixes: 6ae9ca9ce986bf ("ASoC: meson: aiu: add i2s and spdif support") >> Signed-off-by: Christian Hewitt >=20 > You may have forgotten to add Martin's R-b here. 100%, but I also missed amending the commit description for the v2 = change so there=E2=80=99s a v3 where it=E2=80=99s been added. Sorry for the noise = everyone, seems I am a little out of practice at submitting things. CH.=