From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-10630.protonmail.ch (mail-10630.protonmail.ch [79.135.106.30]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F0BA01DE883 for ; Thu, 17 Apr 2025 12:08:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=79.135.106.30 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744891685; cv=none; b=f2BT+DpZ4/E9/h2e9UNSVTnF4pvJZW+kVk9OUZWjzbTE000Gesm6Wl0sdSxAWifYWinD9YwEC9sD6Mdv3RmbdKwMXyTtmLP/ytZ5PR4NRfEQtB57fsvPrs1Jlzotu0mvdpn5kuENA81iLPLw19SbXY/uSK5PixTkeyHXqQ8LDkU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744891685; c=relaxed/simple; bh=+k7V2/G6e7IrrMrfxOhBFV0nKbZAHJ/r5dPLgdndTAM=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=N3solkYzBehhOeWto4W7d7PeBevfKJIqVgO8MFGJgKAA6zcdxHNio9MxfPfU1r6Of5RQHOOyOUWhNcIkwDQsbvEEF3akcDS15WndaYi618v1lvbk8HnuOkSe9EVWmZFjabRWmtB8OpNOpJZmjH2ksDGvUSLzoMVt7IOE9OCd5K8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=proton.me; spf=pass smtp.mailfrom=proton.me; dkim=pass (2048-bit key) header.d=proton.me header.i=@proton.me header.b=mw2Yqirm; arc=none smtp.client-ip=79.135.106.30 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=proton.me Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=proton.me Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=proton.me header.i=@proton.me header.b="mw2Yqirm" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=proton.me; s=protonmail; t=1744891675; x=1745150875; bh=+k7V2/G6e7IrrMrfxOhBFV0nKbZAHJ/r5dPLgdndTAM=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector:List-Unsubscribe:List-Unsubscribe-Post; b=mw2Yqirm4QUNhpchRFtVaI4OjLMVMykF2CiktdQlmatdOFuQJCC7UW3NM4EwJMvZi 4Y51ejHXvW8x13jaLSOhktoEaXOtB+QsulfGxvbO8E5B9PH1ku/5IkBq3pvfq3p+EN xl4osutYPEE7kfSGN00MI5fYye8Z/w8M/lAS96i+2tC2N5ZgAVswzZqqWOTtkFV4Ci KalpHbsPbyNGDYHdLnNQhzxXzk3ICbipwhL4DDBNU1jzBr7uEX4hOFGQJROyoCF1NO DkW7E4TNnO82KSAoLpKbpmi7/myGWBFKcKdxyxuWxrbTgdii9mJwq9r2JP/nIEDyy9 6FqMnyb+YbH4w== Date: Thu, 17 Apr 2025 12:07:49 +0000 To: Alice Ryhl From: Benno Lossin Cc: Miguel Ojeda , Alex Gaynor , Boqun Feng , Gary Guo , =?utf-8?Q?Bj=C3=B6rn_Roy_Baron?= , Andreas Hindborg , Trevor Gross , Danilo Krummrich , Fiona Behrens , rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/3] rust: pin-init: examples: conditionally enable `feature(lint_reasons)` Message-ID: In-Reply-To: References: <20250414195928.129040-1-benno.lossin@proton.me> <20250414195928.129040-3-benno.lossin@proton.me> Feedback-ID: 71780778:user:proton X-Pm-Message-ID: 9223b07556a4f6ac7509f12399e18184f084b5f1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On Wed Apr 16, 2025 at 11:58 PM CEST, Benno Lossin wrote: > On Tue Apr 15, 2025 at 11:26 AM CEST, Alice Ryhl wrote: >> On Mon, Apr 14, 2025 at 08:00:20PM +0000, Benno Lossin wrote: >>> `lint_reasons` is unstable in Rust 1.80 and earlier, enable it >>> conditionally in the examples to allow compiling them with older >>> compilers. >>>=20 >>> Link: https://github.com/Rust-for-Linux/pin-init/pull/33/commits/ec494f= e686b0a97d5b59b5be5a42d3858038ea6a >>> Signed-off-by: Benno Lossin >> >> Why not just always use #![feature] together with -Astable_features like >> the kernel does? > > I'd like to know when a feature becomes stable, since I don't keep track > of them like Miguel does. Ah one more reason: `pin-init` must compile under stable (when not enabling the `alloc` feature). And having `#![feature(..)]` is not allowed under stable (even if the feature itself is stable). --- Cheers, Benno