From: Daniel Almeida <daniel.almeida@collabora.com>
To: Andreas Hindborg <a.hindborg@kernel.org>
Cc: "Boqun Feng" <boqun.feng@gmail.com>,
"Miguel Ojeda" <ojeda@kernel.org>,
"Alex Gaynor" <alex.gaynor@gmail.com>,
"Gary Guo" <gary@garyguo.net>,
"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
"Benno Lossin" <lossin@kernel.org>,
"Alice Ryhl" <aliceryhl@google.com>,
"Trevor Gross" <tmgross@umich.edu>,
"Danilo Krummrich" <dakr@kernel.org>,
"Jens Axboe" <axboe@kernel.dk>,
"Breno Leitao" <leitao@debian.org>,
linux-block@vger.kernel.org, rust-for-linux@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v6 01/18] rust: str: normalize imports in `str.rs`
Date: Wed, 27 Aug 2025 09:25:04 -0300 [thread overview]
Message-ID: <D9BA84D8-51D8-4473-8FF0-9FBD4BF58F81@collabora.com> (raw)
In-Reply-To: <20250822-rnull-up-v6-16-v6-1-ec65006e2f07@kernel.org>
> On 22 Aug 2025, at 09:14, Andreas Hindborg <a.hindborg@kernel.org> wrote:
>
> Clean up imports in `str.rs`. This makes future code manipulation more
> manageable.
>
> Reviewed-by: Alice Ryhl <aliceryhl@google.com>
> Signed-off-by: Andreas Hindborg <a.hindborg@kernel.org>
> ---
> rust/kernel/str.rs | 9 +++++----
> 1 file changed, 5 insertions(+), 4 deletions(-)
>
> diff --git a/rust/kernel/str.rs b/rust/kernel/str.rs
> index 6c892550c0ba..082790b7a621 100644
> --- a/rust/kernel/str.rs
> +++ b/rust/kernel/str.rs
> @@ -2,12 +2,13 @@
>
> //! String representations.
>
> -use crate::alloc::{flags::*, AllocError, KVec};
> -use crate::fmt::{self, Write};
> +use crate::{
> + alloc::{flags::*, AllocError, KVec},
> + fmt::{self, Write},
> + prelude::*,
> +};
> use core::ops::{self, Deref, DerefMut, Index};
>
> -use crate::prelude::*;
> -
> /// Byte string without UTF-8 validity guarantee.
> #[repr(transparent)]
> pub struct BStr([u8]);
>
> --
> 2.47.2
>
>
>
Reviewed-by: Daniel Almeida <daniel.almeida@collabora.com>
next prev parent reply other threads:[~2025-08-27 12:25 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-22 12:14 [PATCH v6 00/18] rnull: add configfs, remote completion to rnull Andreas Hindborg
2025-08-22 12:14 ` [PATCH v6 01/18] rust: str: normalize imports in `str.rs` Andreas Hindborg
2025-08-27 12:25 ` Daniel Almeida [this message]
2025-08-22 12:14 ` [PATCH v6 02/18] rust: str: allow `str::Formatter` to format into `&mut [u8]` Andreas Hindborg
2025-08-22 12:14 ` [PATCH v6 03/18] rust: str: expose `str::{Formatter, RawFormatter}` publicly Andreas Hindborg
2025-08-27 12:57 ` Daniel Almeida
2025-08-22 12:14 ` [PATCH v6 04/18] rust: str: introduce `NullTerminatedFormatter` Andreas Hindborg
2025-08-27 13:02 ` Daniel Almeida
2025-08-22 12:14 ` [PATCH v6 05/18] rust: str: introduce `kstrtobool` function Andreas Hindborg
2025-08-27 13:10 ` Daniel Almeida
2025-08-22 12:14 ` [PATCH v6 06/18] rust: str: add `bytes_to_bool` helper function Andreas Hindborg
2025-08-27 13:46 ` Daniel Almeida
2025-09-01 8:07 ` Andreas Hindborg
2025-09-01 8:36 ` Alice Ryhl
2025-09-01 8:34 ` Alice Ryhl
2025-09-01 14:40 ` Daniel Almeida
2025-08-22 12:14 ` [PATCH v6 07/18] rust: configfs: re-export `configfs_attrs` from `configfs` module Andreas Hindborg
2025-08-27 13:48 ` Daniel Almeida
2025-08-22 12:14 ` [PATCH v6 08/18] rust: block: normalize imports for `gen_disk.rs` Andreas Hindborg
2025-08-22 12:14 ` [PATCH v6 09/18] rust: block: use `NullTerminatedFormatter` Andreas Hindborg
2025-08-27 13:50 ` Daniel Almeida
2025-08-22 12:14 ` [PATCH v6 10/18] rust: block: remove `RawWriter` Andreas Hindborg
2025-08-22 12:14 ` [PATCH v6 11/18] rust: block: remove trait bound from `mq::Request` definition Andreas Hindborg
2025-08-22 12:14 ` [PATCH v6 12/18] rust: block: add block related constants Andreas Hindborg
2025-08-27 13:52 ` Daniel Almeida
2025-08-22 12:14 ` [PATCH v6 13/18] rnull: move driver to separate directory Andreas Hindborg
2025-08-22 12:14 ` [PATCH v6 14/18] rnull: enable configuration via `configfs` Andreas Hindborg
2025-08-27 14:10 ` Daniel Almeida
2025-08-22 12:14 ` [PATCH v6 15/18] rust: block: add `GenDisk` private data support Andreas Hindborg
2025-08-27 17:52 ` Daniel Almeida
2025-09-01 8:21 ` Andreas Hindborg
2025-08-22 12:14 ` [PATCH v6 16/18] rust: block: mq: fix spelling in a safety comment Andreas Hindborg
2025-08-22 12:14 ` [PATCH v6 17/18] rust: block: add remote completion to `Request` Andreas Hindborg
2025-08-27 18:00 ` Daniel Almeida
2025-08-29 11:12 ` Andreas Hindborg
2025-09-01 14:24 ` Daniel Almeida
2025-08-22 12:14 ` [PATCH v6 18/18] rnull: add soft-irq completion support Andreas Hindborg
2025-08-27 18:02 ` Daniel Almeida
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=D9BA84D8-51D8-4473-8FF0-9FBD4BF58F81@collabora.com \
--to=daniel.almeida@collabora.com \
--cc=a.hindborg@kernel.org \
--cc=alex.gaynor@gmail.com \
--cc=aliceryhl@google.com \
--cc=axboe@kernel.dk \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun.feng@gmail.com \
--cc=dakr@kernel.org \
--cc=gary@garyguo.net \
--cc=leitao@debian.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lossin@kernel.org \
--cc=ojeda@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=tmgross@umich.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®