From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from relay9-d.mail.gandi.net (relay9-d.mail.gandi.net [217.70.183.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 92EF3215070; Tue, 29 Apr 2025 09:49:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.70.183.199 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745920161; cv=none; b=NOFNEZGviUMKvzbPYU0HPm4eJz6pjheVwpyS6f/AEeEFv13f6JJW+WfM8C5476JZUpHew/cwvfLwf0d94VNuTcUJN22iwefwx7KoJOF7PQez1jjbGIypJJM8MpfheFQ2BopRmWlS4xP8FPMNGNNFbA6DRn2xBksf1hnpw8rYu30= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745920161; c=relaxed/simple; bh=tqZ0WDpd3UCnsiyB13GsKoIcLdHmxLRzaHRSKG1EEsE=; h=Mime-Version:Content-Type:Date:Message-Id:Subject:From:To:Cc: References:In-Reply-To; b=Y1/qkvhAbTCbUpDv4yrdZrYVCMGvvWlZYEp7KwcLmUuevrPJWXMzz1cVP0hD++mDYbqy77XOKitFmcIRl1OWqsfWXx5BjVlBJLkO6+BnMzpVzJ7HXePXp8r3PFfxS/nZIGN3mbTZSpU5Z2RNYnKOi9j0ZdkOUNnORwj2F+k0qj8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=BaZ8t7kO; arc=none smtp.client-ip=217.70.183.199 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="BaZ8t7kO" Received: by mail.gandi.net (Postfix) with ESMTPSA id 656F74328B; Tue, 29 Apr 2025 09:49:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1745920150; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=tqZ0WDpd3UCnsiyB13GsKoIcLdHmxLRzaHRSKG1EEsE=; b=BaZ8t7kO9QR35XhfDlLfJAdORCV3aUUi29DxhEffSeC4/qO92hJbYxjDTNjWePj37YQqqF qGV6UZvx7sYqEEapQ2sJNm8niEkNvhO1YEYSUYaDBCnaRPwA/+XiuSdXFeCM0VFFeU/bQY 63jcFp8qOHYMrHQAugG28HWTCZ2mKc9+ShVrmzLnKjnShPn3uM5fl9OcmuIovrkmIk9dnB +mgoGULFSg3PqOsylSrO84e2Aq1HJ8dM5/81jemh5xyMQ8O6QnGTO/ieBXvFUb2f2tyJxA AscSm/s01ycVbb1sJuvhgTwL7GxTNG7mEqCS/+UO/dOKPnWJJyxUsEMvUKnq3Q== Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Tue, 29 Apr 2025 11:49:08 +0200 Message-Id: Subject: Re: [PATCH RFC bpf-next 3/4] bpf/selftests: add tests to validate proper arguments alignment on ARM64 From: =?utf-8?q?Alexis_Lothor=C3=A9?= To: =?utf-8?q?Alexis_Lothor=C3=A9?= , "Eduard Zingerman" Cc: "Alexei Starovoitov" , "Daniel Borkmann" , "John Fastabend" , "Andrii Nakryiko" , "Martin KaFai Lau" , "Song Liu" , "Yonghong Song" , "KP Singh" , "Stanislav Fomichev" , "Hao Luo" , "Jiri Olsa" , "Puranjay Mohan" , "Xu Kuohai" , "Catalin Marinas" , "Will Deacon" , "Mykola Lysenko" , "Shuah Khan" , "Maxime Coquelin" , "Alexandre Torgue" , "Florent Revest" , "Bastien Curutchet" , , "Thomas Petazzoni" , , , , , X-Mailer: aerc 0.20.1-0-g2ecb8770224a References: <20250411-many_args_arm64-v1-0-0a32fe72339e@bootlin.com> <20250411-many_args_arm64-v1-3-0a32fe72339e@bootlin.com> <3a16fae0346d4f733fb1a67ae6420d8bf935dbd8.camel@gmail.com> In-Reply-To: X-GND-State: clean X-GND-Score: -100 X-GND-Cause: gggruggvucftvghtrhhoucdtuddrgeefvddrtddtgddvieefhedtucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuifetpfffkfdpucggtfgfnhhsuhgsshgtrhhisggvnecuuegrihhlohhuthemuceftddunecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjughrpegggfgtfffkuffhvfevofhfjgesthhqredtredtjeenucfhrhhomheptehlvgigihhsucfnohhthhhorhoruceorghlvgigihhsrdhlohhthhhorhgvsegsohhothhlihhnrdgtohhmqeenucggtffrrghtthgvrhhnpeetudfgvefhveeugeegudethffgvefhleetgfeijeejieejjeevgedtheegfeekhfenucffohhmrghinhepsghoohhtlhhinhdrtghomhenucfkphepledtrdekledrudeifedruddvjeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepihhnvghtpeeltddrkeelrdduieefrdduvdejpdhhvghloheplhhotggrlhhhohhsthdpmhgrihhlfhhrohhmpegrlhgvgihishdrlhhothhhohhrvgessghoohhtlhhinhdrtghomhdpnhgspghrtghpthhtohepfedtpdhrtghpthhtoheprghlvgigihhsrdhlohhthhhorhgvsegsohhothhlihhnrdgtohhmpdhrtghpthhtohepvgguugihiiekjeesghhmrghilhdrtghomhdprhgtphhtthhopegrshhtsehkvghrnhgvlhdrohhrghdprhgtphhtthhopegurghnihgvlhesihhoghgvrghrsghogidrnhgvthdprhgtphhtthhopehjohhhnhdrfhgrshhtr ggsvghnugesghhmrghilhdrtghomhdprhgtphhtthhopegrnhgurhhiiheskhgvrhhnvghlrdhorhhgpdhrtghpthhtohepmhgrrhhtihhnrdhlrghusehlihhnuhigrdguvghvpdhrtghpthhtohepshhonhhgsehkvghrnhgvlhdrohhrgh X-GND-Sasl: alexis.lothore@bootlin.com On Mon Apr 28, 2025 at 10:41 PM CEST, Alexis Lothor=C3=A9 wrote: > On Mon Apr 28, 2025 at 6:52 PM CEST, Eduard Zingerman wrote: >> Alexis Lothor=C3=A9 writes: > If things really behaved correctly, f would not have the correct value bu= t > would still be handled as a 16 bytes value, so the test would not fail wi= th > "actual 35 !=3D 43", but something like "actual > 27254487904906932132179118915584 !=3D 43" (43 << 64 | 35) I guess. I stil= l > need to sort this out. And so indeed, the broken value is a big one: (gdb) p skel->bss->t11_f $4 =3D 793209995169510719523 (gdb) p/x skel->bss->t11_f $5 =3D 0x2b0000000000000023 (gdb) But we see the 35 (0x23) value in the error log because the formatters used= in ASSERT_EQ truncate the actual value. Alexis --=20 Alexis Lothor=C3=A9, Bootlin Embedded Linux and Kernel engineering https://bootlin.com