mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Folker Schwesinger" <dev@folker-schwesinger.de>
To: "Thomas Gessler" <thomas.gessler@brueckmann-gmbh.de>,
	<dmaengine@vger.kernel.org>
Cc: linux-kernel@vger.kernel.org, "Vinod Koul" <vkoul@kernel.org>,
	"Michal Simek" <michal.simek@amd.com>,
	"Manivannan Sadhasivam" <manivannan.sadhasivam@linaro.org>,
	"Uwe Kleine-König" <u.kleine-koenig@baylibre.com>,
	"Radhey Shyam Pandey" <radhey.shyam.pandey@amd.com>,
	"Krzysztof Kozlowski" <krzysztof.kozlowski@linaro.org>,
	"Marek Vasut" <marex@denx.de>,
	linux-arm-kernel@lists.infradead.org,
	"Suraj Gupta" <Suraj.Gupta2@amd.com>,
	"Harini Katakam" <harini.katakam@amd.com>
Subject: Re: [PATCH v2] dmaengine: xilinx_dma: Set dma_device directions
Date: Fri, 09 May 2025 05:11:14 +0000	[thread overview]
Message-ID: <D9RDE3X5FIWG.BUFCOXYYAW1U@folker-schwesinger.de> (raw)
In-Reply-To: <20250507182101.909010-1-thomas.gessler@brueckmann-gmbh.de>

On Wed May 7, 2025 at 8:21 PM CEST, Thomas Gessler wrote:
> Coalesce the direction bits from the enabled TX and/or RX channels into
> the directions bit mask of dma_device. Without this mask set,
> dma_get_slave_caps() in the DMAEngine fails, which prevents the driver
> from being used with an IIO DMAEngine buffer.
>
> Signed-off-by: Thomas Gessler <thomas.gessler@brueckmann-gmbh.de>

Tested-by: Folker Schwesinger <dev@folker-schwesinger.de>

> ---
> Changes in v2:
>   - Change to Suraj's simpler version as per Radhey's request
>
>  drivers/dma/xilinx/xilinx_dma.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/drivers/dma/xilinx/xilinx_dma.c b/drivers/dma/xilinx/xilinx_dma.c
> index 3ad44afd0e74..8f26b6eff3f3 100644
> --- a/drivers/dma/xilinx/xilinx_dma.c
> +++ b/drivers/dma/xilinx/xilinx_dma.c
> @@ -2909,6 +2909,8 @@ static int xilinx_dma_chan_probe(struct xilinx_dma_device *xdev,
>  		return -EINVAL;
>  	}
>  
> +	xdev->common.directions |= chan->direction;
> +
>  	/* Request the interrupt */
>  	chan->irq = of_irq_get(node, chan->tdest);
>  	if (chan->irq < 0)


  parent reply	other threads:[~2025-05-09  5:11 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-05-07 18:21 Thomas Gessler
2025-05-07 20:31 ` Gupta, Suraj
2025-05-09  5:11 ` Folker Schwesinger [this message]
2025-05-14 15:03 ` Vinod Koul

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=D9RDE3X5FIWG.BUFCOXYYAW1U@folker-schwesinger.de \
    --to=dev@folker-schwesinger.de \
    --cc=Suraj.Gupta2@amd.com \
    --cc=dmaengine@vger.kernel.org \
    --cc=harini.katakam@amd.com \
    --cc=krzysztof.kozlowski@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=manivannan.sadhasivam@linaro.org \
    --cc=marex@denx.de \
    --cc=michal.simek@amd.com \
    --cc=radhey.shyam.pandey@amd.com \
    --cc=thomas.gessler@brueckmann-gmbh.de \
    --cc=u.kleine-koenig@baylibre.com \
    --cc=vkoul@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®