From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f47.google.com (mail-wm1-f47.google.com [209.85.128.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C6AD1293B75 for ; Fri, 9 May 2025 13:16:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.47 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746796575; cv=none; b=T78RyOQL1UXr9WvEelGDWawKtRnsqrVqy/2vlz7AQhikvjU12+zv+64EBWLRctzuGTGLWCYXanUdfYmrhYdsHoNZmfcmOWOeUN2+oxZbpmkeCx9U1IDk7IdSxxpdLhdhTpkq23c3/vChxS/wblc3bSWsdvM5KMIG9UOzkwGhQYU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746796575; c=relaxed/simple; bh=nE1sJO6bMmV950ItAbVKzV+JgkjWCGTAhZok68459nI=; h=Mime-Version:Content-Type:Date:Message-Id:Cc:Subject:From:To: References:In-Reply-To; b=CIWh/yr4B43PtW3EG/PnEWdd+yTPjmznlPUp5iTMJ3JLafBnuzntVarLjYRn2XwZbsF5atjA8XKb59Efx2tCo8Op4oEF0obLN4Wr7FjAO2oxiaoB6Y+Cg2xoYnH9llJXdFgPgfpxVc5nrrmig1NJGAJ9NdmhJ1BO+dRbmaRGAas= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=Gl9Ntu17; arc=none smtp.client-ip=209.85.128.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Gl9Ntu17" Received: by mail-wm1-f47.google.com with SMTP id 5b1f17b1804b1-442ccf0e1b3so22269595e9.3 for ; Fri, 09 May 2025 06:16:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1746796572; x=1747401372; darn=vger.kernel.org; h=in-reply-to:references:to:from:subject:cc:message-id:date :content-transfer-encoding:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=t5Ch2Ix3jCa2oxbXfzb8ACl1u50kIZHwmzKlROnIIFE=; b=Gl9Ntu17YAnXr3HaSGwMx/F5QNJYX11JP4CJEo2lo8nMLJhoZyRVkiCY0/4cZmDX+5 eMKpPxVm0UwFZB2277T2Z24/NMCbc+273qaR9mROnxHCPiShrn00XR0GC9bRDNBq3yxf 9HAcoPtkrd/7UbtmVVtE0UNCkre61O1BoYaZRAFSIU902FqHsnw1e8f6Ex5VzBR51SvQ xz9zEN6F2/4S5SJa/BRvKI4GXkNOHaKoj00U+ZswqzLQUrHOQHLa4UXsnv/KULSA74r1 emSK6F7i0gH2u26/z9DRVpCd+z5bmJxpoTfoZM0eyhq9wz0Thb05heM2d5nE/tY+60bQ UMow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1746796572; x=1747401372; h=in-reply-to:references:to:from:subject:cc:message-id:date :content-transfer-encoding:mime-version:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=t5Ch2Ix3jCa2oxbXfzb8ACl1u50kIZHwmzKlROnIIFE=; b=ZTi7IfesLe7k/kuhiaYJxEMzZV7kgpHNQ2EcaCvW0LjiIgHsguiRVX1emt/72vP0u5 1SiWzEmKRNVRB05f1h5CZDKDTwo7GUijDXAtmGyel05nglhNsXB0YOaEejLLp5E6H73p dsGFk9I76QEK05V+Lx3eKK0mkQT3a+iGmjEFhfc+nm8q3IFcEXkf+MrBDzWLpq7EW9Lr DkKU0V++uP8fO9hmNITPwx6b6h6JRoivqQFOA9b/FiZ3tIitUpKhbXVXKqJlC/tndD7+ wXflWJNI05Z87iZ/xKB7IYkac870syyju/frDQmO+tWoHjlfI97USnltMvEicHmz6wo7 LUQQ== X-Forwarded-Encrypted: i=1; AJvYcCWrm6hZa4ObgiAfKAhN7Gi/fr5M5BCni3MVWAXEw0h5UDFj7CNzCA/G3EcBFaiwdr4k1xPHEAqTvwYKv3Y=@vger.kernel.org X-Gm-Message-State: AOJu0Yw/t2jWSOXIpmC/UmP5/q+2unChf8HGp0HumHHiRaYXpUaMwYJB 4pjx62EwHX4jpPLMSVhIUtlaNEdSb7CQ6Ff2wjcEmiaZrlvrU9XwcOs18cmCO8o= X-Gm-Gg: ASbGncuxufbyoLkYdxCYbJ16sO53LGYzEaxzJClqgPd4mMtH4yCSECZlg4Qhcs1GQpL uptDNknnnloH4CHRkOJtBPV+0iO5BHej10trffnO5GANroBmZn+5WdYAFJiIi1QPpoHOYpkjmCY wj5xQ/ZfKjpBVi4ECk4+FvjFpn0f2Bn+T1ZlwML3YdHW3/xFLGKCLZn6ZjvCso867W9cRPp1+LH kpUa0lZ8sA/xD4RgTLW67qvRhsDz5WAIVC6UrxzoFlhzTE1m36bjM9drxAQbh287uHaAURmBHbz lhIkKUXNpTIXuMWEtTPHwkfqlM7IlmB7znXLX83G3ibG9g== X-Google-Smtp-Source: AGHT+IHOeVl956z9ZA+/rmH/CqsgSIc1EBvEUzZVkZ1heuJiPGNSlBg/CUUO2b7r81RCL0ma+aBi9Q== X-Received: by 2002:a05:600c:6308:b0:43c:fe15:41c9 with SMTP id 5b1f17b1804b1-442d6d3e6d9mr30377825e9.9.1746796572001; Fri, 09 May 2025 06:16:12 -0700 (PDT) Received: from localhost ([2a00:2381:fd67:101:6c39:59e6:b76d:825]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-442cd3b7dd5sm71167815e9.35.2025.05.09.06.16.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 09 May 2025 06:16:11 -0700 (PDT) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Fri, 09 May 2025 14:16:10 +0100 Message-Id: Cc: , , , , , , , , , Subject: Re: [PATCH] arm64: dts: qcom: sm8750: Add adsp fastrpc support From: "Alexey Klimov" To: "Srinivas Kandagatla" , , X-Mailer: aerc 0.20.0 References: <20250502011539.739937-1-alexey.klimov@linaro.org> In-Reply-To: On Fri May 2, 2025 at 11:51 AM BST, Srinivas Kandagatla wrote: > On 5/2/25 02:15, Alexey Klimov wrote: >> While at this, also add required memory region for fastrpc. >>=20 >> Tested on sm8750-mtp device with adsprpdcd. >>=20 >> Cc: Ekansh Gupta >> Cc: Srinivas Kandagatla >> Cc: Krzysztof Kozlowski >> Signed-off-by: Alexey Klimov >> --- >> arch/arm64/boot/dts/qcom/sm8750.dtsi | 70 ++++++++++++++++++++++++++++ >> 1 file changed, 70 insertions(+) >>=20 >> diff --git a/arch/arm64/boot/dts/qcom/sm8750.dtsi b/arch/arm64/boot/dts/= qcom/sm8750.dtsi >> index 149d2ed17641..48ee66125a89 100644 >> --- a/arch/arm64/boot/dts/qcom/sm8750.dtsi >> +++ b/arch/arm64/boot/dts/qcom/sm8750.dtsi >> @@ -7,6 +7,7 @@ >> #include >> #include >> #include >> +#include >> #include >> #include >> #include >> @@ -523,6 +524,14 @@ llcc_lpi_mem: llcc-lpi@ff800000 { >> reg =3D <0x0 0xff800000 0x0 0x800000>; >> no-map; >> }; >> + >> + adsp_rpc_remote_heap_mem: adsp-rpc-remote-heap { >> + compatible =3D "shared-dma-pool"; >> + alloc-ranges =3D <0x0 0x00000000 0x0 0xffffffff>; >> + alignment =3D <0x0 0x400000>; >> + size =3D <0x0 0xc00000>; >> + reusable; >> + }; >> }; >> =20 >> smp2p-adsp { >> @@ -2237,6 +2246,67 @@ q6prmcc: clock-controller { >> }; >> }; >> }; >> + >> + fastrpc { >> + compatible =3D "qcom,fastrpc"; >> + qcom,glink-channels =3D "fastrpcglink-apps-dsp"; >> + label =3D "adsp"; >> + memory-region =3D <&adsp_rpc_remote_heap_mem>; >> + qcom,vmids =3D > + QCOM_SCM_VMID_ADSP_HEAP>; >> + qcom,non-secure-domain; > > Any reason why we what to mark adsp as non-secure domain by default? No particular reason. That's what we went with on other platforms, so this = just follows the same. If we need to update this flag to secure then most likely that sh= ould be done for some other platforms as well. The only thing I know that adsprpcd + audio pd works with non-secure flag. I can try to re-test with secure flag. Ekansh, do we have any preference here regarding this? Best regards, Alexey