Hi Thomas,

On Mon May 12, 2025 at 4:12 AM -03, Thomas Weißschuh wrote:
> On 2025-05-09 04:48:37-0300, Kurt Borja wrote:
>> Transition to new firmware_attributes API and replace `enumeration` types
>> with the simpler `boolean` type.
>
> This is an ABI change, using a newly introduced ABI.
> Some elaboration why it does not break userspace would be good.

I thought it was not a big deal since the driver was still new. But TIL
fwupd actually interfaces with the firmware-attributes class.

I won't break the ABI of this driver in the next revision.

-- 
 ~ Kurt

>
>> 
>> Signed-off-by: Kurt Borja <kuurtb@gmail.com>
>> ---
>>  drivers/platform/x86/samsung-galaxybook.c | 299 ++++++++++++------------------
>>  1 file changed, 114 insertions(+), 185 deletions(-)
>
> <snip>