From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755157AbcAMREO (ORCPT ); Wed, 13 Jan 2016 12:04:14 -0500 Received: from mail-am1on0089.outbound.protection.outlook.com ([157.56.112.89]:3920 "EHLO emea01-am1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753605AbcAMREL convert rfc822-to-8bit (ORCPT ); Wed, 13 Jan 2016 12:04:11 -0500 X-Greylist: delayed 7105 seconds by postgrey-1.27 at vger.kernel.org; Wed, 13 Jan 2016 12:04:10 EST From: Elad Raz To: Dan Carpenter CC: Jiri Pirko , Ido Schimmel , netdev , "linux-kernel@vger.kernel.org" , "kernel-janitors@vger.kernel.org" Subject: Re: [patch] mlxsw: fix SWITCHDEV_OBJ_ID_PORT_MDB Thread-Topic: [patch] mlxsw: fix SWITCHDEV_OBJ_ID_PORT_MDB Thread-Index: AQHRTf30z0tuNeHPM0OwOKzUXDmYDp75YSeA Date: Wed, 13 Jan 2016 12:33:14 +0000 Message-ID: References: <20160113122823.GD19993@mwanda> In-Reply-To: <20160113122823.GD19993@mwanda> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=eladr@mellanox.com; x-ms-exchange-messagesentrepresentingtype: 1 x-originating-ip: [193.47.165.251] x-microsoft-exchange-diagnostics: 1;DB5PR05MB1237;5:ywUeFHXQiVnFx9dvBtGwrK0BJyWlK0+WFuJ1sk9n2XWkNgesMl9xCtDAZc9NCWbq4H/sqgDqOrj4KYRJW1tVS61AZ0kxYNRNnSuAS1uvo85UBQQkHGOZKikPsK/KpJrN3Iyhlr+3nkFMeLw8jBLhlA==;24:qH4tyf7Q9o/ZdgMTt1hKR5TNQKqoqD0T38/M8uBNyQ5gWjRRJAyQVKwWki+SBgZ2BlmZYyvhHRftKZ3hdiSrHHG7MC81Xy3xj4FILurlDkY= x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:DB5PR05MB1237; x-ms-office365-filtering-correlation-id: 98642650-e89d-4d05-350c-08d31c15b545 x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(34787635062028); x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(601004)(2401047)(5005006)(520078)(8121501046)(3002001)(10201501046);SRVR:DB5PR05MB1237;BCL:0;PCL:0;RULEID:;SRVR:DB5PR05MB1237; x-forefront-prvs: 08200063E9 x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(6009001)(377454003)(24454002)(189002)(199003)(5008740100001)(4326007)(82746002)(97736004)(189998001)(66066001)(2906002)(36756003)(110136002)(3846002)(5001960100002)(102836003)(6116002)(1096002)(92566002)(586003)(81156007)(77096005)(2900100001)(2950100001)(1220700001)(10400500002)(87936001)(50986999)(76176999)(83716003)(11100500001)(5004730100002)(5002640100001)(54356999)(33656002)(86362001)(19580405001)(105586002)(101416001)(19580395003)(122556002)(106356001)(106116001)(40100003)(104396002);DIR:OUT;SFP:1101;SCL:1;SRVR:DB5PR05MB1237;H:DB5PR05MB1029.eurprd05.prod.outlook.com;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; Content-Type: text/plain; charset="us-ascii" Content-ID: Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Jan 2016 12:33:14.8599 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB5PR05MB1237 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > On Jan 13, 2016, at 2:28 PM, Dan Carpenter wrote: > > There is a missing break statement so we always return -EOPNOTSUPP. > > Fixes: 3a49b4fde2a1 ('mlxsw: Adding layer 2 multicast support') > Signed-off-by: Dan Carpenter Acked-by: Elad Raz > > diff --git a/drivers/net/ethernet/mellanox/mlxsw/spectrum_switchdev.c b/drivers/net/ethernet/mellanox/mlxsw/spectrum_switchdev.c > index ffe894e..45479ef 100644 > --- a/drivers/net/ethernet/mellanox/mlxsw/spectrum_switchdev.c > +++ b/drivers/net/ethernet/mellanox/mlxsw/spectrum_switchdev.c > @@ -1015,6 +1015,7 @@ static int mlxsw_sp_port_obj_del(struct net_device *dev, > case SWITCHDEV_OBJ_ID_PORT_MDB: > err = mlxsw_sp_port_mdb_del(mlxsw_sp_port, > SWITCHDEV_OBJ_PORT_MDB(obj)); > + break; > default: > err = -EOPNOTSUPP; > break;