From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f42.google.com (mail-wm1-f42.google.com [209.85.128.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9269F27A45C for ; Tue, 27 May 2025 15:56:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748361366; cv=none; b=d0WnouUwf3qWkCMjuP9vAYHtTUtLSuTDLos+rRkZ+/+bYtPAa3fsNVdvCXdxbHxO93j4H4KJDEmufp8dEt8FL2js8MKC9hqWIcsyD19aeBUHD+o+77Phad6P1J2sH3Z9aafyT1l7/KBThIh8AvpEp0WWpNGQdX0uI+7osA6GT2k= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748361366; c=relaxed/simple; bh=1EN/qo7phDn1lEOJKo1bEU9nZpbFRZxjY4LQ8qzGqFI=; h=Mime-Version:Content-Type:Date:Message-Id:Cc:Subject:From:To: References:In-Reply-To; b=oBXuAO8IS7rAES2Dz2vpsOaSRK2BdRaMd6AOlbK9Azqla7nAcbKP5yJej9oWzfS4JCeB3rKUiYQ6SNJBA1GueFRgbPl/J9uAnrWuWdbPyKB9IFvxhFBYQXWlR8ECU+OwenrT0gNIon+d08Uf7yF3huPGME08BveFd95GD9rurnw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=D9+bMXgB; arc=none smtp.client-ip=209.85.128.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="D9+bMXgB" Received: by mail-wm1-f42.google.com with SMTP id 5b1f17b1804b1-43cfe574976so28445665e9.1 for ; Tue, 27 May 2025 08:56:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1748361361; x=1748966161; darn=vger.kernel.org; h=in-reply-to:references:to:from:subject:cc:message-id:date :content-transfer-encoding:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=WUOHpXno4FKjbaz+Vq7mO6g3BDL4JOg348p7rmPIkO0=; b=D9+bMXgBs7Whru0LXz2r8gO7XmJknG9G4OyDwi7ccJ1O7tl45N6R2SM7BXlixt0hbN p+wdfVF4mcWYrxKOqKhvj5QneCwW0HGgbkSstk3ZSOqrISIK3XRYzvLmmnzRQcbjjRHH roaC8DMpMmT2XxdheJluYHIFNAblObzopbfDiKrdzVWHIiWy5kg4klQ/FvzPd7IprvWV s2anymuNGOFM8TWZP+3Tj9DyWDwW26vmtZaLmJotryTT3NJunu2hHKQ+jEqerXwKSf8o Tkr6cB1LTmEUnzw3ZhBFOi+plBdu6UPT4yuFFT53IWUA0E191w2W7eIfDOyxRRBEzWMR B2Uw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1748361361; x=1748966161; h=in-reply-to:references:to:from:subject:cc:message-id:date :content-transfer-encoding:mime-version:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=WUOHpXno4FKjbaz+Vq7mO6g3BDL4JOg348p7rmPIkO0=; b=MqRa88Q4P6PYOYIx7l08VsEgK1O7JNSqwrxKr/lODGNY3dxtskFbEJRt2PSTloVabp /eoouZGaPkaf85BoQyn51037wBM627SFMCOgwAhh81DvOSNBzsiaE5au+4mg27dqf8y3 6wK+8I9thTgAkfLJwrB63Qcln5sThyk3hWICXHnxC08iH1pjyF/BK7ZHL5VBSd5wDjJU W2xhYvFx9bkaZAz4Vku59cvVT0TiJhLeOVR0YE6LwyNK2u3xItT/lruf3mL36ef1NUji 3OzFtwZ9a/zy+Kg56T3MyvNOA4zEjlMIa9U1sW4wGM7cknO7gmWGqmHhcfZMEidzL5qI yi6w== X-Forwarded-Encrypted: i=1; AJvYcCWRvpx6z771KJSPTe+iLZ3ZPfdXa+N0jmi4YXwU/lCLbdqOx1W8E4mdGO/0YZ8zakKYpc1IZas1h5L0wl8=@vger.kernel.org X-Gm-Message-State: AOJu0YyozTIIc/X6ErUBLds013IUYdxTmrTZZf10h7atAzr9Rc9ZKtU+ cXFoKFTC2Y0O3fRDyDyb9zGWOnO/cr3y+UWTWvF6ksmuRC7oNPlYNph62SGeRiS6i4s= X-Gm-Gg: ASbGncso43AKyqGQa6l7LAho++EOG8IPecd5JR66FElX+u1bip2j1CJKMlfIJAsz3bs fYwBC6YiuFSahYsmBczu4UEYZVBTThnl/ZgiByYa7VSH/L2mjdhA1WtTY8Ijk3TQrvsfe1fqA5R hUd2nbdYsCaDXij0lmqOVuUaaA55uxZriy/fWnKKiLY0iq5hShzfgmawEs9AapCmqXuAgf+Rrsx uucxEJGZvkOx59iW28f8AntARerMHlTzeS6dQP6e6U2TiWwaksm5Givd9F6R0ZdLCkZ8F9CzXt/ QDQYw7eYSioZcJ6Wo7itj/dCsKdlz6SADTk1nV3gWZhp3B4oK5aRbL7TsoHvqIzJ5otd X-Google-Smtp-Source: AGHT+IGWpBubqNiiMJO9C0pBAekzBnLwiPK9uY689/6fUTlai3/xs++Qb/ljE1+USh/yGxcE4+gWhA== X-Received: by 2002:a05:600c:6296:b0:43c:f616:f08 with SMTP id 5b1f17b1804b1-44c91ad6b46mr120335515e9.8.1748361360729; Tue, 27 May 2025 08:56:00 -0700 (PDT) Received: from localhost ([2a02:c7c:7213:c700:f024:90b8:5947:4156]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-447f1ef0ab8sm270595235e9.13.2025.05.27.08.55.59 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 27 May 2025 08:55:59 -0700 (PDT) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Tue, 27 May 2025 16:55:59 +0100 Message-Id: Cc: "Liam Girdwood" , "Rob Herring" , "Krzysztof Kozlowski" , "Krzysztof Kozlowski" , "Conor Dooley" , "Bjorn Andersson" , "Dmitry Baryshkov" , "Konrad Dybcio" , "Jaroslav Kysela" , "Takashi Iwai" , , , , Subject: Re: [PATCH v3 10/12] arm64: dts: qcom: qrb4210-rb2: enable wsa881x amplifier From: "Alexey Klimov" To: "Konrad Dybcio" , "Srinivas Kandagatla" , "Mark Brown" , X-Mailer: aerc 0.20.0 References: <20250522-rb2_audio_v3-v3-0-9eeb08cab9dc@linaro.org> <20250522-rb2_audio_v3-v3-10-9eeb08cab9dc@linaro.org> In-Reply-To: On Thu May 22, 2025 at 7:13 PM BST, Konrad Dybcio wrote: > On 5/22/25 7:41 PM, Alexey Klimov wrote: >> One WSA881X amplifier is connected on QRB4210 RB2 board >> hence only mono speaker is supported. This amplifier is set >> to work in analog mode only. Also add required powerdown >> pin/gpio. >>=20 >> Cc: Srinivas Kandagatla >> Signed-off-by: Alexey Klimov >> --- >> arch/arm64/boot/dts/qcom/qrb4210-rb2.dts | 26 +++++++++++++++++++++++++= + >> 1 file changed, 26 insertions(+) >>=20 >> diff --git a/arch/arm64/boot/dts/qcom/qrb4210-rb2.dts b/arch/arm64/boot/= dts/qcom/qrb4210-rb2.dts >> index 6bce63720cfffd8e0e619937fb1f365cbbbcb283..4b878e585227ee6b3b362108= be96aad99acba21d 100644 >> --- a/arch/arm64/boot/dts/qcom/qrb4210-rb2.dts >> +++ b/arch/arm64/boot/dts/qcom/qrb4210-rb2.dts >> @@ -270,6 +270,24 @@ zap-shader { >> }; >> }; >> =20 >> +&i2c1 { >> + clock-frequency =3D <400000>; >> + status =3D "okay"; >> + >> + wsa881x: amplifier@f { >> + compatible =3D "qcom,wsa8815"; >> + reg =3D <0x0f>; >> + pinctrl-0 =3D <&wsa_en_active>; >> + pinctrl-names =3D "default"; >> + clocks =3D <&q6afecc LPASS_CLK_ID_MCLK_2 LPASS_CLK_ATTRIBUTE_COUPLE_N= O>; >> + powerdown-gpios =3D <&lpass_tlmm 16 GPIO_ACTIVE_LOW>; >> + mclk-gpios =3D <&lpass_tlmm 18 GPIO_ACTIVE_HIGH>; >> + sound-name-prefix =3D "SpkrMono"; >> + #sound-dai-cells =3D <0>; >> + #thermal-sensor-cells =3D <0>; >> + }; >> +}; >> + >> &i2c2_gpio { >> clock-frequency =3D <400000>; >> status =3D "okay"; >> @@ -736,6 +754,14 @@ wcd_reset_n: wcd-reset-n-state { >> drive-strength =3D <16>; >> output-high; >> }; >> + >> + wsa_en_active: wsa-en-active-state { >> + pins =3D "gpio106"; > > Are there two separate enable pins? Or is the powerdown-gpio something > else? No, should be only one. I think 106 on tlmm is wired into 16 on lpass tlmm. We need to assign gpio function to such pins, aren't we? Best regards, Alexey