From: "Benno Lossin" <lossin@kernel.org>
To: "Sai Vishnu" <saivishnu725@gmail.com>,
"Miguel Ojeda" <miguel.ojeda.sandonis@gmail.com>
Cc: <rust-for-linux@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<ojeda@kernel.org>, <alex.gaynor@gmail.com>,
<boqun.feng@gmail.com>, <gary@garyguo.net>,
<bjorn3_gh@protonmail.com>, <a.hindborg@kernel.org>,
<aliceryhl@google.com>, <tmgross@umich.edu>, <dakr@kernel.org>,
<gregkh@linuxfoundation.org>, <daniel.almeida@collabora.com>,
<me@kloenk.dev>
Subject: Re: [PATCH] rust: doc: Clean up formatting in io.rs
Date: Sat, 31 May 2025 09:38:05 +0200 [thread overview]
Message-ID: <DAA6AJ0N7JAA.WCEOCHKVFLDD@kernel.org> (raw)
In-Reply-To: <CAFttn54qYu3ajcBPWWnhjAS-6pQ8Ox3ujbTF6D=Q_BOMkTLq6g@mail.gmail.com>
On Sat May 31, 2025 at 4:57 AM CEST, Sai Vishnu wrote:
> On Sat, May 31, 2025 at 1:09 AM Miguel Ojeda
> <miguel.ojeda.sandonis@gmail.com> wrote:
>>
>> We should also probably add "region" there, after "memory", or
>> similar, especially if we remove the second part.
>
> Thanks for the feedback! I’ve decided to update the comment to just:
>
> /// IO-mapped memory
>
> I’m new to kernel development. Should I just share the updated patch
> here or send a v2 that refers to this one? Thanks!
Normally, you send a v2 with a changelog and a link to each previous
version. For patch series with a cover letter it is often placed there.
Since you don't need one, you should put the changelog after the `---`
(anything that isn't a diff there will be ignored by git when applying).
I'd give others a few more days to review. (this patch there most likely
won't be any additional comments, but it also doesn't hurt)
---
Cheers,
Benno
prev parent reply other threads:[~2025-05-31 7:38 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-30 12:31 saivishnu725
2025-05-30 19:19 ` Benno Lossin
2025-05-30 19:39 ` Miguel Ojeda
2025-05-31 2:57 ` Sai Vishnu
2025-05-31 7:38 ` Benno Lossin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DAA6AJ0N7JAA.WCEOCHKVFLDD@kernel.org \
--to=lossin@kernel.org \
--cc=a.hindborg@kernel.org \
--cc=alex.gaynor@gmail.com \
--cc=aliceryhl@google.com \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun.feng@gmail.com \
--cc=dakr@kernel.org \
--cc=daniel.almeida@collabora.com \
--cc=gary@garyguo.net \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=me@kloenk.dev \
--cc=miguel.ojeda.sandonis@gmail.com \
--cc=ojeda@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=saivishnu725@gmail.com \
--cc=tmgross@umich.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®