From: Sachin Sant <sachinp@linux.vnet.ibm.com>
To: Vincent Guittot <vincent.guittot@linaro.org>
Cc: Ingo Molnar <mingo@redhat.com>,
Peter Zijlstra <peterz@infradead.org>,
Juri Lelli <juri.lelli@redhat.com>,
Dietmar Eggemann <dietmar.eggemann@arm.com>,
rostedt@goodmis.org, bsegall@google.com, mgorman@suse.de,
bristot@redhat.com, linux-kernel@vger.kernel.org, odin@uged.al
Subject: Re: [PATCH] sched/fair: Sync load_sum with load_avg after dequeue
Date: Fri, 2 Jul 2021 11:45:28 +0530 [thread overview]
Message-ID: <DAABF914-F5D0-4C92-BFE0-341D83B9F3D0@linux.vnet.ibm.com> (raw)
In-Reply-To: <20210701171837.32156-1-vincent.guittot@linaro.org>
> On 01-Jul-2021, at 10:48 PM, Vincent Guittot <vincent.guittot@linaro.org> wrote:
>
> commit 9e077b52d86a ("sched/pelt: Check that *_avg are null when *_sum are")
> reported some inconsitencies between *_avg and *_sum.
>
> commit 1c35b07e6d39 ("sched/fair: Ensure _sum and _avg values stay consistent")
> fixed some but one remains when dequeuing load.
>
> sync the cfs's load_sum with its load_avg after dequeuing the load of a
> sched_entity.
>
> Fixes: 9e077b52d86a ("sched/pelt: Check that *_avg are null when *_sum are")
> Reported-by: Sachin Sant <sachinp@linux.vnet.ibm.com>
> Signed-off-by: Vincent Guittot <vincent.guittot@linaro.org>
> ---
>
> I have been able to trigger a WARN on my system even with the patch
> listed above. This patch fixes it.
> Sachin could you test that it also fixes yours ?
>
I ran various LTP stress tests, scheduler tests and kernel compile operation for about 5 hours.
Haven’t seen the warning during the testing.
Tested-by: Sachin Sant <sachinp@linux.vnet.ibm.com>
I have left the tests running, will let it run for few more hours.
Thanks
-Sachin
> kernel/sched/fair.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
> index 11d22943753f..48fc7dfc2f66 100644
> --- a/kernel/sched/fair.c
> +++ b/kernel/sched/fair.c
> @@ -3037,8 +3037,9 @@ enqueue_load_avg(struct cfs_rq *cfs_rq, struct sched_entity *se)
> static inline void
> dequeue_load_avg(struct cfs_rq *cfs_rq, struct sched_entity *se)
> {
> + u32 divider = get_pelt_divider(&se->avg);
> sub_positive(&cfs_rq->avg.load_avg, se->avg.load_avg);
> - sub_positive(&cfs_rq->avg.load_sum, se_weight(se) * se->avg.load_sum);
> + cfs_rq->avg.load_sum = cfs_rq->avg.load_avg * divider;
> }
> #else
> static inline void
> --
> 2.17.1
>
next prev parent reply other threads:[~2021-07-02 6:21 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-01 17:18 Vincent Guittot
2021-07-02 6:15 ` Sachin Sant [this message]
2021-07-02 8:08 ` Vincent Guittot
2021-07-02 9:02 ` Odin Ugedal
2021-07-05 7:53 ` [tip: sched/urgent] " tip-bot2 for Vincent Guittot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DAABF914-F5D0-4C92-BFE0-341D83B9F3D0@linux.vnet.ibm.com \
--to=sachinp@linux.vnet.ibm.com \
--cc=bristot@redhat.com \
--cc=bsegall@google.com \
--cc=dietmar.eggemann@arm.com \
--cc=juri.lelli@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mgorman@suse.de \
--cc=mingo@redhat.com \
--cc=odin@uged.al \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=vincent.guittot@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®