From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-177.mta0.migadu.com (out-177.mta0.migadu.com [91.218.175.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7630D2F5307 for ; Wed, 18 Jun 2025 12:12:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.218.175.177 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750248763; cv=none; b=K4JSGnPD3PD7xIC6as7MZhU42M9pUwU4cv3Agke3O4QCfFZq92fMjBS7ZvqPRHGJkXCUA2iYBmJr+hSblMWJR+ZhLBCkjUWmcpQdGsS6X0HgOPd4+PuWeMIudm8xgBmE3ygFZ0qIf549xzr2P9sasnaWvdhBKTXj8Ohtw7w0jlU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750248763; c=relaxed/simple; bh=zFk2egmf36IbeczadxJnUHDOOVO8nEoXhdsgsdwa/AU=; h=Mime-Version:Content-Type:Date:Message-Id:To:Cc:Subject:From: References:In-Reply-To; b=qFp48PgwZ68gVGVTkptK4xolkPXIVLbjVtBVm0t8yLSuK7K9mn5d6xrLXIVXsFu1m5tR9SS7/19LSQaYQwjs0qyYSV86M3FFEXjob63AXLmdezx/lQO4yIN103h4LOTMiUkcKL9j1tfUcP9yAw9AvMKkozQkpoFNAhb+PxkByyc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=cknow.org; spf=pass smtp.mailfrom=cknow.org; dkim=pass (2048-bit key) header.d=cknow.org header.i=@cknow.org header.b=WGEEuCPd; arc=none smtp.client-ip=91.218.175.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=cknow.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=cknow.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=cknow.org header.i=@cknow.org header.b="WGEEuCPd" Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cknow.org; s=key1; t=1750248757; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=+fwuhHs7pqnSyoIdYUQwG7qjgQ1CC6dPRZ/xpENoi6E=; b=WGEEuCPdsRaGDkWhC8iz9ZzBxfRVX6fRUXN35unrrg/RSzEOp5Y2YlPQz9Kw46epXq25Kt qKy9OYZjWc3RZI23h2IDLRL354jLZvmJTj80nLS+olZ86dFpaS+GGr0VJafCYbccXUFMNy tAnq4OBc+6/FaeJsHd82Q0oD8vtQZZXtTV/ld4ePnMAaE5eLqXIpMjjoy+SAfPJqAAyWDJ VkrAsh+MbnzD/LLEBxhJCBA5S2DT2iIbfyUNa03gpy4BRs7J8KBkvv/1Rvj4v+kkgZ7CjC 06rcd5QPUk45Zffjom8mZLRe/1MTB/Qk76ZzDQ6ns50y9cRikT7plfCxpnw95w== Content-Type: multipart/signed; boundary=d094255437ed180642212f2daf7bb7d49bbc773ab458e9a2480ab8cbe8f0; micalg=pgp-sha512; protocol="application/pgp-signature" Date: Wed, 18 Jun 2025 14:12:13 +0200 Message-Id: To: "Olivier Benjamin" , "Rob Herring" , "Krzysztof Kozlowski" , "Conor Dooley" , "Heiko Stuebner" Cc: "Thomas Petazzoni" , , , , Subject: Re: [PATCH 3/3] arm64: dts: rockchip: Remove unused property in PinePhone Pro MIPI panel X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: "Diederik de Haas" References: <20250618-dtb_fixes-v1-0-e54797ad2eba@bootlin.com> <20250618-dtb_fixes-v1-3-e54797ad2eba@bootlin.com> In-Reply-To: <20250618-dtb_fixes-v1-3-e54797ad2eba@bootlin.com> X-Migadu-Flow: FLOW_OUT --d094255437ed180642212f2daf7bb7d49bbc773ab458e9a2480ab8cbe8f0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Hi, On Wed Jun 18, 2025 at 12:32 AM CEST, Olivier Benjamin wrote: > The MIPI panel definition in the PinePhone Pro DTS includes a > "pinctrl-names" property, which is unused in the absence of pinctrl-0. > > Signed-off-by: Olivier Benjamin > --- > arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts b/arch= /arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts > index 5a7341fb6bcb0613af6f3ac31d99355a0f890e89..405140700208365c8631de86a= 2d7b6e577b7aa7f 100644 > --- a/arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts > +++ b/arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts > @@ -485,7 +485,6 @@ panel@0 { > reset-gpios =3D <&gpio4 RK_PD1 GPIO_ACTIVE_LOW>; > vcc-supply =3D <&vcc2v8_lcd>; > iovcc-supply =3D <&vcc1v8_lcd>; > - pinctrl-names =3D "default"; Why not define a pinctrl for LCD1_RST for GPIO4_D1 and reference that in pinctrl-0? (See page 11 and 16 of the schematics) Cheers, Diederik > =20 > port { > mipi_in_panel: endpoint { --d094255437ed180642212f2daf7bb7d49bbc773ab458e9a2480ab8cbe8f0 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYKAB0WIQT1sUPBYsyGmi4usy/XblvOeH7bbgUCaFKtJQAKCRDXblvOeH7b birRAP9UF4IfSII2WRPdY7JTipjbLL5426U7AHmPMYj5ktK2igEAqMjf89ZjcYJi y80+OTxY2ljkePaU/MPugTRVg3TTcgk= =NOom -----END PGP SIGNATURE----- --d094255437ed180642212f2daf7bb7d49bbc773ab458e9a2480ab8cbe8f0--