From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-178.mta0.migadu.com (out-178.mta0.migadu.com [91.218.175.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7D0DD132103 for ; Thu, 19 Jun 2025 11:41:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.218.175.178 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750333281; cv=none; b=KepWs871viExpfXYJKP9ucTLI3xBU5duwiTMK+IF4li70ybFsEGGYio0qjVHCEURKdUSBqsXjSO3D3VzYMC+7djPW79FgnvPCBs0rpVN87cAjhuss8G9d7LQzXgQDiRJTD9bTsbqGhw25O4KzqmwW5Yo1eRtsF2EEtRBNu2PclE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750333281; c=relaxed/simple; bh=aZ7rsXK+pQ63res4/2ZuCtjBRras3Ceyq6psDA84uRc=; h=Mime-Version:Content-Type:Date:Message-Id:Cc:Subject:From:To: References:In-Reply-To; b=kjHQ7VMKCKcM+Vo1OsSiAmbowDDVw966xuD4H5yZIAt3J1Hy33J1N1Efp5CF69mya0AWZ5Lwpv+XD51aEX0cDMwWnUj6w1XAxbp1Sndk/Nm0k6C51DSZTKP7neXBXmyQHYL0BCuwnbU+ibop60kpvs25i6EYmf/X7NU1GZN8kVU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=cknow.org; spf=pass smtp.mailfrom=cknow.org; dkim=pass (2048-bit key) header.d=cknow.org header.i=@cknow.org header.b=P92wfx2k; arc=none smtp.client-ip=91.218.175.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=cknow.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=cknow.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=cknow.org header.i=@cknow.org header.b="P92wfx2k" Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cknow.org; s=key1; t=1750333273; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=UlxTUj5Ir+oO3iGWYKmoJ9ycuaXkjQkkYTvLvsQbhwI=; b=P92wfx2kjqVESzvsjtMDG06Ohguto8BeIB3FFHgIMXvCnwAQj49+r7N2yWFEA4MI6m4Q59 shyyFpYG9kEpxklcX2EbTabMIHxV0RJH4z6DOP5bnrtIWy7KlMqWw0cUYlovxX2Y3O0vaJ IDWXdqxT98Ge7B7XTe7HuYVWBLXeC+TscRPYns1xaFP4vdI7g2Itwx2jK7hjZCwm2e4BFd VAsBsm1t5U6vOFMINsb/VMqcX71NMDHyU/QfKac88/qitTP5aYH8q9p7cWoKujwJUj79Nv +TvErZLKsDYOSXadvbF9iz7EaVd7Xrun7+xwJqCDCW3lR6wLDt88+H0abmFNvA== Content-Type: multipart/signed; boundary=b5fff2ebebde679f93dfaf923c9136a97ab4b047f673687733da1b95f36b; micalg=pgp-sha512; protocol="application/pgp-signature" Date: Thu, 19 Jun 2025 13:41:03 +0200 Message-Id: Cc: "Thomas Petazzoni" , , , , Subject: Re: [PATCH v2] arm64: dts: rockchip: Fix the PinePhone Pro DTS' panel description X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: "Diederik de Haas" To: "Olivier Benjamin" , "Heiko Stuebner" , "Rob Herring" , "Krzysztof Kozlowski" , "Conor Dooley" References: <20250619-dtb_fixes-v2-1-abd711d11b67@bootlin.com> <5461462.0VBMTVartN@phil> In-Reply-To: X-Migadu-Flow: FLOW_OUT --b5fff2ebebde679f93dfaf923c9136a97ab4b047f673687733da1b95f36b Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 On Thu Jun 19, 2025 at 12:47 PM CEST, Olivier Benjamin wrote: > On 6/19/25 12:31, Heiko Stuebner wrote: >> Am Donnerstag, 19. Juni 2025, 11:46:15 Mitteleurop=C3=A4ische Sommerzeit= schrieb Diederik de Haas: >>> On Thu Jun 19, 2025 at 7:21 AM CEST, Olivier Benjamin wrote: >>> Thanks for working on upstreaming PPP things :-) >>> > My pleasure. I also have > https://lore.kernel.org/linux-rockchip/20250509-camera-v3-0-dab2772d229a@= bootlin.com/ > pending =3D ) Happy about that too, but I 'happen' to research DSI connected displays (for other devices), so I felt comfortable to chime in with that. I haven't looked at camera stuff yet (and it's not high on my prio list), so hopefully others will chime in for that :-) >>>> Fix a few issues in the panel section of the PinePhone Pro DTS: >>>> - add the second part of the Himax HX8394 LCD panel controller >>>> compatible >>>> - as proposed by Diederik de Haas, reuse the mipi_out and ports >>>> definitions from rk3399-base.dtsi instead of redefining them >>>> - add a pinctrl for the LCD_RST signal for LCD1, derived from >>>> LCD1_RST, which is on GPIO4_D1, as documented on pages 11 >>>> and 16 of the PinePhone Pro schematic >>>> >>>> Signed-off-by: Olivier Benjamin >>=20 >>>> + lcd { >>>> + lcd_reset_pin: reset-pin { >>> >>> I don't know if there's a 'hard rule' for it, but I'd recommend to use >>> ``lcd1_rst_pin: lcd1-rst-pin {`` as that would match the naming from >>> the schematics. I realize that some but not all (other) pinctrl nodes >>> follow that 'rule', but it helps with traceability. >>=20 >> not a "hard" rule, but a strong preference. >> I.e. we want people to ideally be able to just hit search in the >> schematics PDFs for the name they saw in the devicetree. >>=20 >> But following the schematic names, is the general goal. >>=20 > Very fair. I used "lcd_reset" because even the schematic is not super=20 > clear: it uses "LCD_RST" on page 16 and LCD1_RST on pages 11 and 16. AIUI, the GPIO pin (GPIO4_D1) is labeled LCD1_RST and on page 16 you can see that is connected to LCD_RST from BL102-G39-1FR. The definition here is about the GPIO pin, hence LCD1_RST. The other part of my suggestion was related to another 'convention': the name and label/phandle are the same with ``s/-/_/`` (and 'reset-pin' is not specific enough; there are a number of reset pins). Afaic you don't need to mention that I suggested the mipi_out related changes; the reason to do that (unneeded redefinition of already defined things), is. Cheers, Diederik=20 =20 >> If this stays the only suggestion though, I can fix that when >> applying. Or you can send a v3 - up to you :-) >>=20 > I'll correct to lcd1_rst_pin and send a v3 (most likely later today) > >>>> + rockchip,pins =3D <4 RK_PD1 RK_FUNC_GPIO &pcfg_pull_none>; >>>> + }; >>>> + }; >>>> + >>>> leds { >>>> red_led_pin: red-led-pin { >>>> rockchip,pins =3D <4 RK_PD2 RK_FUNC_GPIO &pcfg_pull_none>; >>> >>> Otherwise, >>> >>> Reviewed-by: Diederik de Haas >>> --b5fff2ebebde679f93dfaf923c9136a97ab4b047f673687733da1b95f36b Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYKAB0WIQT1sUPBYsyGmi4usy/XblvOeH7bbgUCaFP3UgAKCRDXblvOeH7b bi9DAP9ZolhYlKXrTz+ChkMa/hViAuhi8CvNP7H+iQUeMfPungEAvGMwNigMNSff 1ZcRaGagcoiWom9lXI7yxhvd5TpmGws= =K75Z -----END PGP SIGNATURE----- --b5fff2ebebde679f93dfaf923c9136a97ab4b047f673687733da1b95f36b--