From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f41.google.com (mail-ej1-f41.google.com [209.85.218.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DC33B295502 for ; Fri, 27 Jun 2025 10:05:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751018712; cv=none; b=XbmnaMk1F5/sznbIyfVglHiRh6YqpC1IGG25l+3TQni0vrhRI/1Wz2mBmcLfOVrpFjYUMzHuZOUoJmFyiXpybT0w1Fu55GS/xmvi3YZuGfKcPKrpoJ2OMWuw8AtBiEynKenTeOMhMBxM5eyDeFbDr2FvchkuUI+ul9QCvO3rp4M= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751018712; c=relaxed/simple; bh=PzodW/i76HLnJ/LNXOIZcjxrEUiZHsILg7HZqKuQym0=; h=Mime-Version:Content-Type:Date:Message-Id:To:Cc:Subject:From: References:In-Reply-To; b=qhBGh9f2QC67/5mtYfxLrgT12WlOJfs0YNEO1UDPbGFQFSqtmhHmCq6bpyBaIwGiYCIIH+GUQPZsd/ql90czKbU4fD0Mp0nEuulzpb6dS4EC7UKaXUlp/Kj7nd+EVVth6O+mAGTTFKLW0IIC/Y4FzbeDR5WkD2pgWl/O3aFBLYM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=fairphone.com; spf=pass smtp.mailfrom=fairphone.com; dkim=pass (2048-bit key) header.d=fairphone.com header.i=@fairphone.com header.b=IMYu/edv; arc=none smtp.client-ip=209.85.218.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=fairphone.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=fairphone.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=fairphone.com header.i=@fairphone.com header.b="IMYu/edv" Received: by mail-ej1-f41.google.com with SMTP id a640c23a62f3a-ae0dad3a179so272447166b.1 for ; Fri, 27 Jun 2025 03:05:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fairphone.com; s=fair; t=1751018709; x=1751623509; darn=vger.kernel.org; h=in-reply-to:references:from:subject:cc:to:message-id:date :content-transfer-encoding:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=anf81smqJchGsOVnXL8fS0CnM4B+sUev4ipz3NBZjL0=; b=IMYu/edvz6R/wTiowuSLY7bajTgBUW6dIUbFr21K2rZsozX0X8MI3GEaj1y5tskZPg J3dtKSBNh/ClN1IjKS0Iz8SGe98n4vQuu9GGsWt6BPQ6nKldsl1NkbqVvANXo035qqKf lXVB8FK6XRcg36jo+XsUP9eTfRBNhHluLrvN86Xk7MJ7fgI/wQKN3fNwCgHUfZbQ1y9a 9cmL4/AoKZKoIxGrIYU3s1pml3BnnxGdOjxlBzP8qmaNk/S3wQnYu1OAGV2XJqEoDNZW X7xEJex3PsfApdsPLEiqhxerwQbMZg4HnHnlAFYbQDmNYVB+KvVsNvkKh4Fpup8ZXafy cemg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751018709; x=1751623509; h=in-reply-to:references:from:subject:cc:to:message-id:date :content-transfer-encoding:mime-version:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=anf81smqJchGsOVnXL8fS0CnM4B+sUev4ipz3NBZjL0=; b=G+Zc3MZF+/W+SxGx2EOBfdFabx18fBSqbYhci1gTRD+ZoW+0kNPF7t6VVivdCGo6ur N7+rxLSjLbJ409xZ9mOh7w59fPyeACEN5etVLshLr33SvVD3gRwqc/lnqwVqgKdlKmeQ WU8VS8WWN985++0HVc/wiKq1iqgoMryYbT7g19CuwkxEd2wABAc+vA1GcAlwyVEpbLPv H7K5QlKs7k7yzJ85MLoXrr/IDsvzTBX/YIYm/JLHHXASs/ICVoglL5pELCbuo7hRJqA/ V4O+5DnnJfDU8zplGTjqfZGoiiCUFvawHZ1RJC+xybfctQ+XfWLpmLLDpVIApIVh6xIA hNXg== X-Forwarded-Encrypted: i=1; AJvYcCXz2+R1Nw3Tk6KjHGlukmeoHFVkWrFvNIb1t2W2NlJoZMXgj3UOSUHUR1Q4mRawLQqZK0BZ7RuaFfyAyFY=@vger.kernel.org X-Gm-Message-State: AOJu0YwdggzNbjk7xXmmQOKkzaj82lDN9Qsi8rlDn5vROiwzJNRVLGlo yGsC4xV7n/3z1JQD88sKfJcv/5Z+Gc/hLuJ7V1tMzwjc2Og1cSEcBWLxGji0wxrnY1k= X-Gm-Gg: ASbGncvbDJ+1sppfOuFWcRxT7xLU21sgP6symAnwIlRXvkZVsfBHc+YOPyXpBDHL1Cr JuoOBv60QBFr374isQZlALPLbAI4Dj1wRaEq0Vsne1ncqkahoBrJRk9z3PkUayGAzondE9JvSjr iw7Ffwegsf4rhH9oXBdnsUeMoO4w5XiIkyF8PXCH0FATFHchZvSU1lhthi0CP8Ol92kN3KPaGZz Omg2jhMkngz9TpLjYF1K4R791ssue/X2ApYkdDP8o1RWWWvoKUbzBf27MYD0ECGuND8bSSoRHbH yfZjYT0mWvbvRJW76dM7+vH9sBLuZnbLt3KDcBDDh+AfqNU0BqO8CSl1sqOXzaATwmPWc1K0uQ6 radhU5QtrVWnd69K921gOlL5x/UBO3VA= X-Google-Smtp-Source: AGHT+IFwWC1PMDQhvOXj2QsK6RpzwF856rVEhA2uY1DKJrMoYsifyAHyLePMov9FHDkbpt1Ej/CUTg== X-Received: by 2002:a17:907:d24:b0:ae0:a1c2:262e with SMTP id a640c23a62f3a-ae35018f138mr209250666b.50.1751018709055; Fri, 27 Jun 2025 03:05:09 -0700 (PDT) Received: from localhost (144-178-202-138.static.ef-service.nl. [144.178.202.138]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ae353ca217asm94148666b.161.2025.06.27.03.05.08 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 27 Jun 2025 03:05:08 -0700 (PDT) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Fri, 27 Jun 2025 12:05:08 +0200 Message-Id: To: "Dmitry Baryshkov" Cc: "Lee Jones" , "Pavel Machek" , "Rob Herring" , "Krzysztof Kozlowski" , "Conor Dooley" , "Fenglin Wu" , "Stephen Boyd" , "Bjorn Andersson" , "Konrad Dybcio" , <~postmarketos/upstreaming@lists.sr.ht>, , , , , Subject: Re: [PATCH 0/3] Add support for PMXR2230 PMIC From: "Luca Weiss" X-Mailer: aerc 0.20.1-0-g2ecb8770224a-dirty References: <20250625-sm7635-pmxr2230-v1-0-25aa94305f31@fairphone.com> <6zut6hiwig4qanrmloqvibx4tmpb6iv23s3hp7bb4ja6jzzia3@wnre6i3mukbp> In-Reply-To: <6zut6hiwig4qanrmloqvibx4tmpb6iv23s3hp7bb4ja6jzzia3@wnre6i3mukbp> On Wed Jun 25, 2025 at 11:03 PM CEST, Dmitry Baryshkov wrote: > On Wed, Jun 25, 2025 at 05:01:29PM +0200, Luca Weiss wrote: >> On Wed Jun 25, 2025 at 4:25 PM CEST, Dmitry Baryshkov wrote: >> > On Wed, Jun 25, 2025 at 11:18:36AM +0200, Luca Weiss wrote: >> >> The PMXR2230 PMIC is used in conjuction with SM7635. Add binding docs >> >> and the devicetree description for it. >> > >> > >> > Please use PM7550 instead. >>=20 >> I'm happy to not follow downstream naming conventions if being told, but >> do you have any details whether PMXR2230 =3D=3D PM7550, or PM7550 is jus= t >> another SW-compatible PMIC as PMXR2230. > > It is PM7550. Ok, will update in v2. > >>=20 >> Also we already have qcom,pmxr2230-gpio upstream, so that would need to >> get updated for the PM7550 name. > > No, leave it be. We should not change existing compats for no reason. The compatible is not used in upstream dts though, and cleaning up some old naming for the PMIC would be good, no? But I can leave it for now, and we can potentially take care of it later. Regards Luca > >>=20 >> Regards >> Luca >>=20 >> > >> >>=20 >> >> Signed-off-by: Luca Weiss >> >> --- >> >> Luca Weiss (3): >> >> dt-bindings: leds: qcom,spmi-flash-led: Add PMXR2230 >> >> dt-bindings: mfd: qcom-spmi-pmic: Document PMXR2230 PMIC >> >> arm64: dts: qcom: Add PMXR2230 PMIC >> >>=20 >> >> .../bindings/leds/qcom,spmi-flash-led.yaml | 1 + >> >> .../devicetree/bindings/mfd/qcom,spmi-pmic.yaml | 1 + >> >> arch/arm64/boot/dts/qcom/pmxr2230.dtsi | 63 ++++++++++++= ++++++++++ >> >> 3 files changed, 65 insertions(+) >> >> --- >> >> base-commit: 19272b37aa4f83ca52bdf9c16d5d81bdd1354494 >> >> change-id: 20250620-sm7635-pmxr2230-ee55a86a8c2b >> >>=20 >> >> Best regards, >> >> --=20 >> >> Luca Weiss >> >>=20 >>=20