From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f52.google.com (mail-ej1-f52.google.com [209.85.218.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C1EF42D8796 for ; Fri, 27 Jun 2025 12:54:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751028864; cv=none; b=baKYkuj2zwq9m+S7PpVgb8KXaLnh5nt1BwwUdFXrujRvTowpVYXYkXia9Aa3K6pPUbWVCjb+biUzPfpCGHceW0+aINQ+E3kqLb7Q7tPXc4mQMY60cJtIxQ5dQA6ZgHbgFCiuekNjQX6Z825FEvVy7t473cBBJRfUBLu0PTcHBFI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751028864; c=relaxed/simple; bh=Du0b+TeI3ZTwjyWt4pvKm1qINJzsD733zYyEarZI+ak=; h=Mime-Version:Content-Type:Date:Message-Id:Cc:Subject:From:To: References:In-Reply-To; b=tCMrUqoYoH7TtmQplGi17quL1QIjTz+WGjBh6BdNeWHr29S6w7IVZ4oXn79WF6p81f0vfNpNZrbKZBUANb44VuaHG8uLlJvpWF2W8c5gDG4OSnGpVmeOPfVr+2JE/vSy2FpaqgiLIv7cr4kQd3GgHHSoSTfLu9v8M4uxmRC9WVE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=fairphone.com; spf=pass smtp.mailfrom=fairphone.com; dkim=pass (2048-bit key) header.d=fairphone.com header.i=@fairphone.com header.b=kwKZnHLI; arc=none smtp.client-ip=209.85.218.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=fairphone.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=fairphone.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=fairphone.com header.i=@fairphone.com header.b="kwKZnHLI" Received: by mail-ej1-f52.google.com with SMTP id a640c23a62f3a-ae0de1c378fso229183366b.3 for ; Fri, 27 Jun 2025 05:54:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fairphone.com; s=fair; t=1751028861; x=1751633661; darn=vger.kernel.org; h=in-reply-to:references:to:from:subject:cc:message-id:date :content-transfer-encoding:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=+nhdHiI1mmifgnWppwRjST41ES3N+612bitCEUi1kbU=; b=kwKZnHLIudBDOYp0TsE/PcyW4o/D77UX8c/+mzMnR9hyQgmWVSOfrmWp6UiPLCLiNl JsOFHN8WY54Q7tW07j/1I1TVgdVIT8byUpmJBWXhmcQh0SEqoemGNCr8cYAm0aylCGQj uXal0qpCzCM2WyTFSvFazoJ+kVrCGdSZIegRoKdAiBRVxWq+Y8a7m5lsRlmJ66zHr0n1 cJ/b1p32A+S6Jin1xysI0ynRFZPoqq0N9WiGHa53/uq1i+VP+Pr9FdCRTKeSqieXl9um IelpFnI/oW9EET6O7isLuWYfHt2/S19lFOlJTaZaRRo//9ZnKXj8tH9NvmkuAeHjaFfO gOiA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751028861; x=1751633661; h=in-reply-to:references:to:from:subject:cc:message-id:date :content-transfer-encoding:mime-version:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=+nhdHiI1mmifgnWppwRjST41ES3N+612bitCEUi1kbU=; b=BTdmUXPPf9S8Lqewc1r4FwiGTm/udkXJztC5FDVtNfbknB1aCW3cySx8cvzGpiuK2g LMVzJZ6131IrCumivN2KDuC2jc24/FdZozCjyyIJTglIAib3ywenLPXJrsj914Yvsfit aOt71T4dhNPaT53m9AkTsGgXJ7bZxImvAz8nZY9twcZHXPkrkWOhqbpAp0rdy7F/NmV3 BUnr7wFhhCa5TvujYh3SHIHpxEY6cz+OIHvEnkjhl3dmI66x5+/fIY/z+YlAqf2QWkiU W9FHwg5fglYvDGMy2Eg9/ncxx7tQIuza8EfCuG2701V5tSUgKIaJi7WeWNM72Sbibvwj ZIew== X-Forwarded-Encrypted: i=1; AJvYcCVUF2WwYoGHfHyIiYasLJV+WhapxAtwFmGZQq212RilbGfirN/taiptCoJ59YQqrPq1aeEjJ1MR6FQrHEA=@vger.kernel.org X-Gm-Message-State: AOJu0Yz6whwNy/I6Hws4TzEzOmv846pBaDKd6tPCyCHBZlVvVyTPy+kx ehWFdZxfoHcjiWXShgWcD8NlMBhz2bcPME22jOtAsmUl+9F/YvzL6folNXVyPGD8bpU= X-Gm-Gg: ASbGncuqd3le3DqW2azYZ1XelQrdbHP6UzqD7AG4KJDe+5gVWe0f3afE0E+/ayzcVjU imf1RNfHLrwObn8APuD0iHTh207oyVvpPcwwAPTVteVA3IGxTy4hHn8A6eCvtR29TlUVWb/Ww5i UKAWwnhLGsaFngL3IWONvdTjpo8N/ibjtw0b6WDkjqyXcekw99ZD79yBT1HVohcAnbrjygpBqHv F9WiLflCAGavUc7dEylSX/puBFPiarJhzGourNMmu0nkAe8Yzg0Tq2h+qI1JCrSrPLZL+PzKcIR Qm/LQqq98/xQITd7sSWeRTT8Lxd1JRnYrPFBMRPbliw9pL0mKd6PyEj9LSLpgMygDgPPycR68OX MZZyDKnGmiBa5dv699F5o6Rre0fOGgEM= X-Google-Smtp-Source: AGHT+IFsbMB++QIubPPkEjUAaoqBr8kfEWyj7SeiVTthlBeTY5ebiAvDyXm55/dHcIfRL97TTYOl8A== X-Received: by 2002:a17:907:3c89:b0:ad2:417b:2ab5 with SMTP id a640c23a62f3a-ae3501b9be9mr278351166b.60.1751028860934; Fri, 27 Jun 2025 05:54:20 -0700 (PDT) Received: from localhost (144-178-202-138.static.ef-service.nl. [144.178.202.138]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ae353659efbsm118554866b.46.2025.06.27.05.54.20 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 27 Jun 2025 05:54:20 -0700 (PDT) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Fri, 27 Jun 2025 14:54:20 +0200 Message-Id: Cc: <~postmarketos/upstreaming@lists.sr.ht>, , , , , Subject: Re: [PATCH 3/3] arm64: dts: qcom: Add PMXR2230 PMIC From: "Luca Weiss" To: "Konrad Dybcio" , "Lee Jones" , "Pavel Machek" , "Rob Herring" , "Krzysztof Kozlowski" , "Conor Dooley" , "Fenglin Wu" , "Stephen Boyd" , "Bjorn Andersson" , "Konrad Dybcio" X-Mailer: aerc 0.20.1-0-g2ecb8770224a-dirty References: <20250625-sm7635-pmxr2230-v1-0-25aa94305f31@fairphone.com> <20250625-sm7635-pmxr2230-v1-3-25aa94305f31@fairphone.com> In-Reply-To: On Wed Jun 25, 2025 at 3:20 PM CEST, Konrad Dybcio wrote: > On 6/25/25 11:18 AM, Luca Weiss wrote: >> Add a dts for the PMIC used e.g. with SM7635 devices. >>=20 >> Signed-off-by: Luca Weiss >> --- >> arch/arm64/boot/dts/qcom/pmxr2230.dtsi | 63 +++++++++++++++++++++++++++= +++++++ >> 1 file changed, 63 insertions(+) >>=20 >> diff --git a/arch/arm64/boot/dts/qcom/pmxr2230.dtsi b/arch/arm64/boot/dt= s/qcom/pmxr2230.dtsi >> new file mode 100644 >> index 0000000000000000000000000000000000000000..a7650f3230c01422b76ef78e= 897e5e7ae2f20cc6 >> --- /dev/null >> +++ b/arch/arm64/boot/dts/qcom/pmxr2230.dtsi >> @@ -0,0 +1,63 @@ >> +// SPDX-License-Identifier: BSD-3-Clause >> +/* >> + * Copyright (c) 2025, Luca Weiss >> + */ >> + >> +#include >> +#include >> + >> +/ { >> + thermal-zones { >> + pmxr2230_thermal: pmxr2230-thermal { >> + polling-delay-passive =3D <100>; >> + >> + thermal-sensors =3D <&pmxr2230_temp_alarm>; >> + >> + trips { >> + pmxr2230_trip0: trip0 { >> + temperature =3D <95000>; >> + hysteresis =3D <0>; >> + type =3D "passive"; >> + }; >> + >> + pmxr2230_crit: pmxr2230-crit { > > This name is "meh", please change to tripN > >> + temperature =3D <115000>; > > Unless there's some actual electrical/physical SKU differences, > downstream lists 145C as critical for a PMIC carrying the same > name [ 0.085990] spmi-temp-alarm c400000.spmi:pmic@1:temp-alarm@a00: No ADC i= s configured and critical temperature 145000 mC is above the maximum stage = 2 threshold of 125000 mC! Configuring stage 2 shutdown at 125000 mC. Same for the PMIV0104: [ 0.086556] spmi-temp-alarm c400000.spmi:pmic@7:temp-alarm@a00: No ADC i= s configured and critical temperature 145000 mC is above the maximum stage = 2 threshold of 125000 mC! Configuring stage 2 shutdown at 125000 mC. What shall I do? Regards Luca > > with that: > > Reviewed-by: Konrad Dybcio > > Konrad