From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f42.google.com (mail-ej1-f42.google.com [209.85.218.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6A52D2E8882 for ; Fri, 27 Jun 2025 14:44:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751035499; cv=none; b=QYSEkAfTbmnEqF0knxr6uKgMJ3luYViVPS87fEmOSDzCtj/S9iMKa4EmDTa5ZwiANos2VYGDhgazn/zhKuhhbd1KFdChPeATSSvW+QjgU3f1Dp0hsKe0jACRQEVaQ40BaEGIR59Z8Q8yKL7YIPYimBV+i+uSaAglvY9TPbp58uU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751035499; c=relaxed/simple; bh=NTyBybTY3lY2he6PEfFmBwj+NT8vhjacNbp9rj9qt38=; h=Mime-Version:Content-Type:Date:Message-Id:Cc:Subject:From:To: References:In-Reply-To; b=DpQg+Q6X9g7M/3tCWPn5iqiWyGJJGPbhovtkDHNcePOQhUWoDimVrTUc5DE4qN3yKV0qFseZuoBziDhGH/fIihRTJNVP+s+a18sesNrM6yHYJPYCxNZKwxfjX5uOe/zj4rf6uaPBzr+wAls3UV827jCZ/G25S2P4iMIJm57ltc0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=fairphone.com; spf=pass smtp.mailfrom=fairphone.com; dkim=pass (2048-bit key) header.d=fairphone.com header.i=@fairphone.com header.b=ZUBAtAut; arc=none smtp.client-ip=209.85.218.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=fairphone.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=fairphone.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=fairphone.com header.i=@fairphone.com header.b="ZUBAtAut" Received: by mail-ej1-f42.google.com with SMTP id a640c23a62f3a-ae0dffaa8b2so312561866b.0 for ; Fri, 27 Jun 2025 07:44:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fairphone.com; s=fair; t=1751035496; x=1751640296; darn=vger.kernel.org; h=in-reply-to:references:to:from:subject:cc:message-id:date :content-transfer-encoding:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=dlrE0erJ+soHw5jj+VujnDEwpvOXS6zY03LMDq5ZPE4=; b=ZUBAtAut7ZN3rT54nfNKJBXCWQlYD5A0DXRsze/J1j0k9cqeEXU4bqOPdu3nErY3wm igjGPhsCqpEggr+PhboSwTa4wbrGXMTfDmz3M8lrmEOsT+YpmyR+wtsl4f85qvO+dOX8 8PX8lr0CQBmEhW9JeWlbk71oatZ/19LRjApxsJPzqVHJS9TSIVHIMPUqDQsLTKh/cggN Iv6ddkULBT/VotnfeM4r+rfoxltG9Lflj1ZyY7msC7+IAAOtxh0pob5uzay8zB31/gCY ErWR3/BJYEElDAzXP8q0UOMW4taS7FTymtR95O0gEiohaX+TPl20wW6Wx2E9jcysdVcH 3rvA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751035496; x=1751640296; h=in-reply-to:references:to:from:subject:cc:message-id:date :content-transfer-encoding:mime-version:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=dlrE0erJ+soHw5jj+VujnDEwpvOXS6zY03LMDq5ZPE4=; b=GaSr+CA+OxCU+sZ1mkpblpw53oUL1NPFQn0mncTtzSfO0InZfZT4GE5tpzvtU3yUa6 EnP2Y8lTDkiYY7vCpQ1+LVN2VBvf/QqYsyQUqQGz63fifcjCryLBA5aAJ2eUh+/jaDtB Q1QQzSuGbmHTaLH+7eo0NBgSUwPzZhGiovf1QG7kvgP2h13tG26IypuD+fJErjot2UIc VWPdv02oIiLznc7X8wfQ0fodPH972nzBeNPMc9Qx3hbnCE4lPW3TK1wmj6h8HP4Bc7x0 pzG2nZQwYL/0sbJBggch5hVe5VKGRhM7gEq/KRy/rq8Q8plAZ8f0RQYAN/qNunA+QtS5 1sjQ== X-Forwarded-Encrypted: i=1; AJvYcCXxxnf0BjlTKSq7FZe29MevBg3r5Zq/fzK8D1ITjTsgveAjtdUAKjzAXwVr2c8A7ataFFOhHGs5XJBDMtQ=@vger.kernel.org X-Gm-Message-State: AOJu0YyFVBD53qJrbUmjRiAj434TJ3fy+uc9RowWD7FxYDJnmzio7qha QzZGxcKDZlaRzUoVnNE+fjAHxhHcx3o9qEHz2Lw+iXJPNMoZyONFrtTiL1StV9FHnJM= X-Gm-Gg: ASbGncvMXk358SZxFravFmN6zPYuGXoWRm60OrFADJCqOikDjp0CHYu6rdVmqFE/Voq 2e9M1EWJey88ae6dnocSOsTZdeuE5gL2jkK0+8zvG2BoEaxgeo2MKpA+qZyJTsH2tk6U8j8t1DG fn6PylpnO/xCH27wzoSVOMQtPFgaepQQO0y0zj54C7DjGF7RbVGOCZ2sBHRK2plrV5z1W6q20KH EdC5FZFzHCbxvnnGuAyXsi2LjgM+yyry4bOyS7vLXHJBtiyauz2n40GMAS1NbhyO5MEXOEpo1HL ERlQpWECvyOUVnFK/10B7nhOaO/vjGYkCtskUGqGmQbV6DkHuJ9+WUe3yYBjlEuQ89Qgd9h7ZE/ vuVNEBwTWPlC6baD0RLJ04EvqXuvxzHg= X-Google-Smtp-Source: AGHT+IGA2mn71bXWbYFILa0TCGmj9njdVsOBKtFNFMdVa00gcI2whAz4/eBu0LzWjRNNEejwRdZugA== X-Received: by 2002:a17:907:8691:b0:ad8:9b5d:2c1c with SMTP id a640c23a62f3a-ae34fd8cb6cmr354056566b.19.1751035495488; Fri, 27 Jun 2025 07:44:55 -0700 (PDT) Received: from localhost (144-178-202-138.static.ef-service.nl. [144.178.202.138]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ae35363b35dsm137152566b.13.2025.06.27.07.44.54 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 27 Jun 2025 07:44:55 -0700 (PDT) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Fri, 27 Jun 2025 16:44:54 +0200 Message-Id: Cc: <~postmarketos/upstreaming@lists.sr.ht>, , , , , , , , , , Subject: Re: [PATCH 14/14] arm64: dts: qcom: Add The Fairphone (Gen. 6) From: "Luca Weiss" To: "Konrad Dybcio" , "Will Deacon" , "Robin Murphy" , "Joerg Roedel" , "Rob Herring" , "Krzysztof Kozlowski" , "Conor Dooley" , "Rafael J. Wysocki" , "Viresh Kumar" , "Manivannan Sadhasivam" , "Herbert Xu" , "David S. Miller" , "Vinod Koul" , "Bjorn Andersson" , "Konrad Dybcio" , "Robert Marko" , "Das Srinagesh" , "Thomas Gleixner" , "Jassi Brar" , "Amit Kucheria" , "Thara Gopinath" , "Daniel Lezcano" , "Zhang Rui" , "Lukasz Luba" , "Ulf Hansson" X-Mailer: aerc 0.20.1-0-g2ecb8770224a-dirty References: <20250625-sm7635-fp6-initial-v1-0-d9cd322eac1b@fairphone.com> <20250625-sm7635-fp6-initial-v1-14-d9cd322eac1b@fairphone.com> <4200b3b8-5669-4d5a-a509-d23f921b0449@oss.qualcomm.com> <6d4e77b3-0f92-44dd-b9b0-3129a5f3785b@oss.qualcomm.com> In-Reply-To: <6d4e77b3-0f92-44dd-b9b0-3129a5f3785b@oss.qualcomm.com> On Fri Jun 27, 2025 at 4:34 PM CEST, Konrad Dybcio wrote: > On 6/27/25 1:33 PM, Luca Weiss wrote: >> On Wed Jun 25, 2025 at 4:38 PM CEST, Konrad Dybcio wrote: >>> On 6/25/25 11:23 AM, Luca Weiss wrote: >>>> Add a devicetree for The Fairphone (Gen. 6) smartphone, which is based >>>> on the SM7635 SoC. >>> >>> [...] >>> >>>> + /* Dummy panel for simple-framebuffer dimension info */ >>>> + panel: panel { >>>> + compatible =3D "boe,bj631jhm-t71-d900"; >>>> + width-mm =3D <65>; >>>> + height-mm =3D <146>; >>>> + }; >>> >>> I haven't ran through all the prerequisite-xx-id, but have >>> you submitted a binding for this? >>=20 >> Actually not, kind of forgot about this. I believe I can create a >> (mostly?) complete binding for the panel, but this simple description >> for only width-mm & height-mm will differ from the final one, which will >> have the DSI port, pinctrl, reset-gpios and various supplies. >>=20 >> I think I'll just drop it from v2 and keep it locally only, to get the >> simpledrm scaling right. > > Yeah I think that'd be best in general Ack > >>=20 >>> >>> [...] >>> >>>> + reserved-memory { >>>> + /* >>>> + * ABL is powering down display and controller if this node is >>>> + * not named exactly "splash_region". >>>> + */ >>>> + splash_region@e3940000 { >>>> + reg =3D <0x0 0xe3940000 0x0 0x2b00000>; >>>> + no-map; >>>> + }; >>>> + }; >>> >>> :/ maybe we can convince ABL not to do it.. >>=20 >> Yes, we talked about that. I will look into getting "splash-region" and >> "splash" also into the ABL (edk2) build for the phone. Still won't >> resolve that for any other brand of devices. > > Gotta start small! Maybe framebuffer@ would be more """idiomatic""" > but potayto/potahto I'll try and work on the edk2 patch early next week, so if you tell me soon, I can add some other name. I don't want to include 500 different names though. :) > >>=20 >>> >>> [...] >>> >>>> + vreg_l12b: ldo12 { >>>> + regulator-name =3D "vreg_l12b"; >>>> + /* >>>> + * Skip voltage voting for UFS VCC. >>>> + */ >>> >>> Why so? >>=20 >> From downstream: >>=20 >> /* >> * This is for UFS Peripheral,which supports 2 variants >> * UFS 3.1 ,and UFS 2.2 both require different voltages. >> * Hence preventing voltage voting as per previous targets. >> */ >>=20 >> I haven't (successfully) brought up UFS yet, so I haven't looked more >> into that. >>=20 >> The storage on FP6 is UFS 3.1 though fwiw. > > Hm.. can you check what debugfs says about the voltage at runtime > (on downstream)? I'd assume you won't be shipping two kinds anyway This is very likely just from Qualcomm's baseline. > > [...] > >>>> +&pm8550vs_d { >>>> + status =3D "disabled"; >>>> +}; >>>> + >>>> +&pm8550vs_e { >>>> + status =3D "disabled"; >>>> +}; >>>> + >>>> +&pm8550vs_g { >>>> + status =3D "disabled"; >>>> +}; >>> >>> Hm... perhaps we should disable these by deafult >>=20 >> Do you want me to do this in this patchset, or we clean this up later at >> some point? I'd prefer not adding even more dependencies to my patch >> collection right now. > > I can totally hear that.. > > Let's include it in this patchset, right before SoC addition > I don't think there's any pm8550vs users trying to get merged in > parallel so it should be OK Okay, can do. Disable all of them (_c, _d, _e, _g), and re-enable them in current users? I assume there might also be boards that only have e.g. _d and no _c. > > [...] > >>>> +&usb_1 { >>>> + dr_mode =3D "otg"; >>>> + >>>> + /* USB 2.0 only */ >>> >>> Because there's no usb3phy description yet, or due to hw design? >>=20 >> HW design. Funnily enough with clk_ignore_unused this property is not >> needed, and USB(2.0) works fine then. Just when (I assume) the USB3 >> clock is turned off which the bootloader has enabled, USB stops working. > > The USB controller has two possible clock sources: the PIPE_CLK that > the QMPPHY outputs, or the UTMI clock (qcom,select-utmi-as-pipe-clk). So okay like this for you, for a USB2.0-only HW? > > Because you said there's no USB3, I'm assuming DP-over-Type-C won't > be a thing either? :( Yep. I'd have preferred USB3+DP as well since it's actually quite cool to have with proper Linux. On Android, at least on older versions it's barely usable imo. Can't even properly watch videos on the big screen with that SW stack. Regards Luca > > Konrad