From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f44.google.com (mail-ed1-f44.google.com [209.85.208.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2D694254846 for ; Mon, 30 Jun 2025 10:21:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751278902; cv=none; b=kMVCGtKrr6pcfyS+955ufHMM5EzSMj1IAqnntLvdXEi3Lrje/8NvYJyL7fwW+bSWwcga5OHSHML+g5cFEGt3LEn4LpPmByvn1IbWrBmnS8THd7PuBPxYKgdnthRl+DFRKpfB7QzEmoLr+v7egmZvyqdlQldXv3BYG5t8m+Ev9Tw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751278902; c=relaxed/simple; bh=6BYE8AWJQLw8WAxO3Q5aBUTeX661u26mmGmL2fLnCZI=; h=Mime-Version:Content-Type:Date:Message-Id:Cc:Subject:From:To: References:In-Reply-To; b=ZMWte7gXrGUqnavwgketK7hnIDbExh7q2oki11a66LE2f4YHBKu7r6zsvOtsSr7qa+q8pwN9/G47kSDHNun7FRn/BLvFh4O9OMkUM4vTKnj6oqc9WoJAu6fhK348Zy/savK5e+cz1NnnMcAB0RIFBNeAVlnbXegcAUBW7TruN40= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=fairphone.com; spf=pass smtp.mailfrom=fairphone.com; dkim=pass (2048-bit key) header.d=fairphone.com header.i=@fairphone.com header.b=IrZueZJ4; arc=none smtp.client-ip=209.85.208.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=fairphone.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=fairphone.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=fairphone.com header.i=@fairphone.com header.b="IrZueZJ4" Received: by mail-ed1-f44.google.com with SMTP id 4fb4d7f45d1cf-60789b450ceso3877594a12.2 for ; Mon, 30 Jun 2025 03:21:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fairphone.com; s=fair; t=1751278898; x=1751883698; darn=vger.kernel.org; h=in-reply-to:references:to:from:subject:cc:message-id:date :content-transfer-encoding:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=91/ZncbDlmcGCt22EAMRhuZKL6uaG/hY8UyZ2Q+pYCo=; b=IrZueZJ4qgDMos5cOw6vsmAKPNI7cL5oHlBxR9UC1YhL+Gik/jTsoOe6XDscbMCl/D m0b1kr5wj7n3L0V7y6Gu2taGzuNze2Trz/4F1hoehV3UkaCRyOYZv4FTAZrixGoXDCAL Ra1lqJVB3V41Bag3if4dM7UPHCeXCsx+seRMCn4xlr5ZNTzn5tZzCD1+ZJgfiE58pMj4 k6y6iBv4TNPQowcdRpGeLnYeAWQjQ2JzHgL8eT1PYbAbBm4rGdx1FUt/OygzgsenUAeb 75KzQYafl73kX3Oa9A+8PbNa0dpos0iA2Aa65Cxrg2FkYdFlf78aMhT5bCYVDMC6TetI mL7A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751278898; x=1751883698; h=in-reply-to:references:to:from:subject:cc:message-id:date :content-transfer-encoding:mime-version:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=91/ZncbDlmcGCt22EAMRhuZKL6uaG/hY8UyZ2Q+pYCo=; b=vLaVpzdmubfXv1i7ntTywtISESO0kEH0HlCTSDyPmLEfxKQYZ86f0ERPu/D98gM5Gu j6Gk1ggNDoEwa6b2tvkxQOc0IEfzccz+sgKMy1mpLqdU9ty3Dy+g0nC9pKb5sqwl4OAQ VHQ8JMuCmqBBU9jovxcmaXVmZO0vgoQrfQ9Axu5Ikcc1I18NlwRBC2mPWijhNAnnNwhe c22ZiSo547PEy5hH7aZe/OAHNd5GiJrCfIeUk5t6Z15ZC9N7/ylooqDr8NW2Z/FJ7Br+ e7nop1Xp7/vzDqXsJVAxadfqvdHb00aVRUjaOuRzD5i4Op0zk/4yM4+qfGC71pc0yeSA weuA== X-Forwarded-Encrypted: i=1; AJvYcCUtTou2jB8VjM8ZGcAuge2KLFniNNA2I9PB9PjtzAOeyZgQWNCMtfjBaAEGTdFITxALqz090xOyUJ0XPII=@vger.kernel.org X-Gm-Message-State: AOJu0Ywt0C4aVNwprm+kF53thHQjBpKJpfjRuz3Yk8zeBvcyEwjS/0sE w/1fGOKQP6ZJ8FeWX556YK9jFCVeM+KaUFyqlzl5nTGUKnO60lUsHLhXKEoA9jyuIqc= X-Gm-Gg: ASbGncvV/+u/HZeNyy5Nckuigay1LIq3yHK5FAMO3WwPMdQ0Rqa/t6TmuAp5+AjBIxg h52N5xli/oaJTDeb607x7QUKzFq3NBSH0N15dyDCqRpRzyX7loLwFY1Bw3K4wMNGZu1rwTtmIPI d3WKOzKJ9DrGVtHj3SQ595BKoW+e5jJbkZJiN+9vZ63LDLrFR4lTvkFXOZ93NM6O3h08pM7R15B et5E4StA0fDAZs+112AwnNgWeG+eL3Os3TzIL4HqVwCLYpO9k+Qagrd4ypAcPiIULbXyIEv5rom sBXsP5OfMe7Pw+ddVGlW9du9Fag2ccpqq3pKnpzdlwiCgr402Kz0dbHTvVwOxs3bYkTgZCCmvkf ti63d+ulZSI7Fz7jXL6wovisYWmHzQ80r9l0ZrDIG1uU/ORwb3y53KFDUw8bpP6gwnjUWX30= X-Google-Smtp-Source: AGHT+IG0udIx5/vSjab4jTXQgQOixHxgW8J50sJp+ilVqsU6WQ7uEmPrf6nFFV5tvDzy3dhkra701g== X-Received: by 2002:a17:907:9691:b0:ae0:c6fb:2140 with SMTP id a640c23a62f3a-ae3500f374emr1085087666b.32.1751278898278; Mon, 30 Jun 2025 03:21:38 -0700 (PDT) Received: from localhost (2001-1c00-3b8a-ea00-c4de-d39d-05f4-c77a.cable.dynamic.v6.ziggo.nl. [2001:1c00:3b8a:ea00:c4de:d39d:5f4:c77a]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ae35365a95esm649858666b.59.2025.06.30.03.21.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 30 Jun 2025 03:21:37 -0700 (PDT) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Mon, 30 Jun 2025 12:21:36 +0200 Message-Id: Cc: <~postmarketos/upstreaming@lists.sr.ht>, , , , , , , , , , Subject: Re: [PATCH 14/14] arm64: dts: qcom: Add The Fairphone (Gen. 6) From: "Luca Weiss" To: "Konrad Dybcio" , "Will Deacon" , "Robin Murphy" , "Joerg Roedel" , "Rob Herring" , "Krzysztof Kozlowski" , "Conor Dooley" , "Rafael J. Wysocki" , "Viresh Kumar" , "Manivannan Sadhasivam" , "Herbert Xu" , "David S. Miller" , "Vinod Koul" , "Bjorn Andersson" , "Konrad Dybcio" , "Robert Marko" , "Das Srinagesh" , "Thomas Gleixner" , "Jassi Brar" , "Amit Kucheria" , "Thara Gopinath" , "Daniel Lezcano" , "Zhang Rui" , "Lukasz Luba" , "Ulf Hansson" X-Mailer: aerc 0.20.1-0-g2ecb8770224a-dirty References: <20250625-sm7635-fp6-initial-v1-0-d9cd322eac1b@fairphone.com> <20250625-sm7635-fp6-initial-v1-14-d9cd322eac1b@fairphone.com> <4200b3b8-5669-4d5a-a509-d23f921b0449@oss.qualcomm.com> <6d4e77b3-0f92-44dd-b9b0-3129a5f3785b@oss.qualcomm.com> <3fbae47b-d20d-426b-a967-b584e32b8c6e@oss.qualcomm.com> In-Reply-To: <3fbae47b-d20d-426b-a967-b584e32b8c6e@oss.qualcomm.com> On Fri Jun 27, 2025 at 5:34 PM CEST, Konrad Dybcio wrote: > On 6/27/25 4:44 PM, Luca Weiss wrote: >> On Fri Jun 27, 2025 at 4:34 PM CEST, Konrad Dybcio wrote: >>> On 6/27/25 1:33 PM, Luca Weiss wrote: >>>> On Wed Jun 25, 2025 at 4:38 PM CEST, Konrad Dybcio wrote: >>>>> On 6/25/25 11:23 AM, Luca Weiss wrote: >>>>>> Add a devicetree for The Fairphone (Gen. 6) smartphone, which is bas= ed >>>>>> on the SM7635 SoC. >>>>> >>>>> [...] >>>>> >>>>>> +&pm8550vs_d { >>>>>> + status =3D "disabled"; >>>>>> +}; >>>>>> + >>>>>> +&pm8550vs_e { >>>>>> + status =3D "disabled"; >>>>>> +}; >>>>>> + >>>>>> +&pm8550vs_g { >>>>>> + status =3D "disabled"; >>>>>> +}; >>>>> >>>>> Hm... perhaps we should disable these by deafult >>>> >>>> Do you want me to do this in this patchset, or we clean this up later = at >>>> some point? I'd prefer not adding even more dependencies to my patch >>>> collection right now. >>> >>> I can totally hear that.. >>> >>> Let's include it in this patchset, right before SoC addition >>> I don't think there's any pm8550vs users trying to get merged in >>> parallel so it should be OK >>=20 >> Okay, can do. Disable all of them (_c, _d, _e, _g), and re-enable them >> in current users? I assume there might also be boards that only have >> e.g. _d and no _c. > > I suppose it's only fair to do so, in line with > > d37e2646c8a5 ("arm64: dts: qcom: x1e80100-pmics: Enable all SMB2360 separ= ately") Sounds good, I've prepared this change for v2. > > >>>>>> +&usb_1 { >>>>>> + dr_mode =3D "otg"; >>>>>> + >>>>>> + /* USB 2.0 only */ >>>>> >>>>> Because there's no usb3phy description yet, or due to hw design? >>>> >>>> HW design. Funnily enough with clk_ignore_unused this property is not >>>> needed, and USB(2.0) works fine then. Just when (I assume) the USB3 >>>> clock is turned off which the bootloader has enabled, USB stops workin= g. >>> >>> The USB controller has two possible clock sources: the PIPE_CLK that >>> the QMPPHY outputs, or the UTMI clock (qcom,select-utmi-as-pipe-clk). >>=20 >> So okay like this for you, for a USB2.0-only HW? > > Yeah, maybe change the comment to something like: > > /* USB 2.0 only (RX/TX lanes physically not routed) */ > > to avoid getting this question asked again Ack /* USB 2.0 only, HW does not support USB 3.x */ Regards Luca > >>> Because you said there's no USB3, I'm assuming DP-over-Type-C won't >>> be a thing either? :( >>=20 >> Yep. I'd have preferred USB3+DP as well since it's actually quite cool >> to have with proper Linux. On Android, at least on older versions it's >> barely usable imo. Can't even properly watch videos on the big screen >> with that SW stack. > > Bummer! Not something we can change though :( > > Konrad