From: "Luca Weiss" <luca.weiss@fairphone.com>
To: "Krzysztof Kozlowski" <krzk@kernel.org>
Cc: "Bjorn Andersson" <andersson@kernel.org>,
"Mathieu Poirier" <mathieu.poirier@linaro.org>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Manivannan Sadhasivam" <mani@kernel.org>,
<~postmarketos/upstreaming@lists.sr.ht>,
<phone-devel@vger.kernel.org>, <linux-arm-msm@vger.kernel.org>,
<linux-remoteproc@vger.kernel.org>, <devicetree@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 1/3] dt-bindings: remoteproc: qcom,sm8350-pas: document SM7635 MPSS & WPSS
Date: Tue, 01 Jul 2025 12:12:07 +0200 [thread overview]
Message-ID: <DB0MZCUM41RA.7Z6461I531VD@fairphone.com> (raw)
In-Reply-To: <20250701-melodic-courageous-mussel-0bed22@krzk-bin>
Hi Krzysztof,
On Tue Jul 1, 2025 at 10:12 AM CEST, Krzysztof Kozlowski wrote:
> On Fri, Jun 27, 2025 at 08:55:42AM +0200, Luca Weiss wrote:
>> @@ -91,6 +93,7 @@ allOf:
>> properties:
>> compatible:
>> enum:
>> + - qcom,sm7635-mpss-pas
>> - qcom,sm8350-mpss-pas
>> - qcom,sm8450-mpss-pas
>> then:
>> @@ -142,6 +145,22 @@ allOf:
>> - const: cx
>> - const: mxc
>>
>> + - if:
>> + properties:
>> + compatible:
>> + enum:
>> + - qcom,sm7635-wpss-pas
>
> Everything fits better sm6350 and no need for new if:then: entry, at
> least it looks like.
True, that seems to work fine as well. I can add it to the
qcom,sm6350-pas.yaml bindings instead of sm8350 in the next version.
To be honest, I don't quite understand what the concept behind the
different PAS bindings are, when an SoC should get a new .yaml file, and
when to add to an existing one.
Regards
Luca
>
> Best regards,
> Krzysztof
next prev parent reply other threads:[~2025-07-01 10:12 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-27 6:55 [PATCH v2 0/3] Add support for remoteprocs on SM7635 Luca Weiss
2025-06-27 6:55 ` [PATCH v2 1/3] dt-bindings: remoteproc: qcom,sm8350-pas: document SM7635 MPSS & WPSS Luca Weiss
2025-07-01 8:12 ` Krzysztof Kozlowski
2025-07-01 10:12 ` Luca Weiss [this message]
2025-07-02 20:32 ` Krzysztof Kozlowski
2025-06-27 6:55 ` [PATCH v2 2/3] dt-bindings: remoteproc: qcom,sm8550-pas: document SM7635 ADSP & CDSP Luca Weiss
2025-07-01 8:14 ` Krzysztof Kozlowski
2025-07-01 10:16 ` Luca Weiss
2025-07-02 20:33 ` Krzysztof Kozlowski
2025-06-27 6:55 ` [PATCH v2 3/3] remoteproc: qcom: pas: Add SM7635 remoteproc support Luca Weiss
2025-07-01 12:13 ` Konrad Dybcio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DB0MZCUM41RA.7Z6461I531VD@fairphone.com \
--to=luca.weiss@fairphone.com \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=mani@kernel.org \
--cc=mathieu.poirier@linaro.org \
--cc=phone-devel@vger.kernel.org \
--cc=robh@kernel.org \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®