From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752881AbcHOHnP (ORCPT ); Mon, 15 Aug 2016 03:43:15 -0400 Received: from mail-db5eur01on0065.outbound.protection.outlook.com ([104.47.2.65]:21856 "EHLO EUR01-DB5-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751488AbcHOHnO (ORCPT ); Mon, 15 Aug 2016 03:43:14 -0400 From: =?utf-8?B?SmFuIMOWc3RsdW5k?= To: Daniel Romell , "a.zummo@towertech.it" CC: "alexandre.belloni@free-electrons.com" , "rtc-linux@googlegroups.com" , "linux-kernel@vger.kernel.org" , Daniel Romell , Magnus Olsson Subject: RE: [PATCH v2 1/2] rtc: bq32k: Use correct mask name for 'minutes' register. Thread-Topic: [PATCH v2 1/2] rtc: bq32k: Use correct mask name for 'minutes' register. Thread-Index: AQHR88QCGdccTzvQY02FB8rZwbDppaBJoKFg Date: Mon, 15 Aug 2016 07:10:27 +0000 Message-ID: References: <1470909555-9226-1-git-send-email-daro@hms.se> <1470915104-10683-2-git-send-email-daro@hms.se> In-Reply-To: <1470915104-10683-2-git-send-email-daro@hms.se> Accept-Language: sv-SE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=jao@hms.se; x-originating-ip: [88.131.56.168] x-ms-office365-filtering-correlation-id: c3ca0623-3cd9-4b6d-d7a7-08d3c4db3c52 x-microsoft-exchange-diagnostics: 1;DB6PR0601MB2725;6:aybCpNHZsEerPS1kS12ihLP0ELlke8CMKsx3LmXrXthiiYbbxar/RDz1HsyNbwKjqoZ28cvnf/lBRFRQDEqwYF0VsIAWxIJKNNe5bWsPTqczqJtJyqcf4Mijlb0lztLHNP/58gM8yc6dAFuPf5hBOQyYpiQWepwFsojuNng1J1CLj9nFmhOTRtyZfMcUxxyQc2AJHoKNFiXtsym5ZYGG1GsR7Qx0ZPzf3tu/E7FW9Wwlh7g2wyVE2FEGBaK/mTIGh2GTWGSQgS4oiRsUfQAZ5ClGsjkD3bSAfSqh+rhpCKS8lrMoB3dIxo9tZDg1gwgw;5:ExNbIP/kM1IQGCJq7wQNAQfGOS9se4Ge+9wtcmtduXRmQpmBjYEYVQ3KJDA1Hd5lOO67lBzFgkQstpl9qZnVeFNKQa+y1QRa+hYARhp0tAgHA7cCU0Ihp6RY+4WUeaswEddz+JBxTiDUWxsnK/bYqQ==;24:Xbs08pMV+YqEjo9WJr8yRb781AycSid8ptTiHuuF7DrLp1AoYLFp3u0vjpA8DX26sdRfpmTSgxooE/M5l1dlc77QMSxwiB0jD2IjKPpYqbQ=;7:q6VlCvwqNvVUuug2WS4opR1OdkZrVNFWTAST6YUM86rRjmanfIP9PISTzgPsNVAjVVCFP46YpOUTxkzYlRq8b5sUm0e33m/HclpCxP7pOHtwZlUohGKDj350kJdQ2Vhz8Uv/8hmYL9Y1WDZlH5g/Ef+M7KaKXNdtw8G2DhrnyErtZEetNmN52EHGqL7HyANXeXlI6TvQPE9vflwks5m8z/oHkkXdnOsxf2Q/K0TrzJYwSuxDwizKIKffXXOBl9Mu x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:DB6PR0601MB2725; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(215639381216008)(9452136761055)(58145275503218); x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(6040176)(601004)(2401047)(8121501046)(5005006)(3002001)(10201501046)(6043046)(6042046);SRVR:DB6PR0601MB2725;BCL:0;PCL:0;RULEID:;SRVR:DB6PR0601MB2725; x-forefront-prvs: 0035B15214 x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(6009001)(7916002)(199003)(13464003)(189002)(105586002)(85202003)(68736007)(86362001)(7846002)(2906002)(74316002)(575784001)(106356001)(5002640100001)(92566002)(122556002)(6116002)(586003)(102836003)(2501003)(11100500001)(189998001)(74482002)(5001770100001)(101416001)(77096005)(106116001)(4326007)(10400500002)(97736004)(3846002)(8936002)(81166006)(76576001)(3660700001)(87936001)(81156014)(19580405001)(19580395003)(85182001)(2900100001)(2950100001)(76176999)(8676002)(54356999)(9686002)(3280700002)(305945005)(50986999)(7696003)(7736002)(66066001)(33656002);DIR:OUT;SFP:1101;SCL:1;SRVR:DB6PR0601MB2725;H:DB4PR06MB253.eurprd06.prod.outlook.com;FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 X-OriginatorOrg: hms.se X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Aug 2016 07:10:27.6664 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 5c7c1590-4488-4e42-bc9c-15218f8ac994 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0601MB2725 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id u7F7hKBF032428 Signed-off-by: Jan Östlund -----Original Message----- From: Daniel Romell [mailto:danielromell@gmail.com] Sent: den 11 augusti 2016 13:32 To: a.zummo@towertech.it Cc: alexandre.belloni@free-electrons.com; rtc-linux@googlegroups.com; linux-kernel@vger.kernel.org; Daniel Romell ; Jan Östlund ; Magnus Olsson Subject: [PATCH v2 1/2] rtc: bq32k: Use correct mask name for 'minutes' register. From: Jan Östlund The BQ32K_SECONDS_MASK and BQ32K_MINUTES_MASK both has the same value. This is no functional change. Signed-off-by: Daniel Romell --- drivers/rtc/rtc-bq32k.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/rtc/rtc-bq32k.c b/drivers/rtc/rtc-bq32k.c index 0299988..5a0c137 100644 --- a/drivers/rtc/rtc-bq32k.c +++ b/drivers/rtc/rtc-bq32k.c @@ -94,7 +94,7 @@ static int bq32k_rtc_read_time(struct device *dev, struct rtc_time *tm) return error; tm->tm_sec = bcd2bin(regs.seconds & BQ32K_SECONDS_MASK); - tm->tm_min = bcd2bin(regs.minutes & BQ32K_SECONDS_MASK); + tm->tm_min = bcd2bin(regs.minutes & BQ32K_MINUTES_MASK); tm->tm_hour = bcd2bin(regs.cent_hours & BQ32K_HOURS_MASK); tm->tm_mday = bcd2bin(regs.date); tm->tm_wday = bcd2bin(regs.day) - 1; -- 2.7.4