From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1037109AbdEZOf1 (ORCPT ); Fri, 26 May 2017 10:35:27 -0400 Received: from mail-db5eur01on0041.outbound.protection.outlook.com ([104.47.2.41]:63616 "EHLO EUR01-DB5-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1030486AbdEZOfY (ORCPT ); Fri, 26 May 2017 10:35:24 -0400 From: Bogdan Purcareata To: Julia Lawall CC: "andrew@lunn.ch" , "f.fainelli@gmail.com" , "netdev@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "kbuild-all@01.org" Subject: RE: [PATCH v3 1/2] net: phy: Add Cortina CS4340 driver (fwd) Thread-Topic: [PATCH v3 1/2] net: phy: Add Cortina CS4340 driver (fwd) Thread-Index: AQHS1izPaq7F7hNgxk6v39EJPdJ6LKIGraBA Date: Fri, 26 May 2017 14:35:21 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: lip6.fr; dkim=none (message not signed) header.d=none;lip6.fr; dmarc=none action=none header.from=nxp.com; x-originating-ip: [192.88.146.1] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;DB5PR04MB1240;7:DHmQgHpiSUMqBGpiZehze2X5dt+Rx0IlLj2pHS7f+yAbAmQFNOK5s6PEr/+yzYd93jOu4TKxJI4fKTn6lrtv1JJfc5pEMhLG/7m9VJwiNSMseUQZWIIA4xEebr92+7TwAG7BFV4mZSLj5qnseq65tlzhgYUiGMA/qgAiS3ULn1HdCYgrSgm2debnOE6OZIezKt1fjYjtn7JbDvPBOjBnBCTphHoY3mHfTt3ucx7jBCCpEo8oDrdUFTmz45UylUHN4ZxVLayuIPQLCUzXsRA7ldz+x6BiVFdup1F8Gg7vwDnZDEZk/5jPeA+raTvmJ80uHqvW6wy7dbgqYOLEhE/6Tw== x-ms-traffictypediagnostic: DB5PR04MB1240: x-ms-office365-filtering-correlation-id: 88fb459a-c96c-48b5-b32b-08d4a4447045 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(2017030254075)(48565401081)(201703131423075)(201703031133081);SRVR:DB5PR04MB1240; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(9452136761055)(185117386973197); x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(6040450)(601004)(2401047)(8121501046)(5005006)(10201501046)(3002001)(93006095)(93001095)(6055026)(6041248)(20161123558100)(20161123560025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123555025)(20161123562025)(20161123564025)(6072148);SRVR:DB5PR04MB1240;BCL:0;PCL:0;RULEID:;SRVR:DB5PR04MB1240; x-forefront-prvs: 031996B7EF x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(6009001)(39450400003)(39850400002)(39400400002)(39840400002)(39860400002)(39410400002)(13464003)(377454003)(229853002)(7696004)(54356999)(76176999)(478600001)(66066001)(3280700002)(2900100001)(33656002)(3660700001)(3846002)(7736002)(305945005)(2906002)(8936002)(81166006)(25786009)(6436002)(74316002)(189998001)(2950100002)(6116002)(102836003)(8676002)(99286003)(5660300001)(50986999)(4326008)(54906002)(39060400002)(110136004)(6246003)(38730400002)(6506006)(53546009)(53936002)(55016002)(14454004)(86362001)(9686003)(6916009)(5250100002);DIR:OUT;SFP:1101;SCL:1;SRVR:DB5PR04MB1240;H:DB5PR04MB1240.eurprd04.prod.outlook.com;FPR:;SPF:None;MLV:ovrnspm;PTR:InfoNoRecords;LANG:en; spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-originalarrivaltime: 26 May 2017 14:35:21.3168 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB5PR04MB1240 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by mail.home.local id v4QEZgJt015045 > -----Original Message----- > From: Julia Lawall [mailto:julia.lawall@lip6.fr] > Sent: Friday, May 26, 2017 5:32 PM > To: Bogdan Purcareata > Cc: andrew@lunn.ch; f.fainelli@gmail.com; netdev@vger.kernel.org; > devicetree@vger.kernel.org; linux-kernel@vger.kernel.org; kbuild-all@01.org > Subject: Re: [PATCH v3 1/2] net: phy: Add Cortina CS4340 driver (fwd) > > The u32 values on lines 73 and 79 will not be less than 0. Will change to int for proper error checking. Thanks! Bogdan P.