mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Bough Chen <haibo.chen@nxp.com>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: "brgl@bgdev.pl" <brgl@bgdev.pl>,
	"stefan@agner.ch" <stefan@agner.ch>,
	"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
	dl-linux-imx <linux-imx@nxp.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH 2/2] gpio: vf610: Support building gpio-vf610 driver as module
Date: Tue, 17 Jan 2023 14:01:25 +0000	[thread overview]
Message-ID: <DB7PR04MB4010B71F54175CD7C73C3FC490C69@DB7PR04MB4010.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <CACRpkdaPQODoiG+ARAiT-6X2u6n7_aCO7Ywj4z=76A65iUhTpA@mail.gmail.com>

> -----Original Message-----
> From: Linus Walleij <linus.walleij@linaro.org>
> Sent: 2022年12月29日 9:46
> To: Bough Chen <haibo.chen@nxp.com>
> Cc: brgl@bgdev.pl; stefan@agner.ch; linux-gpio@vger.kernel.org; dl-linux-imx
> <linux-imx@nxp.com>; linux-kernel@vger.kernel.org
> Subject: Re: [PATCH 2/2] gpio: vf610: Support building gpio-vf610 driver as
> module
> 
> On Tue, Dec 20, 2022 at 10:02 AM <haibo.chen@nxp.com> wrote:
> 
> > From: Haibo Chen <haibo.chen@nxp.com>
> >
> > To support Android GKI, need to build this driver as module.
> > So change the config as tristate type, and add module license.
> >
> > Signed-off-by: Jindong Yue <jindong.yue@nxp.com>
> > Signed-off-by: Haibo Chen <haibo.chen@nxp.com>
> 
> OK...
> 
> >  builtin_platform_driver(vf610_gpio_driver);
> 
> Then you want something like module_platform_driver() here.

Hi Linus,

Here, though need to build this gpio driver as module due to the Android GKI, but we do not really need to 
rmmod/unbind this driver, so do not need to implement the _exit or remove callback. 
In this case, still need to change to module_platform_driver()? 
If so, after use the module_platform_driver(), is it okay to not implement the __exit /remove callback?

Best Regards
Haibo Chen
> 
> Yours,
> Linus Walleij

  reply	other threads:[~2023-01-17 14:01 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-20  9:02 [PATCH 1/2] gpio: vf610: connect GPIO label to dev name haibo.chen
2022-12-20  9:02 ` [PATCH 2/2] gpio: vf610: Support building gpio-vf610 driver as module haibo.chen
2022-12-29  1:46   ` Linus Walleij
2023-01-17 14:01     ` Bough Chen [this message]
2023-01-17 14:12       ` Linus Walleij
2022-12-29  1:43 ` [PATCH 1/2] gpio: vf610: connect GPIO label to dev name Linus Walleij
2023-01-02  8:03 ` Bartosz Golaszewski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DB7PR04MB4010B71F54175CD7C73C3FC490C69@DB7PR04MB4010.eurprd04.prod.outlook.com \
    --to=haibo.chen@nxp.com \
    --cc=brgl@bgdev.pl \
    --cc=linus.walleij@linaro.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-imx@nxp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=stefan@agner.ch \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®