From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 86DCDC433FF for ; Mon, 12 Aug 2019 07:11:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4BF6820663 for ; Mon, 12 Aug 2019 07:11:28 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=nxp.com header.i=@nxp.com header.b="RcBR4G5p" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726796AbfHLHL1 (ORCPT ); Mon, 12 Aug 2019 03:11:27 -0400 Received: from mail-eopbgr50084.outbound.protection.outlook.com ([40.107.5.84]:2951 "EHLO EUR03-VE1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725774AbfHLHL0 (ORCPT ); Mon, 12 Aug 2019 03:11:26 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=QNdqu1gd9pzENV+1JOCJTAUJM1zljf/nH1/pp2s/ObVsPgH1lZZQyoIInl3cJV3AEDWfuL5ihudd6lLs9+r2EMhqZ5C9cpJQ7nUB86pGv6tQXrJXhOTx6na6sRdYrKGul1YsiFqXCmZ5hlcGZe8g7LNMrQK/TiLLaxpjqomUcqUW0IIPASVcZgBJ4qiU1rv87YYynReTzpbvGn7mZay5yLPSzKulOoqWzgglqQCzER2wPI+SPmphDQfirgqTjCvAddHrA9DHESELKO5YbQT5M9qazBIJfjgPO0ZXLqezLn6UzIqjEuBqf3jIxVcd/ZxasFtL3hfm4JNnKQzmCzxQQA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=H+b1tuvfHz0rqk3WY/Zbneknmp3f4mUaa6q4VONGXIo=; b=nopwErRE7LnliRyeVXgWcw32F2oMZ/tjDF1mbXNx+7uSJFpmGv/KochxWWLc/vh2tHb/4jBohUUc8y5ZCwhzxsUeJgBQufxjc9nXikgMJmaDeNg786fsqz7PG66wBm8XKonXO+KiXTVklkh9zvEvoCQYc/yQDyPhJeQz4wVgor7NMoeIQ/Cgj5YpZseHaGiuGdftl13in7XZj+KkWoCYj5WJoANAqIXXktWqygjgL99Ml5hho78H8YLXoK8iZ5eQYOQMLEdTYdm48z4GyVDhiviHh46baNyGP9HcZ+BynXY40ULDXQmCzfK7k9MrCAuC+jxXs0fTUtehmMKTynzS2Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=H+b1tuvfHz0rqk3WY/Zbneknmp3f4mUaa6q4VONGXIo=; b=RcBR4G5pS66dTxdrTRGdNOMxHAOdmvs3nuLWPgWHscLcVQIrKRYmum+l26WiSSP2OMPBtm2btZIAYPwtpnHl39s+SBfn1RNmhhUWzCK0t/gJXYyXhpFl38VitzesDBdS3c1fgU8kMDPdS/oGzXXuBAXKgmYReRuh4op7GUjDOc0= Received: from DB7PR04MB4490.eurprd04.prod.outlook.com (52.135.138.150) by DB7PR04MB4874.eurprd04.prod.outlook.com (20.176.234.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2157.13; Mon, 12 Aug 2019 07:11:22 +0000 Received: from DB7PR04MB4490.eurprd04.prod.outlook.com ([fe80::ccc8:8:c071:8283]) by DB7PR04MB4490.eurprd04.prod.outlook.com ([fe80::ccc8:8:c071:8283%5]) with mapi id 15.20.2157.022; Mon, 12 Aug 2019 07:11:22 +0000 From: Biwen Li To: Sascha Hauer CC: "shawnguo@kernel.org" , "kernel@pengutronix.de" , "festevam@gmail.com" , dl-linux-imx , "wsa@the-dreams.de" , "linux-i2c@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , Laurentiu Tudor Subject: RE: [EXT] Re: i2c: imx: support slave mode for imx I2C driver Thread-Topic: [EXT] Re: i2c: imx: support slave mode for imx I2C driver Thread-Index: AQHVTZ48m9LP8x07tUuNIj/REJ9fGqbxTP4AgADfP4CABOmYAIAACNhg Date: Mon, 12 Aug 2019 07:11:22 +0000 Message-ID: References: <20190808035343.34120-1-biwen.li@nxp.com> <20190808141814.wr4hlmbaek6p7dy2@pengutronix.de> <20190812063822.7odhnj5ueqjam3g6@pengutronix.de> In-Reply-To: <20190812063822.7odhnj5ueqjam3g6@pengutronix.de> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=biwen.li@nxp.com; x-originating-ip: [119.31.174.73] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 47999b42-5db9-418f-9815-08d71ef44808 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0;PCL:0;RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600148)(711020)(4605104)(1401327)(4618075)(2017052603328)(7193020);SRVR:DB7PR04MB4874; x-ms-traffictypediagnostic: DB7PR04MB4874: x-ms-exchange-purlcount: 1 x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8882; x-forefront-prvs: 012792EC17 x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(4636009)(39860400002)(346002)(136003)(396003)(366004)(376002)(189003)(199004)(71190400001)(71200400001)(76116006)(64756008)(66446008)(66556008)(66946007)(66476007)(6916009)(6306002)(53936002)(3846002)(6116002)(9686003)(55016002)(2906002)(4326008)(6506007)(478600001)(81156014)(966005)(186003)(6436002)(7736002)(305945005)(45080400002)(74316002)(6246003)(76176011)(5660300002)(8936002)(66066001)(7696005)(25786009)(99286004)(33656002)(81166006)(102836004)(26005)(8676002)(446003)(11346002)(14454004)(476003)(86362001)(229853002)(256004)(52536014)(44832011)(486006)(316002)(54906003);DIR:OUT;SFP:1101;SCL:1;SRVR:DB7PR04MB4874;H:DB7PR04MB4490.eurprd04.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;MX:1;A:1; received-spf: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: xzQfM1wHMN//QWDxl6FDP1X1Fd9YzRIE7937OZBTFPQWJT2TeQnBPBVBqN+8Am/8qZn85dmvIukHH4j+MJmSSb+flDFENt2nIFMPPpoRzBXyj3rX2GMD25tXh1emjLHoR5fzXqrS8mfmtsOruMhyobC/JSg5+Tu8yUuELV2DfEXczDBbQjEhvvf9nABeqoOTW7SbBaKvYsoyio3adMJGVtiovn4ZfDbxtSBFqF6VOjbJiw82vsl+mxmxB8Lv0SV6Kax3O+4A+XYVeAPZ0wMqJDS66QbnxM6B7RNVzdYUgzTQGeeWehtlMnl9cv5+7WVlWrsoM2ArPFDiT/5DwVsK0g6r3+BDCbz/H7zvd5uCG5Coe/nTt180AjOXbaYr0JOwyCkCvi5Wps9V9q6z4R844lFOuytiex2q7FhwVS6IzJY= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 47999b42-5db9-418f-9815-08d71ef44808 X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Aug 2019 07:11:22.4801 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: PcmU5fpTiyZw80IPAdjDUEPRRMFw4Iy2tH3zMBhyhGhEelW1mE4GvXdoPWFcfyNU8y/IrJarsaRC1Oqwc0juxQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR04MB4874 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > Subject: Re: [EXT] Re: i2c: imx: support slave mode for imx I2C driver >=20 > Caution: EXT Email >=20 > On Fri, Aug 09, 2019 at 04:04:45AM +0000, Biwen Li wrote: > > > > > > Hi, > > > > > > On Thu, Aug 08, 2019 at 11:53:43AM +0800, Biwen Li wrote: > > > > The patch supports slave mode for imx I2C driver > > > > > > > > Signed-off-by: Biwen Li > > > > --- > > > > drivers/i2c/busses/i2c-imx.c | 199 > > > > ++++++++++++++++++++++++++++++++--- > > > > 1 file changed, 185 insertions(+), 14 deletions(-) > > > > > > > > diff --git a/drivers/i2c/busses/i2c-imx.c > > > > b/drivers/i2c/busses/i2c-imx.c index b1b8b938d7f4..f7583a9fa56f > > > > 100644 > > > > --- a/drivers/i2c/busses/i2c-imx.c > > > > +++ b/drivers/i2c/busses/i2c-imx.c > > > > @@ -202,6 +202,9 @@ struct imx_i2c_struct { > > > > struct pinctrl_state *pinctrl_pins_gpio; > > > > > > > > struct imx_i2c_dma *dma; > > > > +#if IS_ENABLED(CONFIG_I2C_SLAVE) > > > > + struct i2c_client *slave; > > > > +#endif /* CONFIG_I2C_SLAVE */ > > > > > > Other drivers just do a "select I2C_SLAVE" in Kconfig to get rid of > > > these #ifs. We should do the same. > > Hi sascha, I don't know your meaning, could you let it clearer? >=20 > Other drivers have "select I2C_SLAVE" in Kconfig, so they do not need any= #ifdef > CONFIG_I2C_SLAVE as this is always true. Okay, sascha, got it, I will remove the option in v2, thanks. >=20 > Sascha >=20 > -- > Pengutronix e.K. | > | > Industrial Linux Solutions | > https://eur01.safelinks.protection.outlook.com/?url=3Dhttp%3A%2F%2Fwww.pe > ngutronix.de%2F&data=3D02%7C01%7Cbiwen.li%40nxp.com%7C2ad7a8ef > 04c84f224a9808d71eefaf43%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0 > %7C0%7C637011887098895560&sdata=3DDde7Hi6eMWcg7SM8T63eBtgY > XsQPu3HFJaZMt6z8Vck%3D&reserved=3D0 | > Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 > | > Amtsgericht Hildesheim, HRA 2686 | Fax: > +49-5121-206917-5555 |