From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f50.google.com (mail-wr1-f50.google.com [209.85.221.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 29EF427056A for ; Thu, 10 Jul 2025 14:45:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.50 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752158721; cv=none; b=rD797ajJvd9FsyqnQiXJ43CKqcQSdzHe+BgAWy2TiUaCe1Nzn6YigYbcNf6IZisy1h784U+6KVWcrPQGOdSozU8GvPBLde+/4GqP1RFNQXXRpk6HN/R1syE1np67B2JsueyJ97CC9BNbecCU7hyM3eAqxYLJyjr463gch7vMVlU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752158721; c=relaxed/simple; bh=GuuXNEIIHpc+OomKipbBSS2eHjtAi/KmN/JAHDNUxyc=; h=Mime-Version:Content-Type:Date:Message-Id:Cc:Subject:From:To: References:In-Reply-To; b=WCzqFfI/AkLdLLqecEZ0cmA8DiCbxV65E7ALJVHCLNORhPuee3h9/Ru/Kwm4lgHVxMco2xDoaVU+3z48N9HS72tQKqZNDlgDWwOAuWwnqFhIBoOAgNxCifp/oG6weH+bhE71fBzGK+yAansTL/gUSit68NTST6Zoows74GZRQIA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=oCIn/on9; arc=none smtp.client-ip=209.85.221.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="oCIn/on9" Received: by mail-wr1-f50.google.com with SMTP id ffacd0b85a97d-3ab112dea41so668070f8f.1 for ; Thu, 10 Jul 2025 07:45:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1752158717; x=1752763517; darn=vger.kernel.org; h=in-reply-to:references:to:from:subject:cc:message-id:date :content-transfer-encoding:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=uzpztVBg8Kr6uCTVYsLaqFYuf7mdKz1OXaJIFB3Ydtk=; b=oCIn/on9utF4YPok+p2VGklKSBD403Ij+BG8HfSHqMNQJYLJD76XgMAToTA4bJPDj1 EfG4LoatNTE335CrCfp3k3IhIqD+jiVOdwmtrEOZojho6Q9KgfmE5Pk4wPQqg2xLmook VkPK4zu82itBzZJxoP5ZH9ZUXewXdd+FFWSnOL2JpRI4BoXfdLsy/N5puNhZdZJ3XEPu rYm/1dQv8k1CdJIBvnGYR5PSQFXvRSpFASIm3OQhw4Qq1W93RpXxq+O5hs//OWKtklhF qYdwToupp8/a+/OS4XcZnzcLTtSlwoCW5Dlbx3LzIe+sZBtoygoNEgOSR/DQi1BXDr13 tPow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752158717; x=1752763517; h=in-reply-to:references:to:from:subject:cc:message-id:date :content-transfer-encoding:mime-version:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=uzpztVBg8Kr6uCTVYsLaqFYuf7mdKz1OXaJIFB3Ydtk=; b=j33ZmZ/OzRtFhgJ73acU5vbi2HzbCOWOAhuT4B9fGUIJ+/3zbFRa9XEM6nHRMulv7c 2mBykm0ELhccClTvQ+8ealTvcM0t+nIEmLEj7LAynhLfupnH1AEwwJL0KtEaA5BRfjx/ 457ZtPfIGtN4l0+wOAwSISkbhx5v9oPSkyq2pbt64fYlxrzkuHWVRt9926UmfxKr0U6D gAz/M/ZAv+zlHGd9h/RqbYMXvm5mmKf7PLLufUo8n3JufhublpmTCoQRTj/AREWhH/EI AwAIEQ+Tlckgd7TZGfcTcq+UKjqGmtojRMtznYima2dpw07/S5f+B+SQ554ZpxiD76xL 2zvQ== X-Forwarded-Encrypted: i=1; AJvYcCWxTOt/8NaPvVA/ffo5BjYj7HvvlbjomdEMSVu+FmMC9xhI1j0k1kbAI3NzZDwxYl3TQ9bYz/Cp/9nJGHU=@vger.kernel.org X-Gm-Message-State: AOJu0Ywlqz0f5Cs+jzL7jttrastq15SUhsUHoMYN3vD2fzcgV6u/yWDb ArQNLx6Ba/mHj1aDmjNfj2LQlVlm0dJ1mcxf9xW0eAP6E+VvcjBo8/DEqKSoV7qX0+8= X-Gm-Gg: ASbGncuWBsAaJOKNKNSGw9WoVgy7JGRCi3jtS6EtAkQRsoR9jyq7Os9yJubtgTmUA+B m/ePS1aNM4BFOnbH3ok7sfK8W9Rzts4BHn/+9iev7NHN/KHcyDfHqlGu4mViR/ZADtfEda6pjDD qSc1gy+v1lViVV+fDWmitM6J1u4pJCN6OpS8KuM3RUOtSca1w8UwAASUrDQvcjyHc3Icp938XsV tZHfs1SLbElAACJ+JDF/SmMXga3PjL119dz5zKFLRSHs5w36jyvJ3nychB1Y4YilYnQ4Y937pFp z6WB6HOlEH3Q8bBDL0uoI5cXpQlgbCIXuJeu7QcTlbU0ert7bmbO2Ye3xeVeWDFLxMM= X-Google-Smtp-Source: AGHT+IF9BLMRIl1cpwDsXcnH1f3gWfggPdcwbBjL9LEkWjPoKOu+RvwtjCs5eMcSNOOmyzdBY+cr/g== X-Received: by 2002:a05:6000:250d:b0:3a4:df80:7284 with SMTP id ffacd0b85a97d-3b5e44e1fefmr6408642f8f.1.1752158717358; Thu, 10 Jul 2025 07:45:17 -0700 (PDT) Received: from localhost ([2a00:2381:fd67:101:6c39:59e6:b76d:825]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3b5e8e1e135sm2085810f8f.72.2025.07.10.07.45.16 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 10 Jul 2025 07:45:16 -0700 (PDT) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Thu, 10 Jul 2025 15:45:15 +0100 Message-Id: Cc: "Srinivas Kandagatla" , "Liam Girdwood" , "Rob Herring" , "Krzysztof Kozlowski" , "Conor Dooley" , "Stephen Boyd" , "Lee Jones" , "Jaroslav Kysela" , "Takashi Iwai" , , , , , "Dmitry Baryshkov" , "Srinivas Kandagatla" Subject: Re: [PATCH 3/3] ASoC: codecs: add new pm4125 audio codec driver From: "Alexey Klimov" To: "Mark Brown" X-Mailer: aerc 0.20.0 References: <20250626-pm4125_audio_codec_v1-v1-0-e52933c429a0@linaro.org> <20250626-pm4125_audio_codec_v1-v1-3-e52933c429a0@linaro.org> In-Reply-To: On Tue Jul 1, 2025 at 10:04 PM BST, Mark Brown wrote: > On Tue, Jul 01, 2025 at 08:35:42PM +0100, Alexey Klimov wrote: >> On Thu Jun 26, 2025 at 12:56 PM BST, Mark Brown wrote: >> > On Thu, Jun 26, 2025 at 12:50:31AM +0100, Alexey Klimov wrote: > >> >> +static int pm4125_micbias_control(struct snd_soc_component *componen= t, >> >> + int micb_num, int req, bool is_dapm) >> >> +{ >> >> + return 0; >> >> +} > >> > Why have this empty function which is only called from within the >> > driver? At best it's making the callers look like they do something. > >> I tried to make a minimal working version that we're going to >> update with more patches during next submission. > > Add the callers when you need them, right now this is just noise. > Nobody can tell if the callers make sense since the function does > nothing. Ok, I cleaned it for the next version. Thanks. >> >> +#if defined(CONFIG_OF) >> >> +static const struct of_device_id pm4125_of_match[] =3D { >> >> + { .compatible =3D "qcom,pm4125-codec" }, >> >> + { } >> >> +}; >> >> +MODULE_DEVICE_TABLE(of, pm4125_of_match); >> >> +#endif > >> > Why does this compatible exist? If the driver is instantiated from a >> > as a Linux software contruct it shouldn't appear in the DT. > >> Could you please elaborate a bit more? Should it be instantiated >> as an MFD device or platform device? > > Yes, if it's the child of a MFD then it shouldn't need to be described > separately in the DT. Currently, it is going to be described as child/slave device: spmi_bus { pmic@0 { pmic4125_codec: codec { ... } and will go probably in pm4125.dtsi which lists all child nodes with compatibles. Not sure if it is because each PMIC is customazable or because of better maintainability. Also, might need specific description of regulators which may vary from board to board. Not sure how is that supposed to be done without device tree description at this point. Thanks, Alexey