mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Sven Schuchmann <schuchmann@schleissheimer.de>
To: Pavel Machek <pavel@ucw.cz>
Cc: Dan Murphy <dmurphy@ti.com>, Rob Herring <robh+dt@kernel.org>,
	"linux-leds@vger.kernel.org" <linux-leds@vger.kernel.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: AW: [PATCH v1] leds: lp50xx: add setting of default intensity from DT
Date: Wed, 3 Feb 2021 15:39:59 +0000	[thread overview]
Message-ID: <DB8P190MB06348FC85033135BFC3EF5C4D9B49@DB8P190MB0634.EURP190.PROD.OUTLOOK.COM> (raw)
In-Reply-To: <20210203142940.GB12369@duo.ucw.cz>

Hello Pavel,

> > In order to use a multicolor-led together with a trigger
> > from DT the led needs to have an intensity set to see something.
> > The trigger changes the brightness of the led but if there
> > is no intensity we actually see nothing.
> >
> > This patch adds the ability to set the default intensity
> > of each led so that it is turned on from DT.
> 
> Do we need this to be configurable from device tree? Can we just set
> it to max or something?
> 
> Aha, this basically sets the initial color for LEDs the monochromatic
> triggers, right?

Let me try to explain in other words: I have one RGB-LED
which consists of 3 Colors. Each of the three colors (Red, Green, Blue) you have
to define in the DT. For example this is my setup for one RGB-LED which I wanted
to show the heartbeat in Red (half intensity):

                                multi-led@3 {
                                        #address-cells = <1>;
                                        #size-cells = <0>;
                                        reg = <0x3>;
                                        color = <LED_COLOR_ID_RGB>;

                                        linux,default-trigger = "heartbeat";
                                        function = LED_FUNCTION_HEARTBEAT;

                                        led-9 {
                                                color = <LED_COLOR_ID_RED>;
                                                default-intensity = <100>;
                                        };

                                        led-10 {
                                                color = <LED_COLOR_ID_GREEN>;
                                        };

                                        led-11 {
                                                color = <LED_COLOR_ID_BLUE>;
                                        };
                                };

If I would not have the default-intensity I would actually see nothing,
since the intensity (which goes from 0-255) of each led is initialized with 0.

I hope I could clarify this a little more?

Best Regards,

   Sven

  reply	other threads:[~2021-02-03 15:43 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-19 10:53 Sven Schuchmann
2021-02-02 10:48 ` AW: " Sven Schuchmann
2021-02-02 18:24 ` Jacek Anaszewski
2021-02-03 14:29 ` Pavel Machek
2021-02-03 15:39   ` Sven Schuchmann [this message]
2021-02-03 16:35     ` Pavel Machek
2021-02-03 17:10       ` AW: " Sven Schuchmann
2021-02-03 17:25         ` Pavel Machek
2021-02-04  7:32           ` AW: " Sven Schuchmann
2021-02-03 17:21       ` Marek Behun
2021-02-03 17:23         ` Pavel Machek
2021-02-04  7:31           ` AW: " Sven Schuchmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DB8P190MB06348FC85033135BFC3EF5C4D9B49@DB8P190MB0634.EURP190.PROD.OUTLOOK.COM \
    --to=schuchmann@schleissheimer.de \
    --cc=devicetree@vger.kernel.org \
    --cc=dmurphy@ti.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-leds@vger.kernel.org \
    --cc=pavel@ucw.cz \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®