mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Chancel Liu <chancel.liu@nxp.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
	"lgirdwood@gmail.com" <lgirdwood@gmail.com>,
	"broonie@kernel.org" <broonie@kernel.org>,
	"robh+dt@kernel.org" <robh+dt@kernel.org>,
	"krzysztof.kozlowski+dt@linaro.org" 
	<krzysztof.kozlowski+dt@linaro.org>,
	"conor+dt@kernel.org" <conor+dt@kernel.org>,
	"shawnguo@kernel.org" <shawnguo@kernel.org>,
	"s.hauer@pengutronix.de" <s.hauer@pengutronix.de>,
	"kernel@pengutronix.de" <kernel@pengutronix.de>,
	"festevam@gmail.com" <festevam@gmail.com>,
	dl-linux-imx <linux-imx@nxp.com>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>
Subject: RE: Re: [RESEND v2 3/3] ASoC: dt-bindings: fsl,mqs: Convert format to json-schema
Date: Tue, 21 Nov 2023 06:08:25 +0000	[thread overview]
Message-ID: <DB9PR04MB9498926086E27ECBA09CB142E3BBA@DB9PR04MB9498.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <2fec766b-dd75-4b96-8114-394ff16c63a7@linaro.org>

> > +allOf:
> > +  - if:
> > +      properties:
> > +        compatible:
> > +          contains:
> > +            const: fsl,imx8qm-mqs
> > +    then:
> > +      properties:
> > +        clocks:
> > +          items:
> > +            - description: Master clock
> > +            - description: Clock for register access
> > +        clock-names:
> > +          items:
> > +            - const: mclk
> > +            - const: core
> > +      required:
> > +        - reg
> > +        - power-domains
> > +    else:
> > +      properties:
> > +        clocks:
> > +          items:
> > +            - description: Master clock
> > +        clock-names:
> > +          items:
> > +            - const: mclk
> > +
> > +  - if:
> > +      properties:
> > +        compatible:
> > +          contains:
> > +            enum:
> > +              - fsl,imx6sx-mqs
> > +              - fsl,imx93-mqs
> > +    then:
> > +      required:
> > +        - gpr
> 
> This is a bit confusing. Only "fsl,imx8qm-mqs" requires (uses?) reg.
> imx6sx and imx93 use gpr. Then what do the other variants use?
> 
> Best regards,
> Krzysztof

Thanks to your pointing out. I checked the history and found the legacy 
"fsl,codec-mqs" is not used anymore. I will drop it and also "fsl,imx8qxp-mqs"
is completed which uses reg.

Regards, 
Chancel Liu

      reply	other threads:[~2023-11-21  6:08 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-20  8:49 [RESEND v2 0/3] Add audio device nodes for i.MX93 platform Chancel Liu
2023-11-20  8:49 ` [RESEND v2 1/3] arm64: dts: imx93: Add audio device nodes Chancel Liu
2023-11-20  8:49 ` [RESEND v2 2/3] arm64: dts: imx93: Configure clock rate for audio PLL Chancel Liu
2023-11-20  8:49 ` [RESEND v2 3/3] ASoC: dt-bindings: fsl,mqs: Convert format to json-schema Chancel Liu
2023-11-20  9:38   ` Krzysztof Kozlowski
2023-11-21  6:08     ` Chancel Liu [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DB9PR04MB9498926086E27ECBA09CB142E3BBA@DB9PR04MB9498.eurprd04.prod.outlook.com \
    --to=chancel.liu@nxp.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=festevam@gmail.com \
    --cc=kernel@pengutronix.de \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=krzysztof.kozlowski@linaro.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-imx@nxp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    --cc=s.hauer@pengutronix.de \
    --cc=shawnguo@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®