mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Wei Fang <wei.fang@nxp.com>
To: Harshitha Ramamurthy <hramamurthy@google.com>
Cc: Claudiu Manoil <claudiu.manoil@nxp.com>,
	Vladimir Oltean <vladimir.oltean@nxp.com>,
	Clark Wang <xiaoning.wang@nxp.com>,
	"andrew+netdev@lunn.ch" <andrew+netdev@lunn.ch>,
	"davem@davemloft.net" <davem@davemloft.net>,
	"edumazet@google.com" <edumazet@google.com>,
	"kuba@kernel.org" <kuba@kernel.org>,
	"pabeni@redhat.com" <pabeni@redhat.com>,
	"imx@lists.linux.dev" <imx@lists.linux.dev>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"catalin.horghidan@nxp.com" <catalin.horghidan@nxp.com>
Subject: RE: [PATCH v2 net 8/9] net: enetc: fix initialization order to prevent use of uninitialized resources
Date: Wed, 20 May 2026 01:42:50 +0000	[thread overview]
Message-ID: <DBBPR04MB750048752B9378DF2B6BD94C88012@DBBPR04MB7500.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <CAEAWyHfk7y691oYNmYy5W8dA8cnpwG4ejnXPssMLOUO+Ljo24g@mail.gmail.com>

> > @@ -151,14 +149,17 @@ void enetc_msg_psi_free(struct enetc_pf *pf)
> >         struct enetc_si *si = pf->si;
> >         int i;
> >
> > +       /* disable MR interrupts */
> > +       enetc_msg_disable_mr_int(&si->hw);
> > +
> > +       /* de-register message passing interrupt handler */
> > +       free_irq(pci_irq_vector(si->pdev, ENETC_SI_INT_IDX), si);
> > +
> >         cancel_work_sync(&pf->msg_task);
> >
> > -       /* disable MR interrupts */
> > +       /* MR interrupts may be re-enabled by workqueue */
> >         enetc_msg_disable_mr_int(&si->hw);
> >
> >         for (i = 0; i < pf->num_vfs; i++)
> >                 enetc_msg_free_mbx(si, i);
> > -
> > -       /* de-register message passing interrupt handler */
> > -       free_irq(pci_irq_vector(si->pdev, ENETC_SI_INT_IDX), si);
> 
> Code looks good to me but a nit: would be good if the change here in
> enetc_msg_psi_free() is also called out in the commit message.

Thanks, I will update the commit message.

--
pw-bot: cr

  reply	other threads:[~2026-05-20  1:42 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-18  3:05 [PATCH v2 net 0/9] net: enetc: SR-IOV robustness and security fixes Wei Fang
2026-05-18  3:05 ` [PATCH v2 net 1/9] net: enetc: fix incorrect mailbox message status returned to VFs Wei Fang
2026-05-18  3:05 ` [PATCH v2 net 2/9] net: enetc: fix missing error code when pf->vf_state allocation fails Wei Fang
2026-05-18  3:05 ` [PATCH v2 net 3/9] net: enetc: add ratelimiting to VF mailbox error messages Wei Fang
2026-05-18  3:05 ` [PATCH v2 net 4/9] net: enetc: fix TOCTOU race and validate VF MAC address Wei Fang
2026-05-18  3:05 ` [PATCH v2 net 5/9] net: enetc: fix race condition in VF MAC address configuration Wei Fang
2026-05-18  3:05 ` [PATCH v2 net 6/9] net: enetc: fix DMA write to freed memory in enetc_msg_free_mbx() Wei Fang
2026-05-18  3:05 ` [PATCH v2 net 7/9] net: enetc: fix VF-to-PF message handler unbounded loop DoS Wei Fang
2026-05-18  3:05 ` [PATCH v2 net 8/9] net: enetc: fix initialization order to prevent use of uninitialized resources Wei Fang
2026-05-19 17:15   ` Harshitha Ramamurthy
2026-05-20  1:42     ` Wei Fang [this message]
2026-05-18  3:05 ` [PATCH v2 net 9/9] net: enetc: avoid VF->PF mailbox timeout during SR-IOV teardown Wei Fang
2026-05-19 17:25 ` [PATCH v2 net 0/9] net: enetc: SR-IOV robustness and security fixes Harshitha Ramamurthy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DBBPR04MB750048752B9378DF2B6BD94C88012@DBBPR04MB7500.eurprd04.prod.outlook.com \
    --to=wei.fang@nxp.com \
    --cc=andrew+netdev@lunn.ch \
    --cc=catalin.horghidan@nxp.com \
    --cc=claudiu.manoil@nxp.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=hramamurthy@google.com \
    --cc=imx@lists.linux.dev \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=vladimir.oltean@nxp.com \
    --cc=xiaoning.wang@nxp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®