From: Peter Chen <peter.chen@nxp.com>
To: Randy Dunlap <rdunlap@infradead.org>,
Pawel Laszczak <pawell@cadence.com>
Cc: "a-govindraju@ti.com" <a-govindraju@ti.com>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"kurahul@cadence.com" <kurahul@cadence.com>
Subject: RE: [PATCH] usb: cdnsp: fixes undefined reference to cdns_remove
Date: Tue, 12 Jan 2021 01:55:58 +0000 [thread overview]
Message-ID: <DBBPR04MB7979C0CEB3B0E8A73EB4D6048BAA0@DBBPR04MB7979.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <7aa22b3c-f56f-b215-2f84-348e24a48044@infradead.org>
>
> On 1/11/21 6:42 AM, Pawel Laszczak wrote:
> > Patch fixes the following errors:
> > ld: drivers/usb/cdns3/cdnsp-pci.o: in function `cdnsp_pci_remove':
> > cdnsp-pci.c:(.text+0x80): undefined reference to `cdns_remove'
> > ld: drivers/usb/cdns3/cdnsp-pci.o: in function `cdnsp_pci_probe':
> > cdnsp-pci.c:(.text+0x34c): undefined reference to `cdns_init'
> >
> > Issue occurs for USB/CDNS3/CDNSP kernel configuration:
> > CONFIG_USB=m
> > CONFIG_USB_CDNS_SUPPORT=y
> > CONFIG_USB_CDNS3=m
> > CONFIG_USB_CDNS3_PCI_WRAP=m
> > CONFIG_USB_CDNSP_PCI=y
> >
> > Reported-by: Randy Dunlap <rdunlap@infradead.org>
> > Signed-off-by: Pawel Laszczak <pawell@cadence.com>
>
> Yep, that works. Thanks.
>
> Acked-by: Randy Dunlap <rdunlap@infradead.org> # build-tested
>
Applied it, thanks.
Peter
>
> > ---
> > drivers/usb/cdns3/Makefile | 4 ++++
> > 1 file changed, 4 insertions(+)
> >
> > diff --git a/drivers/usb/cdns3/Makefile b/drivers/usb/cdns3/Makefile
> > index 3f9b7fa8a594..be906910f98b 100644
> > --- a/drivers/usb/cdns3/Makefile
> > +++ b/drivers/usb/cdns3/Makefile
> > @@ -26,7 +26,11 @@ obj-$(CONFIG_USB_CDNS3_TI) +=
> cdns3-ti.o
> > obj-$(CONFIG_USB_CDNS3_IMX) += cdns3-imx.o
> >
> > cdnsp-udc-pci-y := cdnsp-pci.o
> > +ifeq ($(CONFIG_USB),m)
> > +obj-m += cdnsp-udc-pci.o
> > +else
> > obj-$(CONFIG_USB_CDNSP_PCI) += cdnsp-udc-pci.o
> > +endif
> > cdnsp-udc-pci-$(CONFIG_USB_CDNSP_GADGET) += cdnsp-ring.o
> cdnsp-gadget.o \
> > cdnsp-mem.o cdnsp-ep0.o
> >
> >
>
>
> --
> ~Randy
next prev parent reply other threads:[~2021-01-12 1:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-11 14:42 Pawel Laszczak
2021-01-11 17:16 ` Randy Dunlap
2021-01-12 1:55 ` Peter Chen [this message]
2021-01-12 8:15 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DBBPR04MB7979C0CEB3B0E8A73EB4D6048BAA0@DBBPR04MB7979.eurprd04.prod.outlook.com \
--to=peter.chen@nxp.com \
--cc=a-govindraju@ti.com \
--cc=gregkh@linuxfoundation.org \
--cc=kurahul@cadence.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=pawell@cadence.com \
--cc=rdunlap@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®