From: Marcel Holtmann <marcel@holtmann.org>
To: behanw@converseincode.com
Cc: "David S. Miller" <davem@davemloft.net>,
"Gustavo F. Padovan" <gustavo@padovan.org>,
"Johan Hedberg" <johan.hedberg@gmail.com>,
"BlueZ development" <linux-bluetooth@vger.kernel.org>,
"kernel list" <linux-kernel@vger.kernel.org>,
netdev@vger.kernel.org,
"Linus Torvalds" <torvalds@linux-foundation.org>,
"Mark Charlebois" <charlebm@gmail.com>,
"Jan-Simon Möller" <dl9pf@gmx.de>
Subject: Re: [PATCH] bluetooth: LLVMLinux: Remove VLAIS from bluetooth/amp.c
Date: Fri, 5 Sep 2014 16:22:16 -0700 [thread overview]
Message-ID: <DBC61EBD-5FDE-48FE-8FD1-CA4F606C22F6@holtmann.org> (raw)
In-Reply-To: <1409958214-5651-1-git-send-email-behanw@converseincode.com>
Hi Behan,
> Replaced the use of a Variable Length Array In Struct (VLAIS) with a C99
> compliant equivalent. This patch allocates the appropriate amount of memory
> using an char array.
>
> The new code can be compiled with both gcc and clang.
>
> struct shash_desc contains a flexible array member member ctx declared with
> CRYPTO_MINALIGN_ATTR, so sizeof(struct shash_desc) aligns the beginning
> of the array declared after struct shash_desc with long long.
>
> No trailing padding is required because it is not a struct type that can
> be used in an array.
>
> The CRYPTO_MINALIGN_ATTR is required so that desc is aligned with long long
> as would be the case for a struct containing a member with
> CRYPTO_MINALIGN_ATTR.
>
> Signed-off-by: Behan Webster <behanw@converseincode.com>
> Signed-off-by: Mark Charlebois <charlebm@gmail.com>
> Signed-off-by: Jan-Simon Möller <dl9pf@gmx.de>
> ---
> net/bluetooth/amp.c | 13 ++++++-------
> 1 file changed, 6 insertions(+), 7 deletions(-)
patch has been applied to bluetooth-next tree.
Regards
Marcel
prev parent reply other threads:[~2014-09-05 23:21 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-05 23:03 behanw
2014-09-05 23:22 ` Marcel Holtmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DBC61EBD-5FDE-48FE-8FD1-CA4F606C22F6@holtmann.org \
--to=marcel@holtmann.org \
--cc=behanw@converseincode.com \
--cc=charlebm@gmail.com \
--cc=davem@davemloft.net \
--cc=dl9pf@gmx.de \
--cc=gustavo@padovan.org \
--cc=johan.hedberg@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®