From: "Luca Weiss" <luca.weiss@fairphone.com>
To: "Krzysztof Kozlowski" <krzysztof.kozlowski@linaro.org>,
"Bjorn Andersson" <andersson@kernel.org>,
"Konrad Dybcio" <konradybcio@kernel.org>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
<linux-arm-msm@vger.kernel.org>, <devicetree@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] dt-bindings: arm: qcom-soc: Document new Milos and Glymur SoCs
Date: Thu, 17 Jul 2025 08:27:11 +0200 [thread overview]
Message-ID: <DBE47UNGCDLE.3AZF5XENB5BEB@fairphone.com> (raw)
In-Reply-To: <20250716162412.27471-2-krzysztof.kozlowski@linaro.org>
On Wed Jul 16, 2025 at 6:24 PM CEST, Krzysztof Kozlowski wrote:
> Extend the schema enforcing correct SoC-block naming to cover Milos
> (compatibles already accepted by some maintainers for next release) and
> Glymur (posted on mailing lists [1]) SoCs.
>
> Link: https://lore.kernel.org/linux-devicetree/20250716152017.4070029-1-pankaj.patil@oss.qualcomm.com/ [1]
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>
> ---
>
> I asked for documenting the Milos name at v2 of Milos patchset... it did
> not happen and patches are already being accepted.
Sorry about that, I seem to have missed that.
However I did not see any dt validation errors with my milos dts or
dt_binding_check on the bindings, where are these patterns relevant, in
case I should touch it again in the future?
Regards
Luca
>
> Cc: Luca Weiss <luca.weiss@fairphone.com>
> ---
> Documentation/devicetree/bindings/arm/qcom-soc.yaml | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/arm/qcom-soc.yaml b/Documentation/devicetree/bindings/arm/qcom-soc.yaml
> index a77d68dcad4e..27261039d56f 100644
> --- a/Documentation/devicetree/bindings/arm/qcom-soc.yaml
> +++ b/Documentation/devicetree/bindings/arm/qcom-soc.yaml
> @@ -23,7 +23,9 @@ description: |
> select:
> properties:
> compatible:
> - pattern: "^qcom,.*(apq|ipq|mdm|msm|qcm|qcs|q[dr]u|sa|sar|sc|sd[amx]|sm|x1[ep])[0-9]+.*$"
> + oneOf:
> + - pattern: "^qcom,.*(apq|ipq|mdm|msm|qcm|qcs|q[dr]u|sa|sar|sc|sd[amx]|sm|x1[ep])[0-9]+.*$"
> + - pattern: "^qcom,.*(glymur|milos).*$"
> required:
> - compatible
>
> @@ -34,6 +36,7 @@ properties:
> - pattern: "^qcom,(apq|ipq|mdm|msm|qcm|qcs|q[dr]u|sa|sc|sd[amx]|sm|x1[ep])[0-9]+(pro)?-.*$"
> - pattern: "^qcom,sar[0-9]+[a-z]?-.*$"
> - pattern: "^qcom,(sa|sc)8[0-9]+[a-z][a-z]?-.*$"
> + - pattern: "^qcom,(glymur|milos)-.*$"
>
> # Legacy namings - variations of existing patterns/compatibles are OK,
> # but do not add completely new entries to these:
next prev parent reply other threads:[~2025-07-17 6:27 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-16 16:24 Krzysztof Kozlowski
2025-07-17 6:27 ` Luca Weiss [this message]
2025-07-17 6:33 ` Krzysztof Kozlowski
2025-07-17 6:37 ` Luca Weiss
2025-07-20 23:18 ` Rob Herring (Arm)
2025-08-11 23:27 ` Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DBE47UNGCDLE.3AZF5XENB5BEB@fairphone.com \
--to=luca.weiss@fairphone.com \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®