From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755133AbcLNIUR convert rfc822-to-8bit (ORCPT ); Wed, 14 Dec 2016 03:20:17 -0500 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:50389 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754923AbcLNIUO (ORCPT ); Wed, 14 Dec 2016 03:20:14 -0500 Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 10.1 \(3251\)) Subject: Re: [PATCH] [PATCH] GenWQE: drop duplicate headers From: Frank Haverkamp In-Reply-To: Date: Wed, 14 Dec 2016 09:20:08 +0100 Cc: Gabriel Krisman Bertazi , linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8BIT References: To: Geliang Tang X-Mailer: Apple Mail (2.3251) X-TM-AS-GCONF: 00 X-Content-Scanned: Fidelis XPS MAILER x-cbid: 16121408-0040-0000-0000-000002757BE9 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 16121408-0041-0000-0000-000022EF4707 Message-Id: X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2016-12-14_06:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=4 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1609300000 definitions=main-1612140142 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Geliang, > On 28 Nov 2016, at 15:15, Geliang Tang wrote: > > On Thu, Nov 24, 2016 at 01:51:57PM +0100, Frank Haverkamp wrote: >> Hi Geliang, >> >> thanks for the simplification. Did you find those by manual inspection, or did you use a tool? >> >> Acked-by: Frank Haverkamp > > Hi Frank, > > Thanks for your review. > > I found those duplicate headers by a simple script written by myself. > I should have used scripts/checkincludes.pl to do this. Now I am using > scripts/checkincludes.pl to check GenWQE files, and I found another > duplicate header dma-mapping.h. So I updated this patch. > Nice. Thanks for checking our code. > -Geliang > > Geliang Tang (1): > GenWQE: drop duplicate headers > > drivers/misc/genwqe/card_base.c | 1 - > drivers/misc/genwqe/card_ddcb.c | 1 - > drivers/misc/genwqe/card_utils.c | 2 -- > 3 files changed, 4 deletions(-) > > -- > 2.9.3 > I am ok with the updated version too. Acked-by: Frank Haverkamp Frank