From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f48.google.com (mail-ed1-f48.google.com [209.85.208.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 08945284685 for ; Mon, 21 Jul 2025 07:42:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753083762; cv=none; b=lSRpP6+izArrltX+ZbpbSYKMB6sCTkzfO8MmqEXRfzhQ9XAnIuRpUHi01Wt1Jw3xVGCsTAM5Z8J6RwB3P04OleCBdjCY7PCKjRXouN/bdDIpcZXzLcMUOS4xEnypC8c6UdUpKh5RJoM2WjLMA12Rxf8cNCzDgTQJ6LhWSPeoj1M= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753083762; c=relaxed/simple; bh=chzQDhpRR0KkFFSvGWLDbsXZDi/1ZGpp4j7nqK/5mxo=; h=Mime-Version:Content-Type:Date:Message-Id:Subject:From:To:Cc: References:In-Reply-To; b=gkrEYZxh2lIYZJLsiTy1OUCsPUnGceeRTdYF1JpgJiPafrDSpDeCZCSxXRvp5upriwG+rciDsgaxYzFrU7BovihP/PuVHuokLt3WZ8caJkeUCHXP8d0932vufkHa0Kww3vBYRYedhkmqMEnNHKK2CpBhqYCwsab7cdSOS/t0YWk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=fairphone.com; spf=pass smtp.mailfrom=fairphone.com; dkim=pass (2048-bit key) header.d=fairphone.com header.i=@fairphone.com header.b=ZHmo0Ofm; arc=none smtp.client-ip=209.85.208.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=fairphone.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=fairphone.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=fairphone.com header.i=@fairphone.com header.b="ZHmo0Ofm" Received: by mail-ed1-f48.google.com with SMTP id 4fb4d7f45d1cf-6129ff08877so6318183a12.1 for ; Mon, 21 Jul 2025 00:42:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fairphone.com; s=fair; t=1753083759; x=1753688559; darn=vger.kernel.org; h=in-reply-to:references:cc:to:from:subject:message-id:date :content-transfer-encoding:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=/Jn2uM1C1hodxQz3Up00DI8ehhdUTfz2Vy9NLN+SJQA=; b=ZHmo0Ofmh0GkYtbtnBrkBXAph6ck5S93mdvYHgMT1Cne2rvnNOQkE27CEbOH1xWS/7 NhgvCVGwAxxwAxh22dRuKuoulqNM/d/FsUKcb1VemcCWyMYH6QgERk6Q5tOpz62rJ3QC zIhQHa5gKeToe3Un+4ndbomLZDjnQMxtXkTO5MWnxxlbEnNeq+td2/Ll52U7KBTMz+Sc +aVIqO0NTLIbMfJVE6AyOWI25bcEen6y3VcNIEKh58NRUzqIG5si1ez5wHVgcp2YseYr vXxugd/AKgiPEnver6TieHzQH8MHdowWSrW/lf842esl8Y/aPjTuhRbtFzirf+5gDuRd nZYw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1753083759; x=1753688559; h=in-reply-to:references:cc:to:from:subject:message-id:date :content-transfer-encoding:mime-version:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=/Jn2uM1C1hodxQz3Up00DI8ehhdUTfz2Vy9NLN+SJQA=; b=PH4ShqSD4oqQqCc9tz6jNZfP9LcJxVCIQA9XpCNFPdoSOS9Fx5nDDN+hgCFRCqdajl rGlh4nQWh3KoI/PvL/dJCRqKYexI3M++L3ijF1JXAk7ZuvC1tweDxlXwMrmQuOeZ+4f1 5KTbV3N5jGQI8W1rkwywr63whjqy44bVhG2IpKyCZayd+oPjzSZwqOw7mvvIIO2YpGqP YpNkCJM26BPSXZUBCo9xgdKz/5XeP8vIxgk0MJuVvqa3wPuBiESfcW9EU4pnV59dk7dS QS2fM0wmY8RAM8BPGapRR8qE7ECTxd31ct+1WWa8MVGJRs94tsuMuUSXn/e6zouUrRzb /6tQ== X-Forwarded-Encrypted: i=1; AJvYcCXYN1A3+KWklT7lAK65fmrfaoGPGBRAnJx6xOJJWqp0fRvFvPcVxPE4dOdjMPutKJpED69aVLufp+WXh9Q=@vger.kernel.org X-Gm-Message-State: AOJu0Yw7oFdrMIeGvE+msyu1WCqkZjdrFT9O+qL/ScY6Z1VZ7PP6Hxfq U4MJI6ISRZXFRnplImVRACKb3S4Xqo+Bp4eHlkBx8GFICLdys78rOl/CGeumOAXwE/gGxRBNGH2 c+mB1nsdLSQ== X-Gm-Gg: ASbGncvRLbnIMO/ZgsnjxnYJONuObGICFA4fE+bywF5FLrK7dqt48OMvbH3c6/DpNA3 6XUVwi7ZaYc3KHULn4YDnUUhOYqZJgX5JU8hnhUWsJDNsvULuNGCyiMg/I4zKjJPEkkx0A7ydIi p0e7mnCTHwnlU0hJN+z6+TGNgF4LmYwsdi9Pk4BhL6Pnr81C3cXmggrjQTR914LBaMbCypgyOVt Opmj1AZatd/FZkLnJ6YdwsaNwJfxCh/nN0QzeJ8AOXrKVN7HHYSOrbKGGom207AFygDNa3zk6Ov P2r/KHJ36bq2PeVXeZMGycaEkT3BZTQ/IAzP/mGl0BuXWagwDijNXL1INJTUuWflwfCmgKX7KST y2nT6nYrpfxBEUDXa4gyG9TxhO0LdAVcucV+b78QWhAxFqsJqkmC1/N9cLHvg7WqRMnpnRaIEJs 3SzpdVrfVPx+0QAUrJWgXH0GgidBi6890= X-Google-Smtp-Source: AGHT+IHojokpIKOVzO2mTGfd8U+xB3sxarTMHuXH9C3us/pGvkjTIHvaL7YhUPwGxvFGX/BiGyYmDg== X-Received: by 2002:a17:907:a901:b0:ae0:a465:1c20 with SMTP id a640c23a62f3a-aec4de61a29mr1564976266b.14.1753083759251; Mon, 21 Jul 2025 00:42:39 -0700 (PDT) Received: from localhost (2001-1c00-3b8a-ea00-c4de-d39d-05f4-c77a.cable.dynamic.v6.ziggo.nl. [2001:1c00:3b8a:ea00:c4de:d39d:5f4:c77a]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-aec6daf4579sm615655866b.77.2025.07.21.00.42.38 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 21 Jul 2025 00:42:38 -0700 (PDT) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Mon, 21 Jul 2025 09:42:38 +0200 Message-Id: Subject: Re: [PATCH v3 2/2] interconnect: qcom: Add Milos interconnect provider driver From: "Luca Weiss" To: "Georgi Djakov" , "Rob Herring" , "Krzysztof Kozlowski" , "Conor Dooley" Cc: <~postmarketos/upstreaming@lists.sr.ht>, , , , , X-Mailer: aerc 0.20.1-0-g2ecb8770224a-dirty References: <20250709-sm7635-icc-v3-0-c446203c3b3a@fairphone.com> <20250709-sm7635-icc-v3-2-c446203c3b3a@fairphone.com> In-Reply-To: Hi Georgi, On Mon Jul 21, 2025 at 9:36 AM CEST, Georgi Djakov wrote: > Hi Luca, > > On 7/9/25 4:14 PM, Luca Weiss wrote: >> Add driver for the Qualcomm interconnect buses found in Milos based >> platforms. The topology consists of several NoCs that are controlled by >> a remote processor that collects the aggregated bandwidth for each >> master-slave pairs. >>=20 >> Signed-off-by: Luca Weiss >> --- >> drivers/interconnect/qcom/Kconfig | 9 + >> drivers/interconnect/qcom/Makefile | 2 + >> drivers/interconnect/qcom/milos.c | 1837 ++++++++++++++++++++++++++++= ++++++++ >> 3 files changed, 1848 insertions(+) >>=20 > [..] >> + >> +static struct qcom_icc_qosbox qhm_qup1_qos =3D { >> + .num_ports =3D 1, >> + .port_offsets =3D { 0xc000 }, >> + .prio =3D 2, >> + .urg_fwd =3D 0, >> + .prio_fwd_disable =3D 1, >> +}; > > Thanks for adding QoS! > >> + >> +static struct qcom_icc_node qhm_qup1 =3D { >> + .name =3D "qhm_qup1", >> + .channels =3D 1, >> + .buswidth =3D 4, >> + .qosbox =3D &qhm_qup1_qos, >> + .link_nodes =3D { &qns_a1noc_snoc, NULL }, >> +}; > > It's very nice that you switched to the dynamic IDs, but please use the > current style of links (like in v1), as the the NULL terminated lists > are not merged yet. All the rest looks good! Is what's in todays linux-next a good base? Or what branch should I base this on? But correct, I currently have v2 of dynamic ID patches in the base for this. Also If I send the next revision by e.g. Wednesday can it still go into 6.17? Just wondering how quick I need to work on this. Regards Luca > > Thanks, > Georgi