From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f65.google.com (mail-ej1-f65.google.com [209.85.218.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3469C2DEA8E for ; Tue, 22 Jul 2025 14:29:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.65 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753194583; cv=none; b=SdR5SHzPAwbpkQSlo/4ttM2P9GHwt4VoXoBA41uOm8EsAo44ytau9j7O8avzTvgAIjtbm1hYIYZtDaBuv+bFRg8yX5aVynN9ZRh2GugRZ/QDPWRJK1vAahr1zzPd/H05K1F3MxBByj7yqWEYR4Dd2XLFTVEUOuZQZtV9rgasvKw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753194583; c=relaxed/simple; bh=eJBssySJGcFKIYVJchM+wWdNFawpVuNYlagTrqAI8XQ=; h=Mime-Version:Content-Type:Date:Message-Id:Cc:Subject:From:To: References:In-Reply-To; b=CVHW45wopUhH1cGR2R2Ln4b5bUoXe60Q4vi9B/VaUhulqfACvptrZQUGLq1U3B+Y3429TwhGSruF+Wi80zHWJih6/1shT1/a02ObIZUOczG73FotlYCis50IgWV1W/8o66QwgGOSrPqCvLiR1PFwRQL8ghi4bvGt3vdB+iAXuc0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=fairphone.com; spf=pass smtp.mailfrom=fairphone.com; dkim=pass (2048-bit key) header.d=fairphone.com header.i=@fairphone.com header.b=rNamLTE7; arc=none smtp.client-ip=209.85.218.65 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=fairphone.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=fairphone.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=fairphone.com header.i=@fairphone.com header.b="rNamLTE7" Received: by mail-ej1-f65.google.com with SMTP id a640c23a62f3a-ae3be3eabd8so1047628966b.1 for ; Tue, 22 Jul 2025 07:29:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fairphone.com; s=fair; t=1753194579; x=1753799379; darn=vger.kernel.org; h=in-reply-to:references:to:from:subject:cc:message-id:date :content-transfer-encoding:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=BZnozY3BLIkuA8NA4eNUY0Vf/U8jemAXm7Mzb6ICDTM=; b=rNamLTE723bJTXI7ZBoxsG7cNlEsJTes3JImaUswENXFlgLnmch4J4c8WvQPXYkKPq 26Q9qxivCT0AJu8qI8t4DcVHUP7WrYX+yslstetmG1LcTPsNdFwabIVIbK4rAokBcBqq u3MoOOkhTxoiKQwbsLrtGTdhiQFJGNKuROOjgjlTWUS2GVS83cgjwVPJMUhoAR9qARRO C43Ps6hY1X769nrHdxzOnON/h0W/lDDNsngRZlqQrPmdHmFBuOesxW1bZe5bhjH7lTT6 l5zUL+O8/iMX3cAFIgWZboHxw/Ac/r4c4apx3wJiSo61HkH58MFhttnf8ykJBnyz26Zo I9ow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1753194579; x=1753799379; h=in-reply-to:references:to:from:subject:cc:message-id:date :content-transfer-encoding:mime-version:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=BZnozY3BLIkuA8NA4eNUY0Vf/U8jemAXm7Mzb6ICDTM=; b=MN5tojnJVJwaplSqyTYKPs5cFhawaP69K+vNO2oQapjW4SwvEjgVGLUBGP+TC1Duoy uINlt3ZcDawLeVNKdSKWBsRGxSNO3dLzakEVwl/6rngeo3dzqzHEHnh/S3HyM2XT2SOl J5B0d3U50QrlUcCOghNBN9CVjuLuSqo++Mo9+0HoL4tXqBhaMyEUIMqIky/reSae+98i lftnmc7tri/JJisH3bEChyUN0kURURJMWLiWIcocHIOGQpcyRdDUQlhISK+EqHR3ZJFY QrVoKxFwYCXlfZ67vC5Zt3wWyBgwsPzAMH8eGEHgHNCtB8MDRcS3AOBtuF9gTqk4CaMt 6ZkA== X-Forwarded-Encrypted: i=1; AJvYcCVb/cdzEpjs3VMDtZBQwZTlNy5i9O7Fh3gZ7QE4YsAN3FU+OZVSP/edVxKwVDdwFqvSXBv6kPcQHcEg9UQ=@vger.kernel.org X-Gm-Message-State: AOJu0YwEIImq4ZvoO75G9uEyXceltcL21sRNON98gXdk90ApTJt77unj xrKgPgzKi6W+uRlTAl9JpmYmzwt28N867j/IN6GVGemykcPBY4XBUorwM6JT/oLlim4= X-Gm-Gg: ASbGncs+bIVICG0NkWoy6HXRJbrUY0aHLZqEFCUAqlaAWWR0sXqSVSj+rxkk7c1T8tS Ogxn6+fp/hZ79cB0M2rpSmpUs5QP2tBhDcZ6jObEVwRlhiDrBIQKUQMxp/7UECsp+oU6YxYEAxD 0iLcJ2voh60MVY74CmWvx4FW44KUTuSO6WAgpHtruIolFirmgB++eSW+43J0G388PvA7DRwJYf9 9pJ7Dzibmdw97lsoFt/ps98dBBwtImlwWWj51IBh+Uj1L2Da8oLtqBl9cQ5PkmWZFOGVk7KK6n2 rsNrjnoFS47zohWk40bxtXY08jU25Lo5hDZLUwlIwkEGrHmSM54muETx+a13LAi/e9LjZET+HYW PgrDZvjhYMlC1R3/vUwr9pdktCQ1oAeVmPy3qovxNeYyUKBBGpAW7VaTeSGSETVfcqWs= X-Google-Smtp-Source: AGHT+IFc0VSLFdvV9Ws91KCXp/O3L8BaZaJSH/na/fmYztuvihQfOOHv47U3zveM369mJJJnN+Pi7g== X-Received: by 2002:a17:907:9812:b0:ae6:d51a:4ca3 with SMTP id a640c23a62f3a-af153e3379fmr374990166b.25.1753194579181; Tue, 22 Jul 2025 07:29:39 -0700 (PDT) Received: from localhost (144-178-202-139.static.ef-service.nl. [144.178.202.139]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-aec6ca2f1a7sm869524866b.91.2025.07.22.07.29.38 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 22 Jul 2025 07:29:38 -0700 (PDT) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Tue, 22 Jul 2025 16:29:38 +0200 Message-Id: Cc: "Bjorn Andersson" , "Linus Walleij" , "Krzysztof Kozlowski" , "Conor Dooley" , <~postmarketos/upstreaming@lists.sr.ht>, , , , , Subject: Re: [PATCH v2 1/2] dt-bindings: pinctrl: document the Milos Top Level Mode Multiplexer From: "Luca Weiss" To: "Rob Herring" X-Mailer: aerc 0.20.1-0-g2ecb8770224a-dirty References: <20250702-sm7635-pinctrl-v2-0-c138624b9924@fairphone.com> <20250702-sm7635-pinctrl-v2-1-c138624b9924@fairphone.com> <20250711182216.GA974600-robh@kernel.org> In-Reply-To: <20250711182216.GA974600-robh@kernel.org> Hi Rob, On Fri Jul 11, 2025 at 8:22 PM CEST, Rob Herring wrote: > On Wed, Jul 02, 2025 at 05:56:16PM +0200, Luca Weiss wrote: >> Document the Top Level Mode Multiplexer on the Milos Platform. >>=20 >> Signed-off-by: Luca Weiss >> --- >> .../bindings/pinctrl/qcom,milos-tlmm.yaml | 133 ++++++++++++++= +++++++ >> 1 file changed, 133 insertions(+) >>=20 >> diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,milos-tlmm.y= aml b/Documentation/devicetree/bindings/pinctrl/qcom,milos-tlmm.yaml >> new file mode 100644 >> index 0000000000000000000000000000000000000000..0091204df20a0eca7d0d0e76= 6afcb8d08042b015 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/pinctrl/qcom,milos-tlmm.yaml >> @@ -0,0 +1,133 @@ >> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >> +%YAML 1.2 >> +--- >> +$id: http://devicetree.org/schemas/pinctrl/qcom,milos-tlmm.yaml# >> +$schema: http://devicetree.org/meta-schemas/core.yaml# >> + >> +title: Qualcomm Technologies, Inc. Milos TLMM block >> + >> +maintainers: >> + - Luca Weiss >> + >> +description: >> + Top Level Mode Multiplexer pin controller in Qualcomm Milos SoC. >> + >> +allOf: >> + - $ref: /schemas/pinctrl/qcom,tlmm-common.yaml# >> + >> +properties: >> + compatible: >> + const: qcom,milos-tlmm >> + >> + reg: >> + maxItems: 1 >> + >> + interrupts: >> + maxItems: 1 >> + >> + gpio-reserved-ranges: >> + minItems: 1 >> + maxItems: 84 >> + >> + gpio-line-names: >> + maxItems: 167 >> + >> +patternProperties: >> + "-state$": > > type: object > > Because a boolean "foo-state;" would actually pass without. While the patch has been applied already, I'm happy to fix this for all Qualcomm pinctrl schemas, since pretty much all have this issue. Are you looking for a change like the following for all 60+ pinctrl/qcom,* schemas? If that's fine, I will prepare the changes and send them soon. Different sorting of properties, or moving "type: object" just below "-state$": would also work, not sure what you prefer. ++++++++++++++ diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,apq8084-pinctrl= .yaml b/Documentation/devicetree/bindings/pinctrl/qcom,apq8084-pinctrl.yaml index 38877d8b97ff..1d17abde246b 100644 --- a/Documentation/devicetree/bindings/pinctrl/qcom,apq8084-pinctrl.yaml +++ b/Documentation/devicetree/bindings/pinctrl/qcom,apq8084-pinctrl.yaml @@ -34,6 +34,7 @@ patternProperties: - patternProperties: "-pins$": $ref: "#/$defs/qcom-apq8084-tlmm-state" + type: object additionalProperties: false =20 $defs: diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,milos-tlmm.yaml= b/Documentation/devicetree/bindings/pinctrl/qcom,milos-tlmm.yaml index 0091204df20a..e277b884bf5c 100644 --- a/Documentation/devicetree/bindings/pinctrl/qcom,milos-tlmm.yaml +++ b/Documentation/devicetree/bindings/pinctrl/qcom,milos-tlmm.yaml @@ -39,6 +39,7 @@ patternProperties: - patternProperties: "-pins$": $ref: "#/$defs/qcom-milos-tlmm-state" + type: object additionalProperties: false =20 $defs: ++++++++++++++ Regards Luca > > With that, > > Reviewed-by: Rob Herring (Arm) > >> + oneOf: >> + - $ref: "#/$defs/qcom-milos-tlmm-state" >> + - patternProperties: >> + "-pins$": >> + $ref: "#/$defs/qcom-milos-tlmm-state" >> + additionalProperties: false