From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f65.google.com (mail-ed1-f65.google.com [209.85.208.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B5B3327780D for ; Wed, 23 Jul 2025 07:50:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.65 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753257016; cv=none; b=l0ZzNkLUPHuGMRsefiALAsaY9LlTPYWyYNO+z5fFdnFSTk2ij3Vf+PhvKZQDP6uejAqLMzGRMwWxZcKWLtElenRDtQ+lemTlThOjvjLHXEGvv1+9QyYO49kVJ3pewuso/lror7OEzSaKr6SsnCgiO0Z6c/7QX+0DOx1+8WvHGyQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753257016; c=relaxed/simple; bh=s2qj4W5nR9VUDrxKDMTXYV/rhF67N9Fs+yw/DNr1OSo=; h=Mime-Version:Content-Type:Date:Message-Id:From:To:Cc:Subject: References:In-Reply-To; b=SXPGOse1ZbHnOWmIvTygG5UEYqd01FcayYXjhF+UJ+c9a7PKtatXZCgZr4IUS28xqvKaQnXS0W7xsRqao/N6tIAF1N1XdTrRbVlKc/D+6JGgzgjNCvZLDG+UDPdOWdt3tuDWNQ8oQrNM03jRnhfj9pIhzIdMB5EsOLADYXg7nNY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=fairphone.com; spf=pass smtp.mailfrom=fairphone.com; dkim=pass (2048-bit key) header.d=fairphone.com header.i=@fairphone.com header.b=S6Gj6Muf; arc=none smtp.client-ip=209.85.208.65 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=fairphone.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=fairphone.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=fairphone.com header.i=@fairphone.com header.b="S6Gj6Muf" Received: by mail-ed1-f65.google.com with SMTP id 4fb4d7f45d1cf-60c01f70092so10872087a12.3 for ; Wed, 23 Jul 2025 00:50:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fairphone.com; s=fair; t=1753257012; x=1753861812; darn=vger.kernel.org; h=in-reply-to:references:subject:cc:to:from:message-id:date :content-transfer-encoding:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=yXbXFwg+K/BsGGE3U/llO+SOTqkjirp29B31EDd6IJk=; b=S6Gj6MufZogpDpLD6OLyGKZX/hTJuAUAJNpsUDAc8SjitpcO7ixApOaV/R6FMUvHST xdEfFa7EWx7RzmWJUSUvk25MKqph6eFmU9HuZeaBTdJ19+3/e0h6eG4SWwCJDdGEvMUx waiirmurZmFKL0axF8ccNzWmfgeLCuYXpB6SyuMDtEPR2EgE4mWn42dIOnV8V8+AA3ub Up3HcipiK5+uiprTVbJma/b4cYsc6QpfGyX2lg9nmOPWc2SY6HLSl660UM8rlVCHTRaL NkYe6ttE+iAidnzJLsHG3rTmravT3xMAgeW2ngDEOlGiCHvsVnGcqhHfW4Gy2+jlBaB0 SoAg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1753257012; x=1753861812; h=in-reply-to:references:subject:cc:to:from:message-id:date :content-transfer-encoding:mime-version:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=yXbXFwg+K/BsGGE3U/llO+SOTqkjirp29B31EDd6IJk=; b=W3K4F2Ph73ffogoAgQL1WXctti4Tz9CH1mGDJ/8wsDENa9kcWfCIp3NUF0i9m2+0/E JvSytsrbTVxh902o/x3ChGAP2lG+i+r1AqUXhisnlHFglBE8JI1mD++L53qV5B9E8ah8 vQdABfX/vGtm2vvam5h/NleYyC+4gm1p+3oZqIT7Vf529xXFJhD32/vIdtMw7O2L3YQW 3yawWNj6iMCmTqOKBB3MLiC3RSTka6pKpARl1xPxCDBIQp4P4Zw96tRAcx1gYX93xw19 +W4eazC1BaI0xj1tM/6UhU9LDuqQ9190Ku/WAiUd+whkaFHNn68JjDKWv7G7EyKtaZlH iVFw== X-Forwarded-Encrypted: i=1; AJvYcCVEF7HORSMvK6fVXjabfN3n5NRsjFMVzeBleNTPB2xgbOjv7M0tZLEMIcTJRLBTKFc/Kv5EkjzuoyZQyqs=@vger.kernel.org X-Gm-Message-State: AOJu0YzPWwZcX5MKKxaLXqJgj5yvCPQON8ak+S+h97SwkV1kGUEmVBgb 3hkqAA8oJzKBl8o19BbWlqPwFAxJZZy+I7vX2EAb3emqReojvlpMJfNx3PAtE9qRPDQ= X-Gm-Gg: ASbGnct4ANLP8N+3Eu8w4ps0lw4n5rkw/uETdkIaFi7Rn0UJwK5sGoMytO/YDngmu6D V6FUsn9ZaXzFSqK3uy7Fv36mgRd9X/vTHFDD/WGTT3hgxyrTiKlViuY57VdW5hAzD2dY4h+qpLI Rwsjg4d9FJlstuSeH7KLVA1aTczSdYASVl+2dI8Skz5TZK5JzA+0KE1btRXKqRGQxnEdnTiZTAL DeKhH7n6IpfLnLIWz7S02zEFylPjBk4p06tG/L4hquNXx3KYv+aDoO12PG7Hyj89jBEMPjG78ll 2nWib0WYjhH6I1RrQmXtw3nb4CFS+SXpZkAYXDChpKb7cAbQMbSyx34AGjIQYzPKSQ+zSXtV5EI 2KIsiEa+3BS1Z/HMwIq3o0bjDy5PCVtjPX5EXmf1GgU0aMRlw6fSWQMara91YU0ybsU4= X-Google-Smtp-Source: AGHT+IHwBbnn1eUxlgv795d4NlYs1iTsVyOVnuelCygX33CjO30R0OB3cx1QUaH2Utrn1rESZ1YrZQ== X-Received: by 2002:a17:907:986:b0:ad8:9e80:6bc3 with SMTP id a640c23a62f3a-af2f66c2165mr184740066b.1.1753257011912; Wed, 23 Jul 2025 00:50:11 -0700 (PDT) Received: from localhost (144-178-202-139.static.ef-service.nl. [144.178.202.139]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-aec6ca2ee01sm1007709266b.81.2025.07.23.00.50.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 23 Jul 2025 00:50:11 -0700 (PDT) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Wed, 23 Jul 2025 09:50:10 +0200 Message-Id: From: "Luca Weiss" To: "Luca Weiss" , "Georgi Djakov" , "Rob Herring" , "Krzysztof Kozlowski" , "Conor Dooley" Cc: <~postmarketos/upstreaming@lists.sr.ht>, , , , , Subject: Re: [PATCH v3 2/2] interconnect: qcom: Add Milos interconnect provider driver X-Mailer: aerc 0.20.1-0-g2ecb8770224a-dirty References: <20250709-sm7635-icc-v3-0-c446203c3b3a@fairphone.com> <20250709-sm7635-icc-v3-2-c446203c3b3a@fairphone.com> In-Reply-To: Hi Georgi, On Mon Jul 21, 2025 at 9:42 AM CEST, Luca Weiss wrote: > Hi Georgi, > > On Mon Jul 21, 2025 at 9:36 AM CEST, Georgi Djakov wrote: >> Hi Luca, >> >> On 7/9/25 4:14 PM, Luca Weiss wrote: >>> Add driver for the Qualcomm interconnect buses found in Milos based >>> platforms. The topology consists of several NoCs that are controlled by >>> a remote processor that collects the aggregated bandwidth for each >>> master-slave pairs. >>>=20 >>> Signed-off-by: Luca Weiss >>> --- >>> drivers/interconnect/qcom/Kconfig | 9 + >>> drivers/interconnect/qcom/Makefile | 2 + >>> drivers/interconnect/qcom/milos.c | 1837 +++++++++++++++++++++++++++= +++++++++ >>> 3 files changed, 1848 insertions(+) >>>=20 >> [..] >>> + >>> +static struct qcom_icc_node qhm_qup1 =3D { >>> + .name =3D "qhm_qup1", >>> + .channels =3D 1, >>> + .buswidth =3D 4, >>> + .qosbox =3D &qhm_qup1_qos, >>> + .link_nodes =3D { &qns_a1noc_snoc, NULL }, >>> +}; >> >> It's very nice that you switched to the dynamic IDs, but please use the >> current style of links (like in v1), as the the NULL terminated lists >> are not merged yet. All the rest looks good! > > Is what's in todays linux-next a good base? Or what branch should I base > this on? But correct, I currently have v2 of dynamic ID patches in the > base for this. > > Also If I send the next revision by e.g. Wednesday can it still go into > 6.17? Just wondering how quick I need to work on this. In case you didn't receive my message on IRC, your icc-milos branch plus the following patch works fine: https://public.lucaweiss.eu/tmp/0001-fixup-interconnect-qcom-Add-Milos-inte= rconnect-provi.patch One num_nodes was wrong, and alloc_dyn_id needs to still be set without the extra patches from the mailing list. Regards Luca > > Regards > Luca > >> >> Thanks, >> Georgi