From: "Benno Lossin" <lossin@kernel.org>
To: "Tamir Duberstein" <tamird@gmail.com>,
"Miguel Ojeda" <miguel.ojeda.sandonis@gmail.com>
Cc: "Miguel Ojeda" <ojeda@kernel.org>,
"Alex Gaynor" <alex.gaynor@gmail.com>,
"Boqun Feng" <boqun.feng@gmail.com>,
"Gary Guo" <gary@garyguo.net>,
"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
"Andreas Hindborg" <a.hindborg@kernel.org>,
"Alice Ryhl" <aliceryhl@google.com>,
"Trevor Gross" <tmgross@umich.edu>,
"Danilo Krummrich" <dakr@kernel.org>,
rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] rust: remove spurious compiler_builtins dependents
Date: Wed, 23 Jul 2025 21:53:05 +0200 [thread overview]
Message-ID: <DBJP45SOWFQI.3FY7X96EZT2HG@kernel.org> (raw)
In-Reply-To: <CAJ-ks9kuCTnmhJRJyuuyGST-W_9TDQkg8iWm3YoOtP7_d_NR0w@mail.gmail.com>
On Wed Jul 23, 2025 at 5:18 PM CEST, Tamir Duberstein wrote:
> On Mon, Jul 21, 2025 at 8:25 AM Miguel Ojeda
> <miguel.ojeda.sandonis@gmail.com> wrote:
>>
>> On Sun, Jul 20, 2025 at 7:20 PM Tamir Duberstein <tamird@gmail.com> wrote:
>> >
>> > Remove these dependency edges.
>>
>> I should have replied in previous versions: this is wrong -- the 3
>> changes each individually break the build.
>>
>> I guess that you are not cleaning everything in your tests before
>> testing the build.
>
> You're absolutely right, this patch is incorrect. I was indeed not
> blowing away build artifcats.
So is the `compiler_builtins` dependency correct for all crates?
---
Cheers,
Benno
next prev parent reply other threads:[~2025-07-23 19:53 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-20 17:20 Tamir Duberstein
2025-07-21 5:54 ` kernel test robot
2025-07-21 11:56 ` Alice Ryhl
2025-07-21 12:25 ` Miguel Ojeda
2025-07-23 15:18 ` Tamir Duberstein
2025-07-23 19:53 ` Benno Lossin [this message]
2025-07-23 20:12 ` Tamir Duberstein
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DBJP45SOWFQI.3FY7X96EZT2HG@kernel.org \
--to=lossin@kernel.org \
--cc=a.hindborg@kernel.org \
--cc=alex.gaynor@gmail.com \
--cc=aliceryhl@google.com \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun.feng@gmail.com \
--cc=dakr@kernel.org \
--cc=gary@garyguo.net \
--cc=linux-kernel@vger.kernel.org \
--cc=miguel.ojeda.sandonis@gmail.com \
--cc=ojeda@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=tamird@gmail.com \
--cc=tmgross@umich.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®