From: "Danilo Krummrich" <dakr@kernel.org>
To: "David Gow" <davidgow@google.com>
Cc: "Hui Zhu" <hui.zhu@linux.dev>,
"Lorenzo Stoakes" <lorenzo.stoakes@oracle.com>,
"Vlastimil Babka" <vbabka@suse.cz>,
"Liam R . Howlett" <Liam.Howlett@oracle.com>,
"Uladzislau Rezki" <urezki@gmail.com>,
"Miguel Ojeda" <ojeda@kernel.org>,
"Alex Gaynor" <alex.gaynor@gmail.com>,
"Boqun Feng" <boqun.feng@gmail.com>,
"Gary Guo" <gary@garyguo.net>, <bjorn3_gh@protonmail.com>,
"Benno Lossin" <lossin@kernel.org>,
"Andreas Hindborg" <a.hindborg@kernel.org>,
"Alice Ryhl" <aliceryhl@google.com>,
"Trevor Gross" <tmgross@umich.edu>,
<rust-for-linux@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<akpm@linux-foundation.org>, <vitaly.wool@konsulko.se>,
"Hui Zhu" <zhuhui@kylinos.cn>
Subject: Re: [PATCH v7 0/3] Rust allocator and kvec improvements
Date: Thu, 31 Jul 2025 11:01:02 +0200 [thread overview]
Message-ID: <DBQ499KC66B1.2YNYBXUG343HK@kernel.org> (raw)
In-Reply-To: <CABVgOSkphk7X8nKGePTf88RzW91Pb8NPAbryVvL=zQ370o62RQ@mail.gmail.com>
On Thu Jul 31, 2025 at 6:14 AM CEST, David Gow wrote:
> On Thu, 31 Jul 2025 at 10:51, Hui Zhu <hui.zhu@linux.dev> wrote:
>>
>> From: Hui Zhu <zhuhui@kylinos.cn>
>>
>> This series adds tests and docs for Rust kernel components:
>> Patch 1 adds KUnit tests for allocator alignment guarantees.
>> Patch 2 documents KVec::as_slice with a usage example.
>> Patch 3 simplifies KVec test module naming convention.
>>
>> Both patches are co-developed with Geliang Tang. Based on [1].
>> Tested on x86_64 using KUnit.
>>
>
> This series looks good to me from a KUnit perspective. I've also
> tested it out across a bunch of architectures (UML, x86_64, arm,
> arm64) with no problems.
>
> A few minor notes:
> - You should squash patch 3 into patch 1: there's no need to introduce
> the test with one name only to rename it in a later patch.
The test introduced in patch 1 is not the one renamed in patch 3. :)
next prev parent reply other threads:[~2025-07-31 9:01 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-31 2:50 Hui Zhu
2025-07-31 2:50 ` [PATCH v7 1/3] rust: allocator: add KUnit tests for alignment guarantees Hui Zhu
2025-07-31 9:19 ` Danilo Krummrich
2025-08-13 16:48 ` Danilo Krummrich
2025-07-31 2:50 ` [PATCH v7 2/3] rust: alloc: kvec: add doc example for as_slice method Hui Zhu
2025-07-31 2:50 ` [PATCH v7 3/3] rust: alloc: kvec: simplify KUnit test module name to "rust_kvec" Hui Zhu
2025-07-31 4:14 ` [PATCH v7 0/3] Rust allocator and kvec improvements David Gow
2025-07-31 9:01 ` Danilo Krummrich [this message]
2025-08-15 17:53 ` Danilo Krummrich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DBQ499KC66B1.2YNYBXUG343HK@kernel.org \
--to=dakr@kernel.org \
--cc=Liam.Howlett@oracle.com \
--cc=a.hindborg@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=alex.gaynor@gmail.com \
--cc=aliceryhl@google.com \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun.feng@gmail.com \
--cc=davidgow@google.com \
--cc=gary@garyguo.net \
--cc=hui.zhu@linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=lorenzo.stoakes@oracle.com \
--cc=lossin@kernel.org \
--cc=ojeda@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=tmgross@umich.edu \
--cc=urezki@gmail.com \
--cc=vbabka@suse.cz \
--cc=vitaly.wool@konsulko.se \
--cc=zhuhui@kylinos.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®